Hadoop Common
  1. Hadoop Common
  2. HADOOP-7900

LocalDirAllocator confChanged() accesses conf.get() twice

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.1, 0.24.0
    • Fix Version/s: 2.0.0-alpha
    • Component/s: fs
    • Labels:
      None

      Description

      LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method — So the comparison is wrong.

      1. HADOOP-7900.patch
        0.9 kB
        Ravi Gummadi

        Activity

        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Arun C Murthy made changes -
        Fix Version/s 2.0.0 [ 12320352 ]
        Fix Version/s 0.24.0 [ 12317652 ]
        Fix Version/s 0.23.3 [ 12320059 ]
        Uma Maheswara Rao G made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Target Version/s 0.24.0, 0.23.3 [ 12317652, 12320059 ]
        Fix Version/s 0.24.0 [ 12317652 ]
        Resolution Fixed [ 1 ]
        Arun C Murthy made changes -
        Fix Version/s 0.23.3 [ 12320059 ]
        Fix Version/s 0.23.1 [ 12318884 ]
        Ravi Gummadi made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Ravi Gummadi made changes -
        Attachment HADOOP-7900.patch [ 12506752 ]
        Ravi Gummadi made changes -
        Assignee Ravi Gummadi [ ravidotg ]
        Ravi Gummadi made changes -
        Field Original Value New Value
        Environment mr
        Description LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
        Component/s fs [ 12310689 ]
        Ravi Gummadi created issue -

          People

          • Assignee:
            Ravi Gummadi
            Reporter:
            Ravi Gummadi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development