Hadoop Common
  1. Hadoop Common
  2. HADOOP-7892

IPC logs too verbose after "RpcKind" introduction

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 2.0.0-alpha
    • Component/s: ipc
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Recently in trunk I started seeing the following log messages on every IPC connection:
      11/12/07 15:56:49 INFO ipc.Server: rpcKind=RPC_WRITABLE, rpcRequestWrapperClass=class org.apache.hadoop.ipc.WritableRpcEngine$Invocation, rpcInvoker=org.apache.hadoop.ipc.WritableRpcEngine$Server$WritableRpcInvoker@320cf66b
      which is probably more appropriately at DEBUG or TRACE level

      1. hadoop-7892.txt
        0.9 kB
        Todd Lipcon

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          2d 23h 22m 1 Todd Lipcon 10/Dec/11 23:21
          Patch Available Patch Available Resolved Resolved
          2d 22h 38m 1 Todd Lipcon 13/Dec/11 22:00
          Resolved Resolved Closed Closed
          161d 22h 15m 1 Arun C Murthy 23/May/12 21:15
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Arun C Murthy made changes -
          Fix Version/s 2.0.0 [ 12320352 ]
          Fix Version/s 0.24.0 [ 12317652 ]
          Fix Version/s 0.23.3 [ 12320059 ]
          Tsz Wo Nicholas Sze made changes -
          Fix Version/s 0.23.3 [ 12320059 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have merged this to 0.23.

          Show
          Tsz Wo Nicholas Sze added a comment - I have merged this to 0.23.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #894 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/894/)
          HADOOP-7892. IPC logs too verbose after "RpcKind" introduction. Contributed by Todd Lipcon.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213954
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #894 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/894/ ) HADOOP-7892 . IPC logs too verbose after "RpcKind" introduction. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213954 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #927 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/927/)
          HADOOP-7892. IPC logs too verbose after "RpcKind" introduction. Contributed by Todd Lipcon.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213954
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #927 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/927/ ) HADOOP-7892 . IPC logs too verbose after "RpcKind" introduction. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213954 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1440 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1440/)
          HADOOP-7892. IPC logs too verbose after "RpcKind" introduction. Contributed by Todd Lipcon.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213954
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1440 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1440/ ) HADOOP-7892 . IPC logs too verbose after "RpcKind" introduction. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213954 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1415 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1415/)
          HADOOP-7892. IPC logs too verbose after "RpcKind" introduction. Contributed by Todd Lipcon.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213954
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1415 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1415/ ) HADOOP-7892 . IPC logs too verbose after "RpcKind" introduction. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213954 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1489 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1489/)
          HADOOP-7892. IPC logs too verbose after "RpcKind" introduction. Contributed by Todd Lipcon.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213954
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1489 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1489/ ) HADOOP-7892 . IPC logs too verbose after "RpcKind" introduction. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1213954 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          Todd Lipcon made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 0.24.0 [ 12317652 ]
          Resolution Fixed [ 1 ]
          Hide
          Todd Lipcon added a comment -

          Committed, thx

          Show
          Todd Lipcon added a comment - Committed, thx
          Hide
          Eli Collins added a comment -

          +1

          Show
          Eli Collins added a comment - +1
          Hide
          Todd Lipcon added a comment -

          -1 javadoc seems to be existing issues from trunk. -1 tests because this is a trivial logging change.

          Show
          Todd Lipcon added a comment - -1 javadoc seems to be existing issues from trunk. -1 tests because this is a trivial logging change.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12506875/hadoop-7892.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 javadoc. The javadoc tool appears to have generated 5 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/463//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/463//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12506875/hadoop-7892.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 5 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/463//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/463//console This message is automatically generated.
          Todd Lipcon made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Todd Lipcon made changes -
          Attachment hadoop-7892.txt [ 12506875 ]
          Todd Lipcon made changes -
          Field Original Value New Value
          Link This issue relates to HADOOP-7862 [ HADOOP-7862 ]
          Todd Lipcon created issue -

            People

            • Assignee:
              Todd Lipcon
              Reporter:
              Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development