Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.3-alpha, 0.23.7
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Tags:
      newbie

      Description

      It would be nice if FileStatus had a reasonable toString, for debugging purposes.

      1. HDFS-2215_common.patch
        1 kB
        SreeHari
      2. HDFS-2215.patch
        1 kB
        SreeHari

        Activity

        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #498 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/498/)
        HADOOP-7886 Add toString to FileStatus (SreeHari via tgraves) (Revision 1434851)

        Result = FAILURE
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1434851
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileStatus.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #498 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/498/ ) HADOOP-7886 Add toString to FileStatus (SreeHari via tgraves) (Revision 1434851) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1434851 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileStatus.java
        Hide
        tgraves Thomas Graves added a comment -

        I merged this to branch-0.23, it also previously got pulled into branch-2 with HADOOP-9147.

        Show
        tgraves Thomas Graves added a comment - I merged this to branch-0.23, it also previously got pulled into branch-2 with HADOOP-9147 .
        Hide
        jacsparrow SreeHari added a comment -

        @Jakob Thanks for the commit

        Show
        jacsparrow SreeHari added a comment - @Jakob Thanks for the commit
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #919 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/919/)
        HADOOP-7886. Add toString to FileStatus. Contributed by SreeHari.

        jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210793
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileStatus.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #919 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/919/ ) HADOOP-7886 . Add toString to FileStatus. Contributed by SreeHari. jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210793 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileStatus.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #886 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/886/)
        HADOOP-7886. Add toString to FileStatus. Contributed by SreeHari.

        jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210793
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileStatus.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #886 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/886/ ) HADOOP-7886 . Add toString to FileStatus. Contributed by SreeHari. jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210793 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileStatus.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1396 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1396/)
        HADOOP-7886. Add toString to FileStatus. Contributed by SreeHari.

        jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210793
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileStatus.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1396 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1396/ ) HADOOP-7886 . Add toString to FileStatus. Contributed by SreeHari. jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210793 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileStatus.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1372 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1372/)
        HADOOP-7886. Add toString to FileStatus. Contributed by SreeHari.

        jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210793
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileStatus.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1372 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1372/ ) HADOOP-7886 . Add toString to FileStatus. Contributed by SreeHari. jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210793 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileStatus.java
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1444 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1444/)
        HADOOP-7886. Add toString to FileStatus. Contributed by SreeHari.

        jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210793
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileStatus.java
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1444 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1444/ ) HADOOP-7886 . Add toString to FileStatus. Contributed by SreeHari. jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1210793 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileStatus.java
        Hide
        jghoman Jakob Homan added a comment -

        +1. Javadoc warnings are spurious. I've committed this. Resolving.

        Show
        jghoman Jakob Homan added a comment - +1. Javadoc warnings are spurious. I've committed this. Resolving.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12506217/HDFS-2215_common.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javadoc. The javadoc tool appears to have generated 9 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/436//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/436//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12506217/HDFS-2215_common.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 9 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/436//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/436//console This message is automatically generated.
        Hide
        jacsparrow SreeHari added a comment -

        @Uma Okay thanks , I've reuploaded the patch for hudson to pick it up .

        Show
        jacsparrow SreeHari added a comment - @Uma Okay thanks , I've reuploaded the patch for hudson to pick it up .
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        Hi Sreehari, I just moved it to common project, since the changes are in common.

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - Hi Sreehari, I just moved it to common project, since the changes are in common.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12506131/HDFS-2215.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1637//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12506131/HDFS-2215.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1637//console This message is automatically generated.
        Hide
        jacsparrow SreeHari added a comment -

        Attached the patch .

        toString implementation will be (sample)-
        For File :
        FileStatus

        {path=/testfile; isDirectory=false; length=1234; replication=3; blocksize=67108864; owner=root; group=supergroup; permission=--xr--r--}

        For Directory :
        FileStatus

        {path=/testfile; isDirectory=true; owner=root; group=supergroup; permission=--xr--r--}

        Did not attach test case since doesn't seem to add any value for this change . If required , can add one .

        Show
        jacsparrow SreeHari added a comment - Attached the patch . toString implementation will be (sample)- For File : FileStatus {path=/testfile; isDirectory=false; length=1234; replication=3; blocksize=67108864; owner=root; group=supergroup; permission=--xr--r--} For Directory : FileStatus {path=/testfile; isDirectory=true; owner=root; group=supergroup; permission=--xr--r--} Did not attach test case since doesn't seem to add any value for this change . If required , can add one .

          People

          • Assignee:
            jacsparrow SreeHari
            Reporter:
            jghoman Jakob Homan
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development