[HADOOP-7833] Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0-alpha
• Component/s: ipc
• Target Version/s: 0.24.0
• Hadoop Flags: Reviewed
• Assignee: John Lee
• Reporter: John Lee
• Created: 17/Nov/11 23:40
• Updated: 23/May/12 20:16
• Resolved: 21/Nov/11 06:40

Description

findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:

• SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
• SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
• UCF_USELESS_CONTROL_FLOW: Useless control flow

This can be fixed by adding the following findbugs exclude filter:

+ <Match>
+ <!-- protobuf generated code -->
+ <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
+ </Match>

which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos