Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-7818

DiskChecker#checkDir should fail if the directory is not executable

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.0.0-alpha
    • 2.0.2-alpha
    • util
    • None
    • Reviewed

    Description

      DiskChecker#checkDir fails if a directory can't be created, read, or written but does not fail if the directory exists and is not executable. This causes subsequent code to think the directory is OK but later fail due to an inability to access the directory (eg see MAPREDUCE-2921). I propose checkDir fails if the directory is not executable. Looking at the uses, this should be fine, I think it was ignored because checkDir is often used to create directories and it creates executable directories.

      Attachments

        1. HADOOP-7818.patch
          0.7 kB
          madhukara phatak
        2. HADOOP-7818-1.patch
          1 kB
          madhukara phatak
        3. HADOOP-7818-2.patch
          3 kB
          madhukara phatak
        4. HADOOP-7818-3.patch
          3 kB
          madhukara phatak
        5. HADOOP-7818-4.patch
          3 kB
          Harsh J

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            phatak.dev madhukara phatak
            eli Eli Collins
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment