Hadoop Common
  1. Hadoop Common
  2. HADOOP-7787

Make source tarball use conventional name.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.1
    • Component/s: build
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      When building binary and source tarballs, I get the following artifacts:
      Binary tarball: hadoop-0.23.0-SNAPSHOT.tar.gz
      Source tarball: hadoop-dist-0.23.0-SNAPSHOT-src.tar.gz

      Notice the "-dist" right between "hadoop" and the version in the source tarball name.

      1. HADOOP-7787-2.patch
        1 kB
        Bruno Mahé
      2. HADOOP-7787.patch
        2 kB
        Bruno Mahé

        Activity

        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #901 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/901/)
        HADOOP-7787. Make source tarball use conventional name. Contributed by Bruno Mahé

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203437
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #901 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/901/ ) HADOOP-7787 . Make source tarball use conventional name. Contributed by Bruno Mahé tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203437 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #97 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/97/)
        Merge -r 1203436:1203437 from trunk to branch-0.23. Fixes: HADOOP-7787

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203438
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #97 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/97/ ) Merge -r 1203436:1203437 from trunk to branch-0.23. Fixes: HADOOP-7787 tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203438 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #867 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/867/)
        HADOOP-7787. Make source tarball use conventional name. Contributed by Bruno Mahé

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203437
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #867 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/867/ ) HADOOP-7787 . Make source tarball use conventional name. Contributed by Bruno Mahé tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203437 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #80 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/80/)
        Merge -r 1203436:1203437 from trunk to branch-0.23. Fixes: HADOOP-7787

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203438
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #80 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/80/ ) Merge -r 1203436:1203437 from trunk to branch-0.23. Fixes: HADOOP-7787 tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203438 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #191 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/191/)
        Merge -r 1203436:1203437 from trunk to branch-0.23. Fixes: HADOOP-7787

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203438
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #191 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/191/ ) Merge -r 1203436:1203437 from trunk to branch-0.23. Fixes: HADOOP-7787 tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203438 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1305 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1305/)
        HADOOP-7787. Make source tarball use conventional name. Contributed by Bruno Mahé

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203437
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1305 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1305/ ) HADOOP-7787 . Make source tarball use conventional name. Contributed by Bruno Mahé tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203437 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #178 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/178/)
        Merge -r 1203436:1203437 from trunk to branch-0.23. Fixes: HADOOP-7787

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203438
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #178 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/178/ ) Merge -r 1203436:1203437 from trunk to branch-0.23. Fixes: HADOOP-7787 tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203438 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #179 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/179/)
        Merge -r 1203436:1203437 from trunk to branch-0.23. Fixes: HADOOP-7787

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203438
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #179 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/179/ ) Merge -r 1203436:1203437 from trunk to branch-0.23. Fixes: HADOOP-7787 tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203438 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1281 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1281/)
        HADOOP-7787. Make source tarball use conventional name. Contributed by Bruno Mahé

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203437
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1281 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1281/ ) HADOOP-7787 . Make source tarball use conventional name. Contributed by Bruno Mahé tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203437 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/pom.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1355 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1355/)
        HADOOP-7787. Make source tarball use conventional name. Contributed by Bruno Mahé

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203437
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/pom.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1355 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1355/ ) HADOOP-7787 . Make source tarball use conventional name. Contributed by Bruno Mahé tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1203437 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/pom.xml
        Tom White made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.23.1 [ 12318884 ]
        Resolution Fixed [ 1 ]
        Hide
        Tom White added a comment -

        I've just committed this. Thanks Bruno!

        Show
        Tom White added a comment - I've just committed this. Thanks Bruno!
        Tom White made changes -
        Summary binary and source tarball names are not consistent Make source tarball use conventional name.
        Assignee Bruno Mahé [ bmahe ]
        Hide
        Bruno Mahé added a comment -

        ping

        Show
        Bruno Mahé added a comment - ping
        Bruno Mahé made changes -
        Labels bigtop
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12502796/HADOOP-7787-2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/363//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12502796/HADOOP-7787-2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/363//console This message is automatically generated.
        Bruno Mahé made changes -
        Attachment HADOOP-7787-2.patch [ 12502796 ]
        Hide
        Bruno Mahé added a comment -

        Please find attached a patch which will only modify the way source tarballs are built.

        Although I used to be confused by the artifacts produced by Hadoop. Usually, the main artifact is the one named <NAME>-<VERSION>.tar.gz, and convenient ones are the one with suffixes.

        Show
        Bruno Mahé added a comment - Please find attached a patch which will only modify the way source tarballs are built. Although I used to be confused by the artifacts produced by Hadoop. Usually, the main artifact is the one named <NAME>-<VERSION>.tar.gz, and convenient ones are the one with suffixes.
        Hide
        Tom White added a comment -

        I would suggest hadoop-$

        {project.version}.tar.gz for the binary and hadoop-${project.version}

        -src.tar.gz for the source. We haven't used a -bin suffix in Hadoop before, and this is consistent with the 0.23.0 release candidate Arun created last week (http://people.apache.org/~acmurthy/hadoop-0.23.0-rc2/).

        Show
        Tom White added a comment - I would suggest hadoop-$ {project.version}.tar.gz for the binary and hadoop-${project.version} -src.tar.gz for the source. We haven't used a -bin suffix in Hadoop before, and this is consistent with the 0.23.0 release candidate Arun created last week ( http://people.apache.org/~acmurthy/hadoop-0.23.0-rc2/ ).
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12501714/HADOOP-7787.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/348//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12501714/HADOOP-7787.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/348//console This message is automatically generated.
        Bruno Mahé made changes -
        Attachment HADOOP-7787.patch [ 12501714 ]
        Hide
        Bruno Mahé added a comment -

        As an exemple, here are the produced artefacts from hadoop-dist/target/:
        rw-rw-r- 1 bruno bruno 41928210 Oct 31 18:23 hadoop-0.23.0-SNAPSHOT-bin.tar.gz
        rw-rw-r- 1 bruno bruno 13722578 Oct 31 18:04 hadoop-0.23.0-SNAPSHOT-src.tar.gz

        Show
        Bruno Mahé added a comment - As an exemple, here are the produced artefacts from hadoop-dist/target/: rw-rw-r - 1 bruno bruno 41928210 Oct 31 18:23 hadoop-0.23.0-SNAPSHOT-bin.tar.gz rw-rw-r - 1 bruno bruno 13722578 Oct 31 18:04 hadoop-0.23.0-SNAPSHOT-src.tar.gz
        Bruno Mahé made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Bruno Mahé added a comment -

        Here is the tony patch doing the following:

        • It removes the "-dist" in the source tarball
        • It adds a "-bin" suffix to the binary tarball to be more aligned with other Apache artifacts
        Show
        Bruno Mahé added a comment - Here is the tony patch doing the following: It removes the "-dist" in the source tarball It adds a "-bin" suffix to the binary tarball to be more aligned with other Apache artifacts
        Bruno Mahé created issue -

          People

          • Assignee:
            Bruno Mahé
            Reporter:
            Bruno Mahé
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development