Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 2.0.0-alpha
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This jira adds support for protocol buffer RPC engine.

      1. HADOOP-7773.txt
        173 kB
        Suresh Srinivas
      2. HADOOP-7773.txt
        173 kB
        Suresh Srinivas
      3. HADOOP-7773.txt
        172 kB
        Suresh Srinivas
      4. HADOOP-7773.txt
        171 kB
        Suresh Srinivas
      5. HADOOP-7773.txt
        85 kB
        Suresh Srinivas

        Issue Links

          Activity

          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have merged this to 0.23.

          Show
          Tsz Wo Nicholas Sze added a comment - I have merged this to 0.23.
          Hide
          Eli Collins added a comment -

          Filed HADOOP-7796 for the findbugs errors that were introduced.

          Show
          Eli Collins added a comment - Filed HADOOP-7796 for the findbugs errors that were introduced.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #878 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/878/)
          HADOOP-7773. Add support for protocol buffer based RPC engine. Contributed by Suresh Srinivas.

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190611
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcServerException.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto/hadoop_rpc.proto
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestProtos.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test.proto
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #878 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/878/ ) HADOOP-7773 . Add support for protocol buffer based RPC engine. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190611 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcServerException.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto/hadoop_rpc.proto /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestProtos.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test.proto /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #847 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/847/)
          HADOOP-7773. Add support for protocol buffer based RPC engine. Contributed by Suresh Srinivas.

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190611
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcServerException.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto/hadoop_rpc.proto
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestProtos.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test.proto
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #847 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/847/ ) HADOOP-7773 . Add support for protocol buffer based RPC engine. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190611 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcServerException.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto/hadoop_rpc.proto /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestProtos.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test.proto /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #1193 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1193/)
          HADOOP-7773. Add support for protocol buffer based RPC engine. Contributed by Suresh Srinivas.

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190611
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcServerException.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto/hadoop_rpc.proto
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestProtos.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test.proto
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1193 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1193/ ) HADOOP-7773 . Add support for protocol buffer based RPC engine. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190611 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcServerException.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto/hadoop_rpc.proto /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestProtos.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test.proto /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1269 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1269/)
          HADOOP-7773. Add support for protocol buffer based RPC engine. Contributed by Suresh Srinivas.

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190611
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcServerException.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto/hadoop_rpc.proto
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestProtos.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test.proto
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1269 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1269/ ) HADOOP-7773 . Add support for protocol buffer based RPC engine. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190611 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcServerException.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto/hadoop_rpc.proto /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestProtos.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test.proto /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #1215 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1215/)
          HADOOP-7773. Add support for protocol buffer based RPC engine. Contributed by Suresh Srinivas.

          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190611
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcServerException.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto/hadoop_rpc.proto
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestProtos.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test.proto
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1215 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1215/ ) HADOOP-7773 . Add support for protocol buffer based RPC engine. Contributed by Suresh Srinivas. suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190611 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcServerException.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto/hadoop_rpc.proto /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestProtos.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test.proto /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
          Hide
          Suresh Srinivas added a comment -

          I committed the patch.

          Show
          Suresh Srinivas added a comment - I committed the patch.
          Hide
          Suresh Srinivas added a comment -

          I am going to commit the patch, since I could not fix findbugs issue from the generated code with a filter. This probably is a build issue.

          Show
          Suresh Srinivas added a comment - I am going to commit the patch, since I could not fix findbugs issue from the generated code with a filter. This probably is a build issue.
          Hide
          Sanjay Radia added a comment -

          Thanks for adding the test.
          +1

          Show
          Sanjay Radia added a comment - Thanks for adding the test. +1
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12501167/HADOOP-7773.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 17 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/335//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/335//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/335//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12501167/HADOOP-7773.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 17 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/335//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/335//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/335//console This message is automatically generated.
          Hide
          Suresh Srinivas added a comment -

          The filter change did not seem to work. Doing it in another way.

          For some reason, my local build gives 179 findbugs warnings!

          Show
          Suresh Srinivas added a comment - The filter change did not seem to work. Doing it in another way. For some reason, my local build gives 179 findbugs warnings!
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12501033/HADOOP-7773.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 17 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/329//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/329//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/329//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12501033/HADOOP-7773.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 17 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/329//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/329//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/329//console This message is automatically generated.
          Hide
          Suresh Srinivas added a comment -

          findbugs warnings are due to generated code. New patch adds findbug filter to suppress these warnings.

          Show
          Suresh Srinivas added a comment - findbugs warnings are due to generated code. New patch adds findbug filter to suppress these warnings.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12500987/HADOOP-7773.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 17 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/327//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/327//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/327//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12500987/HADOOP-7773.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 17 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/327//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/327//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/327//console This message is automatically generated.
          Hide
          Sanjay Radia added a comment -

          Agree - making the parameter types use generics can only be done if the lower layer also supports it. Separate Jira.

          Show
          Sanjay Radia added a comment - Agree - making the parameter types use generics can only be done if the lower layer also supports it. Separate Jira.
          Hide
          Suresh Srinivas added a comment -

          Updated patch.

          Show
          Suresh Srinivas added a comment - Updated patch.
          Hide
          Suresh Srinivas added a comment -

          I added test for protobuf RPC engine.

          Sanjay as regards to your comment, it is better to be done starting the base class RpcEngine.Server

          Show
          Suresh Srinivas added a comment - I added test for protobuf RPC engine. Sanjay as regards to your comment, it is better to be done starting the base class RpcEngine.Server
          Hide
          Sanjay Radia added a comment -

          Please replace your

          public Server(Object instance, Configuration conf, String bindAddress,
                  int port, int numHandlers, int numReaders, int queueSizePerHandler,
                  boolean verbose, SecretManager<? extends TokenIdentifier> secretManager)
          

          by

          public <PROTO, IMPL extends PROTO> Server(Class<PROTO> protocolClass, IMPL protocolImpl,
                  Configuration conf, String bindAddress,  int port,
                  int numHandlers, int numReaders, int queueSizePerHandler, 
                  boolean verbose, SecretManager<? extends TokenIdentifier> secretManager) 
          

          Also change your RPC.server getServer(...) accordingly.

          Style suggestion.
          You have 2 methods after your "static class Server"; please move them to before so that all the methods of ProtobufRpcEngine are together.

          Please add tests.
          +1 otherwise.

          Show
          Sanjay Radia added a comment - Please replace your public Server( Object instance, Configuration conf, String bindAddress, int port, int numHandlers, int numReaders, int queueSizePerHandler, boolean verbose, SecretManager<? extends TokenIdentifier> secretManager) by public <PROTO, IMPL extends PROTO> Server( Class <PROTO> protocolClass, IMPL protocolImpl, Configuration conf, String bindAddress, int port, int numHandlers, int numReaders, int queueSizePerHandler, boolean verbose, SecretManager<? extends TokenIdentifier> secretManager) Also change your RPC.server getServer(...) accordingly. Style suggestion. You have 2 methods after your "static class Server"; please move them to before so that all the methods of ProtobufRpcEngine are together. Please add tests. +1 otherwise.
          Hide
          Todd Lipcon added a comment -

          I think we should have at least a simple test in the Common project – otherwise we'll only rely on cross-project test breakage when we make changes to this code. But I'm OK with the tests happening as a follow-up JIRA.

          Show
          Todd Lipcon added a comment - I think we should have at least a simple test in the Common project – otherwise we'll only rely on cross-project test breakage when we make changes to this code. But I'm OK with the tests happening as a follow-up JIRA.
          Hide
          Suresh Srinivas added a comment -

          I tested it by moving JournalProtocol in HDFS to protobuf and testing it. Unfortunately I had to hack a lot of things in HDFS to have two RPC servers one for writable and one for protobuf (currently both protocols cannot be supported by the same RPC server, since an RPC engine is chosen as Writable or Protobuf but not both).

          Writing test means, having a test.proto etc. Thought I can avoid that work, since HDFS will move to protobuf and this gets tested as a part of that. If we still feel it is worth having tests, I will put in that time.

          Show
          Suresh Srinivas added a comment - I tested it by moving JournalProtocol in HDFS to protobuf and testing it. Unfortunately I had to hack a lot of things in HDFS to have two RPC servers one for writable and one for protobuf (currently both protocols cannot be supported by the same RPC server, since an RPC engine is chosen as Writable or Protobuf but not both). Writing test means, having a test.proto etc. Thought I can avoid that work, since HDFS will move to protobuf and this gets tested as a part of that. If we still feel it is worth having tests, I will put in that time.
          Hide
          Todd Lipcon added a comment -

          Nice! Are you planning to add some unit tests as well?

          Show
          Todd Lipcon added a comment - Nice! Are you planning to add some unit tests as well?
          Hide
          Suresh Srinivas added a comment -

          This patch adds protobuf messages for marshaling the request, response between the RPC client and server. It also adds an RPC engine for protocol buffers.

          Show
          Suresh Srinivas added a comment - This patch adds protobuf messages for marshaling the request, response between the RPC client and server. It also adds an RPC engine for protocol buffers.

            People

            • Assignee:
              Suresh Srinivas
              Reporter:
              Suresh Srinivas
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development