Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0, 0.24.0
    • Fix Version/s: 0.23.1
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently the GlobFilter class is package private.

      As a generic filter it is quite useful (and I've found myself doing cut&paste of it a few times)

      1. HDFS-2474.patch
        1.0 kB
        Alejandro Abdelnur
      2. HDFS-2474.patch
        2 kB
        Alejandro Abdelnur
      3. HADOOP-7758.patch
        2 kB
        Alejandro Abdelnur

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #120 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/120/)
        Merge -r 1186959:1186960 from trunk to branch. FIXES: HADOOP-7758

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212080
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #120 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/120/ ) Merge -r 1186959:1186960 from trunk to branch. FIXES: HADOOP-7758 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212080 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #102 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/102/)
        Merge -r 1186959:1186960 from trunk to branch. FIXES: HADOOP-7758

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212080
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #102 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/102/ ) Merge -r 1186959:1186960 from trunk to branch. FIXES: HADOOP-7758 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212080 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #269 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/269/)
        Merge -r 1186959:1186960 from trunk to branch. FIXES: HADOOP-7758

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212080
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #269 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/269/ ) Merge -r 1186959:1186960 from trunk to branch. FIXES: HADOOP-7758 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212080 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #259 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/259/)
        Merge -r 1186959:1186960 from trunk to branch. FIXES: HADOOP-7758

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212080
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #259 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/259/ ) Merge -r 1186959:1186960 from trunk to branch. FIXES: HADOOP-7758 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212080 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #249 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/249/)
        Merge -r 1186959:1186960 from trunk to branch. FIXES: HADOOP-7758

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212080
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #249 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/249/ ) Merge -r 1186959:1186960 from trunk to branch. FIXES: HADOOP-7758 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212080 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        Hide
        Alejandro Abdelnur added a comment -

        Just committed to branch-0.23

        Show
        Alejandro Abdelnur added a comment - Just committed to branch-0.23
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #837 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/837/)
        HADOOP-7758. Make GlobFilter class public. (tucu)

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186960
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #837 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/837/ ) HADOOP-7758 . Make GlobFilter class public. (tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186960 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #867 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/867/)
        HADOOP-7758. Make GlobFilter class public. (tucu)

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186960
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #867 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/867/ ) HADOOP-7758 . Make GlobFilter class public. (tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186960 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1139 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1139/)
        HADOOP-7758. Make GlobFilter class public. (tucu)

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186960
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1139 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1139/ ) HADOOP-7758 . Make GlobFilter class public. (tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186960 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1123 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1123/)
        HADOOP-7758. Make GlobFilter class public. (tucu)

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186960
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1123 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1123/ ) HADOOP-7758 . Make GlobFilter class public. (tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186960 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1202 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1202/)
        HADOOP-7758. Make GlobFilter class public. (tucu)

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186960
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1202 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1202/ ) HADOOP-7758 . Make GlobFilter class public. (tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186960 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        Hide
        Alejandro Abdelnur added a comment -

        Committed to trunk. Shortly I'll commit it to 0.23

        Show
        Alejandro Abdelnur added a comment - Committed to trunk. Shortly I'll commit it to 0.23
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12499789/HADOOP-7758.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed the unit tests build

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/307//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/307//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/307//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12499789/HADOOP-7758.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed the unit tests build +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/307//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/307//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/307//console This message is automatically generated.
        Hide
        Alejandro Abdelnur added a comment -

        patch with comments at class level.

        Show
        Alejandro Abdelnur added a comment - patch with comments at class level.
        Hide
        Tom White added a comment -

        +1 this looks better. Add some class-level javadoc too?

        Show
        Tom White added a comment - +1 this looks better. Add some class-level javadoc too?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12499766/HDFS-2474.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed the unit tests build

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/304//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/304//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/304//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12499766/HDFS-2474.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed the unit tests build +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/304//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/304//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/304//console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1132 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1132/)
        Reverted HDFS-2474

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186501
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1132 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1132/ ) Reverted HDFS-2474 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186501 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1131 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1131/)
        HDFS-2474. Make GlobFilter class public. (tucu)

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186498
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1131 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1131/ ) HDFS-2474 . Make GlobFilter class public. (tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186498 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12499766/HDFS-2474.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1396//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12499766/HDFS-2474.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1396//console This message is automatically generated.
        Hide
        Alejandro Abdelnur added a comment -

        this time with public constructors and javadocs in the constructors.

        Show
        Alejandro Abdelnur added a comment - this time with public constructors and javadocs in the constructors.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1113 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1113/)
        Reverted HDFS-2474

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186501
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1113 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1113/ ) Reverted HDFS-2474 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186501 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1192 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1192/)
        Reverted HDFS-2474

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186501
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1192 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1192/ ) Reverted HDFS-2474 tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186501 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Alejandro Abdelnur added a comment -

        Reverted as constructors are not public, dah!!

        Show
        Alejandro Abdelnur added a comment - Reverted as constructors are not public, dah!!
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Should this belong to Common but not HDFS?

        Show
        Tsz Wo Nicholas Sze added a comment - Should this belong to Common but not HDFS?
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1112 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1112/)
        HDFS-2474. Make GlobFilter class public. (tucu)

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186498
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1112 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1112/ ) HDFS-2474 . Make GlobFilter class public. (tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186498 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1191 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1191/)
        HDFS-2474. Make GlobFilter class public. (tucu)

        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186498
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1191 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1191/ ) HDFS-2474 . Make GlobFilter class public. (tucu) tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1186498 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/GlobFilter.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Alejandro Abdelnur added a comment -

        Committed to trunk. Shortly I'll commit it to 0.23

        Show
        Alejandro Abdelnur added a comment - Committed to trunk. Shortly I'll commit it to 0.23
        Hide
        Tom White added a comment -

        +1

        Show
        Tom White added a comment - +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12499737/HDFS-2474.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1392//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12499737/HDFS-2474.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1392//console This message is automatically generated.

          People

          • Assignee:
            Alejandro Abdelnur
            Reporter:
            Alejandro Abdelnur
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development