Hadoop Common
  1. Hadoop Common
  2. HADOOP-7739

Reconcile FileUtil and SecureIOUtils APIs between 20x and trunk

    Details

    • Type: Bug Bug
    • Status: Patch Available
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 0.23.0
    • Fix Version/s: None
    • Component/s: util
    • Labels:
      None

      Description

      The 0.20.20x has introduced various public APIs to these classes which aren't in trunk. For example, FileUtil.setPermission exists in 20x but not trunk. If people start to depend on these public APIs, they will break when they upgrade.

        Activity

        Hide
        Todd Lipcon added a comment -

        FileUtil.chmod also throws InterruptedException in trunk but not in 20

        Show
        Todd Lipcon added a comment - FileUtil.chmod also throws InterruptedException in trunk but not in 20
        Hide
        Csaba Miklos added a comment -

        FileUtil.java :

        • removed InterruptedException from chmod functions.
        • setPermission function added from branch-0.20-security-205, and some required private function.

        SecureIOUtils.java :

        • Add a openForRead function without group parameter (backward compatibility with branch-0.20x)

        TestSecureIOUtils.java :

        • Add a new function to test openForRead without group.
        Show
        Csaba Miklos added a comment - FileUtil.java : removed InterruptedException from chmod functions. setPermission function added from branch-0.20-security-205, and some required private function. SecureIOUtils.java : Add a openForRead function without group parameter (backward compatibility with branch-0.20x) TestSecureIOUtils.java : Add a new function to test openForRead without group.
        Hide
        Csaba Miklos added a comment -

        Attached patch to issue.

        Show
        Csaba Miklos added a comment - Attached patch to issue.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12516944/HADOOP-7739.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/762//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12516944/HADOOP-7739.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/762//console This message is automatically generated.

          People

          • Assignee:
            Csaba Miklos
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:

              Development