Hadoop Common
  1. Hadoop Common
  2. HADOOP-7683

hdfs-site.xml template has properties that are not used in 20

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.20.205.0
    • Fix Version/s: 0.20.205.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      properties dfs.namenode.http-address and dfs.namenode.https-address should be removed

        Issue Links

          Activity

          Hide
          Arpit Gupta added a comment -

          attaching the path for 20 security branch.

          Show
          Arpit Gupta added a comment - attaching the path for 20 security branch.
          Hide
          Arpit Gupta added a comment -

          patch for only the 20s branch as trunk refers to those properties in the defaults.

          Show
          Arpit Gupta added a comment - patch for only the 20s branch as trunk refers to those properties in the defaults.
          Hide
          Eric Yang added a comment -

          +1 looks good.

          Show
          Eric Yang added a comment - +1 looks good.
          Hide
          Matt Foley added a comment -

          canceling patch, as it isn't for trunk.

          Show
          Matt Foley added a comment - canceling patch, as it isn't for trunk.
          Hide
          Matt Foley added a comment -

          Committed to 0.20-security and 0.20.205. Thanks, Arpit!

          Show
          Matt Foley added a comment - Committed to 0.20-security and 0.20.205. Thanks, Arpit!
          Hide
          Harsh J added a comment -

          Three other files have references to this property. Incorrect in just the same way, so we'll require cleanup on them as well:

          src/hdfs/org/apache/hadoop/hdfs/DFSConfigKeys.java
          src/test/org/apache/hadoop/hdfs/server/namenode/TestCheckPointForSecurityTokens.java
          src/test/org/apache/hadoop/hdfs/TestHDFSServerPorts.java

          Prop in reference is DFS_NAMENODE_HTTP_ADDRESS_KEY.

          Sorry for pitching in late, was traveling yesterday.

          Arpit - can you update these files appropriately as well? Or let me know, and I'll do it. A separate (but linked) jira is fine I think.

          Show
          Harsh J added a comment - Three other files have references to this property. Incorrect in just the same way, so we'll require cleanup on them as well: src/hdfs/org/apache/hadoop/hdfs/DFSConfigKeys.java src/test/org/apache/hadoop/hdfs/server/namenode/TestCheckPointForSecurityTokens.java src/test/org/apache/hadoop/hdfs/TestHDFSServerPorts.java Prop in reference is DFS_NAMENODE_HTTP_ADDRESS_KEY . Sorry for pitching in late, was traveling yesterday. Arpit - can you update these files appropriately as well? Or let me know, and I'll do it. A separate (but linked) jira is fine I think.
          Hide
          Harsh J added a comment -

          Ah and additionally "DFS_NAMENODE_HTTPS_ADDRESS_KEY" and "DFS_NAMENODE_BACKUP_HTTP_ADDRESS_KEY" from src/hdfs/org/apache/hadoop/hdfs/DFSConfigKeys.java again, while we're at it.

          Unsure how that backup namenode thing got pulled in. We need to remove docs away for these too, which is at https://issues.apache.org/jira/browse/HADOOP-7297 awaiting a review for removal from branch security before I commit it in.

          Show
          Harsh J added a comment - Ah and additionally "DFS_NAMENODE_HTTPS_ADDRESS_KEY" and "DFS_NAMENODE_BACKUP_HTTP_ADDRESS_KEY" from src/hdfs/org/apache/hadoop/hdfs/DFSConfigKeys.java again, while we're at it. Unsure how that backup namenode thing got pulled in. We need to remove docs away for these too, which is at https://issues.apache.org/jira/browse/HADOOP-7297 awaiting a review for removal from branch security before I commit it in.
          Hide
          Matt Foley added a comment -

          Reopening until Harsh's comments are addressed.

          Show
          Matt Foley added a comment - Reopening until Harsh's comments are addressed.
          Hide
          Arpit Gupta added a comment -

          Harsh i have linked the JIRA HADOOP-7690. Thanks for your input.

          Show
          Arpit Gupta added a comment - Harsh i have linked the JIRA HADOOP-7690 . Thanks for your input.
          Hide
          Arpit Gupta added a comment -

          Actually after some thought i dont think doing key cleanup is needed in 2xx. We logged this jira to only clean up the templates so the user is not confused when they see multiple properties having the same value.

          Show
          Arpit Gupta added a comment - Actually after some thought i dont think doing key cleanup is needed in 2xx. We logged this jira to only clean up the templates so the user is not confused when they see multiple properties having the same value.
          Hide
          Matt Foley added a comment -

          Well, it's in 205 and 0.20-security. Does it belong there or should it be reverted?

          Show
          Matt Foley added a comment - Well, it's in 205 and 0.20-security. Does it belong there or should it be reverted?
          Hide
          Arpit Gupta added a comment -

          This jira only makes changes to the config templates we should keep this in. The linked jira has been created to update the code cleanup. But like i mentioned before adding clean up of keys is something not necessary for 2xx

          Show
          Arpit Gupta added a comment - This jira only makes changes to the config templates we should keep this in. The linked jira has been created to update the code cleanup. But like i mentioned before adding clean up of keys is something not necessary for 2xx
          Hide
          Matt Foley added a comment -

          Thanks, then we'll consider this one closed and finish the rest in HADOOP-7690 in 0.20.206.

          Show
          Matt Foley added a comment - Thanks, then we'll consider this one closed and finish the rest in HADOOP-7690 in 0.20.206.
          Hide
          Matt Foley added a comment -

          Closed upon release of 0.20.205.0

          Show
          Matt Foley added a comment - Closed upon release of 0.20.205.0

            People

            • Assignee:
              Arpit Gupta
              Reporter:
              Arpit Gupta
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development