Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.205.0
    • Fix Version/s: 0.20.205.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TestKerberosName fails in 20 branch. In fact this test has got duplicated in 20, with a little change to the rules.

      1. HADOOP-7674-20s.1.patch
        17 kB
        Jitendra Nath Pandey
      2. hadoop-7674-22.patch
        17 kB
        Benoy Antony

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          5h 59m 1 Jitendra Nath Pandey 23/Sep/11 05:31
          Resolved Resolved Closed Closed
          25d 19h 54m 1 Matt Foley 19/Oct/11 01:26
          Matt Foley made changes -
          Fix Version/s 1.1.0 [ 12316501 ]
          Hide
          Matt Foley added a comment -

          20.205 was a lineal predecessor of 1.0.

          Show
          Matt Foley added a comment - 20.205 was a lineal predecessor of 1.0.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-22-branch #106 (See https://builds.apache.org/job/Hadoop-Common-22-branch/106/)
          HADOOP-7674. Fix TestKerberosName. Contributed by Jitendra Pandey and Benoy Antony. (Revision 1346225)

          Result = SUCCESS
          shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1346225
          Files :

          • /hadoop/common/branches/branch-0.22/common/CHANGES.txt
          • /hadoop/common/branches/branch-0.22/common/src/java/org/apache/hadoop/security/KerberosName.java
          • /hadoop/common/branches/branch-0.22/common/src/java/org/apache/hadoop/security/authentication/server/KerberosAuthenticationHandler.java
          • /hadoop/common/branches/branch-0.22/common/src/java/org/apache/hadoop/security/authentication/util/KerberosName.java
          • /hadoop/common/branches/branch-0.22/common/src/test/core/org/apache/hadoop/security/authentication/util/TestKerberosName.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-22-branch #106 (See https://builds.apache.org/job/Hadoop-Common-22-branch/106/ ) HADOOP-7674 . Fix TestKerberosName. Contributed by Jitendra Pandey and Benoy Antony. (Revision 1346225) Result = SUCCESS shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1346225 Files : /hadoop/common/branches/branch-0.22/common/CHANGES.txt /hadoop/common/branches/branch-0.22/common/src/java/org/apache/hadoop/security/KerberosName.java /hadoop/common/branches/branch-0.22/common/src/java/org/apache/hadoop/security/authentication/server/KerberosAuthenticationHandler.java /hadoop/common/branches/branch-0.22/common/src/java/org/apache/hadoop/security/authentication/util/KerberosName.java /hadoop/common/branches/branch-0.22/common/src/test/core/org/apache/hadoop/security/authentication/util/TestKerberosName.java
          Hide
          Konstantin Shvachko added a comment -

          I just committed this to branch 0.22.1. Thank you Benoy.

          Show
          Konstantin Shvachko added a comment - I just committed this to branch 0.22.1. Thank you Benoy.
          Benoy Antony made changes -
          Attachment hadoop-7119-022.patch [ 12526256 ]
          Benoy Antony made changes -
          Attachment hadoop-7674-22.patch [ 12528295 ]
          Hide
          Benoy Antony added a comment -

          Attaching the correct file.

          Show
          Benoy Antony added a comment - Attaching the correct file.
          Benoy Antony made changes -
          Attachment hadoop-7119-022.patch [ 12526256 ]
          Hide
          Benoy Antony added a comment -

          Patch for 22

          Show
          Benoy Antony added a comment - Patch for 22
          Benoy Antony made changes -
          Link This issue is depended upon by HADOOP-8357 [ HADOOP-8357 ]
          Matt Foley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Matt Foley added a comment -

          Closed upon release of 0.20.205.0

          Show
          Matt Foley added a comment - Closed upon release of 0.20.205.0
          Hide
          Jitendra Nath Pandey added a comment -

          This was committed to 205, 206.

          Show
          Jitendra Nath Pandey added a comment - This was committed to 205, 206.
          Jitendra Nath Pandey made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Resolution Fixed [ 1 ]
          Hide
          Suresh Srinivas added a comment -

          I too verified that KerberosName are duplicates, with the exception you mentioned. +1 for the patch.

          Show
          Suresh Srinivas added a comment - I too verified that KerberosName are duplicates, with the exception you mentioned. +1 for the patch.
          Jitendra Nath Pandey made changes -
          Field Original Value New Value
          Attachment HADOOP-7674-20s.1.patch [ 12496210 ]
          Hide
          Jitendra Nath Pandey added a comment -

          The patch removes one for each of the following duplicate files:

          KerberosName.java:
          The newer file (added in HADOOP-7119) had just one additional method, and was used at fewer places. The method is ported to the other KerberosName.java.

          TestKerberosName.java:
          The two tests have identical testcases except that two principals were using different realms. The test was failing because in 20 the default realm for tests is APACHE.ORG, while the test was passing LOCALHOST. In trunk the same test passes because in trunk default realm is parametrized.
          I removed one because fixing the above would mean to put same realm as the default one and that would make the two tests exactly identical.

          Show
          Jitendra Nath Pandey added a comment - The patch removes one for each of the following duplicate files: KerberosName.java: The newer file (added in HADOOP-7119 ) had just one additional method, and was used at fewer places. The method is ported to the other KerberosName.java. TestKerberosName.java: The two tests have identical testcases except that two principals were using different realms. The test was failing because in 20 the default realm for tests is APACHE.ORG, while the test was passing LOCALHOST. In trunk the same test passes because in trunk default realm is parametrized. I removed one because fixing the above would mean to put same realm as the default one and that would make the two tests exactly identical.
          Hide
          Jitendra Nath Pandey added a comment -

          That is correct.

          Show
          Jitendra Nath Pandey added a comment - That is correct.
          Hide
          Aaron T. Myers added a comment -

          It looks like KerberosName itself has also been duplicated on 0.20, right?

          Show
          Aaron T. Myers added a comment - It looks like KerberosName itself has also been duplicated on 0.20, right?
          Jitendra Nath Pandey created issue -

            People

            • Assignee:
              Jitendra Nath Pandey
              Reporter:
              Jitendra Nath Pandey
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development