Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-7589

Prefer mvn test -DskipTests over mvn compile in test-patch.sh

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.23.0, 0.24.0
    • 0.23.0, 0.24.0
    • build
    • None
    • Reviewed

    Description

      I got a failure running test-patch with a clean .m2 directory.

      To quote Alejandro:

      The reason for this failure is because of how Maven reactor/dependency
      resolution works (IMO a bug).

      Maven reactor/dependency resolution is smart enough to create the classpath
      using the classes from all modules being built.

      However, this smartness falls short just a bit. The dependencies are
      resolved using the deepest maven phase used by current mvn invocation. If
      you are doing 'mvn compile' you don't get to the test compile phase. This
      means that the TEST classes are not resolved from the build but from the
      cache/repo.

      The solution is to run 'mvn test -DskipTests' instead 'mvn compile'. This
      will include the TEST classes from the build.

      So this is to replace mvn compile in test-patch.sh with mvn test -DskipTests

      Attachments

        1. HADOOP-7589-V1.patch
          4 kB
          Robert Joseph Evans

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            revans2 Robert Joseph Evans
            revans2 Robert Joseph Evans
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment