Hadoop Common
  1. Hadoop Common
  2. HADOOP-7775 RPC Layer improvements to support protocol compatibility
  3. HADOOP-7524

Change RPC to allow multiple protocols including multiple versions of the same protocol

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 2.0.0-alpha
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change
    1. rpcCommitted.patch
      45 kB
      Sanjay Radia
    2. rpc8WithoutMR.patch
      42 kB
      Sanjay Radia
    3. rpc7WithoutMR.patch
      42 kB
      Sanjay Radia
    4. rpc6WithoutMR.patch
      42 kB
      Sanjay Radia
    5. rpc6.patch
      43 kB
      Sanjay Radia
    6. rpc4.txt
      40 kB
      Todd Lipcon
    7. nits.txt
      7 kB
      Todd Lipcon
    8. rpc3.patch
      41 kB
      Sanjay Radia
    9. newPatchFindbugsWarnings.html
      5 kB
      Tsz Wo Nicholas Sze
    10. rpc2_trunk.patch
      35 kB
      Tsz Wo Nicholas Sze
    11. rpc2.patch
      35 kB
      Sanjay Radia

      Issue Links

        Activity

        Hide
        Sanjay Radia added a comment -

        Attached patch allows the server to support multiple protocols including multiple versions of the same protocol.

        • Server can add additional protocols and protocolImpls to a rpc server using #RPC.addProtocol
        • Server side keeps a list of protocols and versions
        • Can add an annotation to a protocol to give its protocol name (default is the class name as before) this
          allows one to use different classes to implement different versions of the same protocol.
        • Better support for Mixins (call now contains the declaring class along with method name).
        • Inherited interfaces automatically added (this allows compatibility with old usage and also allows mixins)
        • See ipc/TestMulitpleProtocolServer for examples
        Show
        Sanjay Radia added a comment - Attached patch allows the server to support multiple protocols including multiple versions of the same protocol. Server can add additional protocols and protocolImpls to a rpc server using #RPC.addProtocol Server side keeps a list of protocols and versions Can add an annotation to a protocol to give its protocol name (default is the class name as before) this allows one to use different classes to implement different versions of the same protocol. Better support for Mixins (call now contains the declaring class along with method name). Inherited interfaces automatically added (this allows compatibility with old usage and also allows mixins) See ipc/TestMulitpleProtocolServer for examples
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Hi Sanjay, rpc2.patch patch does not apply to trunk.

        rpc2_trunk.patch: updated with trunk.

        Show
        Tsz Wo Nicholas Sze added a comment - Hi Sanjay, rpc2.patch patch does not apply to trunk. rpc2_trunk.patch: updated with trunk.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        newPatchFindbugsWarnings.html: for rpc2_trunk.patch.

        Show
        Tsz Wo Nicholas Sze added a comment - newPatchFindbugsWarnings.html: for rpc2_trunk.patch.
        Hide
        Tsz Wo Nicholas Sze added a comment -
        • Change RPC.Server.addProtocol(..) as below.
          public abstract <PROTO extends VersionedProtocol, IMPL extends PROTO>
            Server addProtocol(Class<PROTO> protocolClass, IMPL protocolImpl
            ) throws IOException;
          
        • In WritableRpcEngine.getSuperInterfaces(..),
          • check if each class is a subclass of VersionedProtocol before adding it to the list.
          • Change it to private.
        • Add final to WritableRpcEngine.writableRpcVersion.
        • Use junit4 Assert in TestMulitpleProtocolServer (i.e. org.junit.Assert instead of junit.framework.Assert)
        • Rename protocolImplSet to protocolImplMap since it is a Map.
        • Remove the first "this.declaringClassProtocolName = ..." below.
          @@ -87,7 +121,9 @@
                   }
                   this.clientMethodsHash = ProtocolSignature.getFingerprint(method
                       .getDeclaringClass().getMethods());
          +        this.declaringClassProtocolName = RPC.getProtocolName(method.getDeclaringClass());
                 }
          +      this.declaringClassProtocolName = RPC.getProtocolName(method.getDeclaringClass());
               }
          
        • VerProtocolImpl.getSupportedProtocolVersions(..) is unused.
        • Revert the (write space) change in AvroRpcEngine.
        Show
        Tsz Wo Nicholas Sze added a comment - Change RPC.Server.addProtocol(..) as below. public abstract <PROTO extends VersionedProtocol, IMPL extends PROTO> Server addProtocol( Class <PROTO> protocolClass, IMPL protocolImpl ) throws IOException; In WritableRpcEngine.getSuperInterfaces(..), check if each class is a subclass of VersionedProtocol before adding it to the list. Change it to private. Add final to WritableRpcEngine.writableRpcVersion. Use junit4 Assert in TestMulitpleProtocolServer (i.e. org.junit.Assert instead of junit.framework.Assert) Rename protocolImplSet to protocolImplMap since it is a Map. Remove the first "this.declaringClassProtocolName = ..." below. @@ -87,7 +121,9 @@ } this .clientMethodsHash = ProtocolSignature.getFingerprint(method .getDeclaringClass().getMethods()); + this .declaringClassProtocolName = RPC.getProtocolName(method.getDeclaringClass()); } + this .declaringClassProtocolName = RPC.getProtocolName(method.getDeclaringClass()); } There are two findbugs warnings in ProtoNameVer.equals(..); see the attached report . VerProtocolImpl.getSupportedProtocolVersions(..) is unused. Revert the (write space) change in AvroRpcEngine.
        Hide
        Todd Lipcon added a comment -
        • the word Multiple is misspelled in TestMulitpleProtocolServer
        • Perhaps rename ProtocolAnnotation to RPCProtocolName or maybe ProtocolInfo to be more consistent with the other annotations we use here (like KerberosInfo and TokenInfo)
        • Some typos in the javadoc of ProtocolAnnotation:
          • "The protocol name is used to when a client..."
          • "Bt default the clss"
          • Missing '.' at end of first paragraph
        • String protocolName() should be indented in the body of this annotation class
        • In the test case, maybe the different methods should return strings - eg:
          String ping() {
            return "V1 implementation";
          }
          

          so that you can assert that the correct implementation has been delegated to?

        • typo in method name: getProtocolIntefaces
        • use javadoc style comments for the descriptions of ProtoNameVer, ProtoClassProtoImpl, etc.
        • missing indentation where RPC.VersionMismatch is thrown
        • typo in javadoc: "the impl of the protocol - is is called"
        Show
        Todd Lipcon added a comment - the word Multiple is misspelled in TestMulitpleProtocolServer Perhaps rename ProtocolAnnotation to RPCProtocolName or maybe ProtocolInfo to be more consistent with the other annotations we use here (like KerberosInfo and TokenInfo) Some typos in the javadoc of ProtocolAnnotation : "The protocol name is used to when a client..." " Bt default the clss" Missing '.' at end of first paragraph String protocolName() should be indented in the body of this annotation class In the test case, maybe the different methods should return strings - eg: String ping() { return "V1 implementation" ; } so that you can assert that the correct implementation has been delegated to? typo in method name: getProtocolIntefaces use javadoc style comments for the descriptions of ProtoNameVer, ProtoClassProtoImpl, etc. missing indentation where RPC.VersionMismatch is thrown typo in javadoc: "the impl of the protocol - is is called"
        Hide
        Sanjay Radia added a comment -

        I will incorporate the feedback and post a new patch.

        Show
        Sanjay Radia added a comment - I will incorporate the feedback and post a new patch.
        Hide
        Sanjay Radia added a comment -

        Updated patch

        Show
        Sanjay Radia added a comment - Updated patch
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12490967/rpc3.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 11 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/57//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/57//artifact/trunk/target/newPatchFindbugsWarningshadoop-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/57//artifact/trunk/target/newPatchFindbugsWarningshadoop-annotations.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/57//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12490967/rpc3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/57//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/57//artifact/trunk/target/newPatchFindbugsWarningshadoop-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/57//artifact/trunk/target/newPatchFindbugsWarningshadoop-annotations.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/57//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        Hey Sanjay. Looks great. I had a few nitpicks, but rather than list them here and have to go back and forth I just formatted them as a diff. (nits.txt is just the delta, rpc4.txt is your patch with the delta applied)

        +1 w/ the nits fixed.

        Show
        Todd Lipcon added a comment - Hey Sanjay. Looks great. I had a few nitpicks, but rather than list them here and have to go back and forth I just formatted them as a diff. (nits.txt is just the delta, rpc4.txt is your patch with the delta applied) +1 w/ the nits fixed.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12491011/rpc4.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 11 new or modified tests.

        -1 javadoc. The javadoc tool appears to have generated 3 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/59//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/59//artifact/trunk/target/newPatchFindbugsWarningshadoop-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/59//artifact/trunk/target/newPatchFindbugsWarningshadoop-hdfs.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/59//artifact/trunk/target/newPatchFindbugsWarningshadoop-annotations.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/59//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12491011/rpc4.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 3 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/59//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/59//artifact/trunk/target/newPatchFindbugsWarningshadoop-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/59//artifact/trunk/target/newPatchFindbugsWarningshadoop-hdfs.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/59//artifact/trunk/target/newPatchFindbugsWarningshadoop-annotations.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/59//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        hm, something strange went on with this test-patch build. I kicked it to go again, Tom and I are looking at it.

        Show
        Todd Lipcon added a comment - hm, something strange went on with this test-patch build. I kicked it to go again, Tom and I are looking at it.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Todd, your changes looked good to me but there were javadoc warnings. Could you take a look?

        Show
        Tsz Wo Nicholas Sze added a comment - Todd, your changes looked good to me but there were javadoc warnings. Could you take a look?
        Hide
        Todd Lipcon added a comment -

        Something strange is going on with the QA bot, if you look at the Console output above. I tried to kick another build manually, but it doesn't seem to have posted results here. When I try to load the Hudson web page at the moment, it's just hanging. I will try to look into it tomorrow.

        Show
        Todd Lipcon added a comment - Something strange is going on with the QA bot, if you look at the Console output above. I tried to kick another build manually, but it doesn't seem to have posted results here. When I try to load the Hudson web page at the moment, it's just hanging. I will try to look into it tomorrow.
        Hide
        Todd Lipcon added a comment -

        I tried running HDFS trunk when this patch is applied to common, and it fails with the following:

        java.io.IOException: Unknown protocol to name node: org.apache.hadoop.hdfs.server.protocol.NamenodeProtocols
        at org.apache.hadoop.hdfs.server.namenode.NameNode.getProtocolVersion(NameNode.java:196)
        at org.apache.hadoop.ipc.WritableRpcEngine$Server.registerProtocolAndImpl(WritableRpcEngine.java:387)
        at org.apache.hadoop.ipc.WritableRpcEngine$Server.<init>(WritableRpcEngine.java:544)
        at org.apache.hadoop.ipc.WritableRpcEngine.getServer(WritableRpcEngine.java:329)
        at org.apache.hadoop.ipc.RPC.getServer(RPC.java:565)
        at org.apache.hadoop.hdfs.server.namenode.NameNode.initialize(NameNode.java:431)

        so I think we need a corresponding patch for HDFS and MR, or we need a workaround on the Common side.

        Show
        Todd Lipcon added a comment - I tried running HDFS trunk when this patch is applied to common, and it fails with the following: java.io.IOException: Unknown protocol to name node: org.apache.hadoop.hdfs.server.protocol.NamenodeProtocols at org.apache.hadoop.hdfs.server.namenode.NameNode.getProtocolVersion(NameNode.java:196) at org.apache.hadoop.ipc.WritableRpcEngine$Server.registerProtocolAndImpl(WritableRpcEngine.java:387) at org.apache.hadoop.ipc.WritableRpcEngine$Server.<init>(WritableRpcEngine.java:544) at org.apache.hadoop.ipc.WritableRpcEngine.getServer(WritableRpcEngine.java:329) at org.apache.hadoop.ipc.RPC.getServer(RPC.java:565) at org.apache.hadoop.hdfs.server.namenode.NameNode.initialize(NameNode.java:431) so I think we need a corresponding patch for HDFS and MR, or we need a workaround on the Common side.
        Hide
        Sanjay Radia added a comment -

        I have the fix for the above. However I another test fails in HDFS that I am investigating - it appears unrelated.

        Show
        Sanjay Radia added a comment - I have the fix for the above. However I another test fails in HDFS that I am investigating - it appears unrelated.
        Hide
        Sanjay Radia added a comment -

        Updated patch:

        • Incorporates Todd's nits
        • Fixes the HDFS test failure - added code to ignore protocol interfaces that throw exception on getProtocolVersion() as does NamenodeProotocol.
        • Minor fixes to make MR2's rpc work.
        Show
        Sanjay Radia added a comment - Updated patch: Incorporates Todd's nits Fixes the HDFS test failure - added code to ignore protocol interfaces that throw exception on getProtocolVersion() as does NamenodeProotocol. Minor fixes to make MR2's rpc work.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12491749/rpc6.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 11 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/88//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12491749/rpc6.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/88//console This message is automatically generated.
        Hide
        Sanjay Radia added a comment -

        rpc6WithoutMR.path removes the MR related changes which need to be submitted as a MR jira.

        Show
        Sanjay Radia added a comment - rpc6WithoutMR.path removes the MR related changes which need to be submitted as a MR jira.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12491839/rpc6WithoutMR.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 11 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/90//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/90//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-auth.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/90//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/90//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-annotations.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/90//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12491839/rpc6WithoutMR.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/90//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/90//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-auth.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/90//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/90//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-annotations.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/90//console This message is automatically generated.
        Hide
        Sanjay Radia added a comment -

        New patch: Minor improvements to logging.

        Show
        Sanjay Radia added a comment - New patch: Minor improvements to logging.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12492168/rpc7WithoutMR.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 11 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The applied patch generated 1048 javac compiler warnings (more than the trunk's current 1047 warnings).

        -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/98//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/98//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-auth.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/98//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/98//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-annotations.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/98//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12492168/rpc7WithoutMR.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 1048 javac compiler warnings (more than the trunk's current 1047 warnings). -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/98//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/98//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-auth.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/98//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/98//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-annotations.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/98//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12492424/rpc8WithoutMR.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 11 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/109//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/109//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-auth.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/109//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/109//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-annotations.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/109//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12492424/rpc8WithoutMR.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/109//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/109//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-auth.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/109//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/109//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-annotations.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/109//console This message is automatically generated.
        Hide
        Sanjay Radia added a comment -

        Committed the patch (together with MapReduce-2887)

        Show
        Sanjay Radia added a comment - Committed the patch (together with MapReduce-2887)
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #825 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/825/)
        HADOOP-7524 and MapReduce-2887 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia)

        sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1164771
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtocolInfo.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/VersionedProtocol.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPCServerResponder.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestInterDatanodeProtocol.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/ipc/ProtoOverHadoopRpcEngine.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/src/java/org/apache/hadoop/mapred/JobTracker.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #825 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/825/ ) HADOOP-7524 and MapReduce-2887 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia) sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1164771 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtocolInfo.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/VersionedProtocol.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPCServerResponder.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestInterDatanodeProtocol.java /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/ipc/ProtoOverHadoopRpcEngine.java /hadoop/common/trunk/hadoop-mapreduce-project/src/java/org/apache/hadoop/mapred/JobTracker.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #902 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/902/)
        HADOOP-7524 and MapReduce-2887 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia)

        sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1164771
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtocolInfo.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/VersionedProtocol.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPCServerResponder.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestInterDatanodeProtocol.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/ipc/ProtoOverHadoopRpcEngine.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/src/java/org/apache/hadoop/mapred/JobTracker.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #902 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/902/ ) HADOOP-7524 and MapReduce-2887 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia) sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1164771 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtocolInfo.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/VersionedProtocol.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPCServerResponder.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestInterDatanodeProtocol.java /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/ipc/ProtoOverHadoopRpcEngine.java /hadoop/common/trunk/hadoop-mapreduce-project/src/java/org/apache/hadoop/mapred/JobTracker.java
        Hide
        Sanjay Radia added a comment -

        writableRpcVersion has changed.

        Show
        Sanjay Radia added a comment - writableRpcVersion has changed.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #835 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/835/)
        HADOOP-7524 and MapReduce-2887 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia)

        sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1164771
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtocolInfo.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/VersionedProtocol.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPCServerResponder.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestInterDatanodeProtocol.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/ipc/ProtoOverHadoopRpcEngine.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/src/java/org/apache/hadoop/mapred/JobTracker.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #835 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/835/ ) HADOOP-7524 and MapReduce-2887 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia) sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1164771 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtocolInfo.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/VersionedProtocol.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPCServerResponder.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestInterDatanodeProtocol.java /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/ipc/ProtoOverHadoopRpcEngine.java /hadoop/common/trunk/hadoop-mapreduce-project/src/java/org/apache/hadoop/mapred/JobTracker.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #781 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/781/)
        HADOOP-7524 and MapReduce-2887 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia)

        sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1164771
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtocolInfo.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/VersionedProtocol.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPCServerResponder.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestInterDatanodeProtocol.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/ipc/ProtoOverHadoopRpcEngine.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/src/java/org/apache/hadoop/mapred/JobTracker.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #781 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/781/ ) HADOOP-7524 and MapReduce-2887 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia) sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1164771 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtocolInfo.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/VersionedProtocol.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPCServerResponder.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestInterDatanodeProtocol.java /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/ipc/ProtoOverHadoopRpcEngine.java /hadoop/common/trunk/hadoop-mapreduce-project/src/java/org/apache/hadoop/mapred/JobTracker.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #805 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/805/)
        HADOOP-7524 and MapReduce-2887 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia)

        sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1164771
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtocolInfo.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/VersionedProtocol.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPCServerResponder.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestInterDatanodeProtocol.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/ipc/ProtoOverHadoopRpcEngine.java
        • /hadoop/common/trunk/hadoop-mapreduce-project/src/java/org/apache/hadoop/mapred/JobTracker.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #805 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/805/ ) HADOOP-7524 and MapReduce-2887 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia) sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1164771 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtocolInfo.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/VersionedProtocol.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPC.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestIPCServerResponder.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestMultipleProtocolServer.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestInterDatanodeProtocol.java /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/ipc/ProtoOverHadoopRpcEngine.java /hadoop/common/trunk/hadoop-mapreduce-project/src/java/org/apache/hadoop/mapred/JobTracker.java
        Hide
        Todd Lipcon added a comment -

        Marking as 0.24 since it was only committed to that branch.

        Show
        Todd Lipcon added a comment - Marking as 0.24 since it was only committed to that branch.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #842 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/842/)
        HDFS-2310. TestBackupNode fails since HADOOP-7524 went in. Contributed by Ivan Kelly.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165461
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #842 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/842/ ) HDFS-2310 . TestBackupNode fails since HADOOP-7524 went in. Contributed by Ivan Kelly. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165461 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #909 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/909/)
        HDFS-2310. TestBackupNode fails since HADOOP-7524 went in. Contributed by Ivan Kelly.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165461
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #909 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/909/ ) HDFS-2310 . TestBackupNode fails since HADOOP-7524 went in. Contributed by Ivan Kelly. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165461 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #785 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/785/)
        HDFS-2310. TestBackupNode fails since HADOOP-7524 went in. Contributed by Ivan Kelly.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165461
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #785 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/785/ ) HDFS-2310 . TestBackupNode fails since HADOOP-7524 went in. Contributed by Ivan Kelly. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165461 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #808 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/808/)
        HDFS-2310. TestBackupNode fails since HADOOP-7524 went in. Contributed by Ivan Kelly.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165461
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #808 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/808/ ) HDFS-2310 . TestBackupNode fails since HADOOP-7524 went in. Contributed by Ivan Kelly. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1165461 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        Hide
        Vinod Kumar Vavilapalli added a comment -

        This patch has broken a test in MapReduce. Please see MAPREDUCE-2942. You can see the test failure at https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/622/testReport/.

        I do see this as marked as an incompatible change. If this cannot really be done in a backwards compatible way, I think we should remove those APIs which are marked deprecated, for e.g {{Server getServer(final Object instance, final String bindAddress, final int port, Configuration conf) }}, which won't work at all.

        Show
        Vinod Kumar Vavilapalli added a comment - This patch has broken a test in MapReduce. Please see MAPREDUCE-2942 . You can see the test failure at https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/622/testReport/ . I do see this as marked as an incompatible change. If this cannot really be done in a backwards compatible way, I think we should remove those APIs which are marked deprecated, for e.g {{Server getServer(final Object instance, final String bindAddress, final int port, Configuration conf) }}, which won't work at all.
        Hide
        Sanjay Radia added a comment -

        It is incompatible only wrt to wire protocol, public APIs apis are compatible.

        Show
        Sanjay Radia added a comment - It is incompatible only wrt to wire protocol, public APIs apis are compatible.
        Hide
        Sanjay Radia added a comment -

        we should backport this to 0.23

        Show
        Sanjay Radia added a comment - we should backport this to 0.23
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #927 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/927/)
        HADOOP-7524 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia)

        sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173488
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #927 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/927/ ) HADOOP-7524 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia) sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173488 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1005 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1005/)
        HADOOP-7524 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia)

        sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173488
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1005 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1005/ ) HADOOP-7524 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia) sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173488 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #944 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/944/)
        HADOOP-7524 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia)

        sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173488
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #944 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/944/ ) HADOOP-7524 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia) sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173488 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #837 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/837/)
        HADOOP-7524 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia)

        sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173488
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #837 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/837/ ) HADOOP-7524 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia) sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173488 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #807 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/807/)
        HADOOP-7524 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia)

        sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173488
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #807 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/807/ ) HADOOP-7524 Change RPC to allow multiple protocols including multuple versions of the same protocol (sanjay Radia) sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1173488 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
        Hide
        Doug Cutting added a comment -

        Sanjay, do you intend this to go into 0.23? I think perhaps it should.

        If it is going into 0.23, then HADOOP-7693 should also go in, since it fixes AvroRpcEngine. Also, if these two go in, then a considerably simpler fix is possible for HDFS-2298, renaming fewer methods.

        If this does not go into 0.23 then I think we should still merge the simpler fix for HDFS-2298, to keep RPC method names consistent across releases, but disable TestDfsOverAvroRpc in 0.23, since the simpler fix won't work without this and HADOOP-7693.

        What do you prefer?

        Show
        Doug Cutting added a comment - Sanjay, do you intend this to go into 0.23? I think perhaps it should. If it is going into 0.23, then HADOOP-7693 should also go in, since it fixes AvroRpcEngine. Also, if these two go in, then a considerably simpler fix is possible for HDFS-2298 , renaming fewer methods. If this does not go into 0.23 then I think we should still merge the simpler fix for HDFS-2298 , to keep RPC method names consistent across releases, but disable TestDfsOverAvroRpc in 0.23, since the simpler fix won't work without this and HADOOP-7693 . What do you prefer?
        Hide
        Sanjay Radia added a comment -

        Yes I am intending this to do into 23. Agree about HADOOP-7693.
        I was waiting for HDFS-2181; but strictly speaking I don't need to wait for that.

        Is the patch that was committed for HDFS-2298 the simpler one you talk about?

        Show
        Sanjay Radia added a comment - Yes I am intending this to do into 23. Agree about HADOOP-7693 . I was waiting for HDFS-2181 ; but strictly speaking I don't need to wait for that. Is the patch that was committed for HDFS-2298 the simpler one you talk about?
        Hide
        Doug Cutting added a comment -

        > Is the patch that was committed for HDFS-2298 the simpler one you talk about?

        Yes.

        Show
        Doug Cutting added a comment - > Is the patch that was committed for HDFS-2298 the simpler one you talk about? Yes.
        Hide
        Todd Lipcon added a comment -

        Sanjay, are you still working on merging this to 0.23? Still intending that it should be merged?

        Show
        Todd Lipcon added a comment - Sanjay, are you still working on merging this to 0.23? Still intending that it should be merged?
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have merged this to 0.23.

        Show
        Tsz Wo Nicholas Sze added a comment - I have merged this to 0.23.

          People

          • Assignee:
            Sanjay Radia
            Reporter:
            Sanjay Radia
          • Votes:
            0 Vote for this issue
            Watchers:
            13 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development