Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HADOOP-7515.patch
      8 kB
      Tom White
    2. HADOOP-7515.patch
      9 kB
      Tom White

      Activity

      Hide
      Tom White added a comment -

      This patch fixes the triple counting issue. It also changes back the expected number to 6.

      It also makes MAVEN_HOME optional, fixes the problem where the tests were mistakenly being run, and makes a few other minor changes.

      To test it, comment out line 677 ("checkout") to avoid it halting due to a modified workspace.

      Show
      Tom White added a comment - This patch fixes the triple counting issue. It also changes back the expected number to 6. It also makes MAVEN_HOME optional, fixes the problem where the tests were mistakenly being run, and makes a few other minor changes. To test it, comment out line 677 ("checkout") to avoid it halting due to a modified workspace.
      Hide
      Todd Lipcon added a comment -

      for assigning PS, how about PS=$

      {PS:-ps}

      so that someone can override it? I assume it was made an environment because some operating systems might put the gnu ps elsewhere. Maybe do the same for awk?

      I'll give this a try to see if it fixes my test-patch issue

      Show
      Todd Lipcon added a comment - for assigning PS, how about PS=$ {PS:-ps} so that someone can override it? I assume it was made an environment because some operating systems might put the gnu ps elsewhere. Maybe do the same for awk? I'll give this a try to see if it fixes my test-patch issue
      Hide
      Todd Lipcon added a comment -

      javadoc and javac seem OK with your patch

      Show
      Todd Lipcon added a comment - javadoc and javac seem OK with your patch
      Hide
      Todd Lipcon added a comment -

      oh, that's +1 if it wasn't clear

      Show
      Todd Lipcon added a comment - oh, that's +1 if it wasn't clear
      Hide
      Tom White added a comment -

      Updated patch with Todd's suggestions.

      Show
      Tom White added a comment - Updated patch with Todd's suggestions.
      Hide
      Tom White added a comment -

      I've just committed this.

      Show
      Tom White added a comment - I've just committed this.
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Common-trunk-Commit #705 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/705/)
      HADOOP-7515. test-patch reports the wrong number of javadoc warnings.

      tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1154240
      Files :

      • /hadoop/common/trunk/hadoop-common/CHANGES.txt
      • /hadoop/common/trunk/dev-support/test-patch.properties
      • /hadoop/common/trunk/dev-support/test-patch.sh
      Show
      Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #705 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/705/ ) HADOOP-7515 . test-patch reports the wrong number of javadoc warnings. tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1154240 Files : /hadoop/common/trunk/hadoop-common/CHANGES.txt /hadoop/common/trunk/dev-support/test-patch.properties /hadoop/common/trunk/dev-support/test-patch.sh
      Hide
      Matt Foley added a comment -

      Note above merge commit #1176646 is actually for HADOOP-7510, but the committer typo'ed the jira id.

      Show
      Matt Foley added a comment - Note above merge commit #1176646 is actually for HADOOP-7510 , but the committer typo'ed the jira id.

        People

        • Assignee:
          Tom White
          Reporter:
          Tom White
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development