Hadoop Common
  1. Hadoop Common
  2. HADOOP-7504

hadoop-metrics.properties missing some Ganglia31 options

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.20.203.0, 0.23.0
    • Fix Version/s: 0.23.1
    • Component/s: metrics
    • Labels:

      Description

      The "jvm", "rpc", and "ugi" sections of hadoop-metrics.properties should have Ganglia31 options like "dfs" and "mapred"

        Activity

        Hide
        Harsh J added a comment -

        Patch for trunk that adds this.

        Show
        Harsh J added a comment - Patch for trunk that adds this.
        Hide
        Harsh J added a comment -

        Marking as PA.

        • No tests cause this is mere commented classnames addition akin to comments already present.

        That said, Ganglia31 metrics work for these other metrics in just the same way.

        Show
        Harsh J added a comment - Marking as PA. No tests cause this is mere commented classnames addition akin to comments already present. That said, Ganglia31 metrics work for these other metrics in just the same way.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12493015/HADOOP-7504.r1.diff
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/134//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/134//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-auth-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/134//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/134//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-annotations.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/134//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-auth.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/134//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12493015/HADOOP-7504.r1.diff against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/134//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/134//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-auth-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/134//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/134//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/134//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-auth.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/134//console This message is automatically generated.
        Hide
        Harsh J added a comment -

        Targeting branch-0.1

        Show
        Harsh J added a comment - Targeting branch-0.1
        Hide
        Harsh J added a comment -

        Correcting target versions.

        Show
        Harsh J added a comment - Correcting target versions.
        Hide
        Harsh J added a comment -

        Given that this is a trivial change of adding comments to a template file, I shall commit it in a couple of days unless there are objections.

        Show
        Harsh J added a comment - Given that this is a trivial change of adding comments to a template file, I shall commit it in a couple of days unless there are objections.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1557 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1557/)
        HADOOP-7504. Add the missing Ganglia31 opts to hadoop-metrics.properties as a comment. (harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226351
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics.properties
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1557 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1557/ ) HADOOP-7504 . Add the missing Ganglia31 opts to hadoop-metrics.properties as a comment. (harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226351 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics.properties
        Hide
        Harsh J added a comment -

        Since this was trivial and was open for a long-enough time (and adds only comments of classes that do exist even today), I went ahead and committed to branch-0.23 and trunk.

        Show
        Harsh J added a comment - Since this was trivial and was open for a long-enough time (and adds only comments of classes that do exist even today), I went ahead and committed to branch-0.23 and trunk.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1485 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1485/)
        HADOOP-7504. Add the missing Ganglia31 opts to hadoop-metrics.properties as a comment. (harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226351
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics.properties
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1485 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1485/ ) HADOOP-7504 . Add the missing Ganglia31 opts to hadoop-metrics.properties as a comment. (harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226351 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics.properties
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #319 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/319/)
        merge HADOOP-7504 (harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226352
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics.properties
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #319 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/319/ ) merge HADOOP-7504 (harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226352 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics.properties
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #330 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/330/)
        merge HADOOP-7504 (harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226352
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics.properties
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #330 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/330/ ) merge HADOOP-7504 (harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226352 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics.properties
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1506 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1506/)
        HADOOP-7504. Add the missing Ganglia31 opts to hadoop-metrics.properties as a comment. (harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226351
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics.properties
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1506 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1506/ ) HADOOP-7504 . Add the missing Ganglia31 opts to hadoop-metrics.properties as a comment. (harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226351 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics.properties
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #341 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/341/)
        merge HADOOP-7504 (harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226352
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics.properties
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #341 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/341/ ) merge HADOOP-7504 (harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226352 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics.properties
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #913 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/913/)
        HADOOP-7504. Add the missing Ganglia31 opts to hadoop-metrics.properties as a comment. (harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226351
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics.properties
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #913 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/913/ ) HADOOP-7504 . Add the missing Ganglia31 opts to hadoop-metrics.properties as a comment. (harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226351 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics.properties
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #126 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/126/)
        merge HADOOP-7504 (harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226352
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics.properties
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #126 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/126/ ) merge HADOOP-7504 (harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226352 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics.properties
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #148 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/148/)
        merge HADOOP-7504 (harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226352
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics.properties
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #148 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/148/ ) merge HADOOP-7504 (harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226352 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics.properties
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #946 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/946/)
        HADOOP-7504. Add the missing Ganglia31 opts to hadoop-metrics.properties as a comment. (harsh)

        harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226351
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics.properties
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #946 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/946/ ) HADOOP-7504 . Add the missing Ganglia31 opts to hadoop-metrics.properties as a comment. (harsh) harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1226351 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-metrics.properties

          People

          • Assignee:
            Harsh J
            Reporter:
            Eli Collins
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development