Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-7471

the saveVersion.sh script sometimes fails to extract SVN URL

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When using an SVN checkout of the source, sometime the svn info command outputs a 'Copied from URL: ###' line in addition to the 'URL: ###'.

      This breaks the saveVersion.sh script that assume there is only one line in the output of svn info that contains the word URL.

      1. HADOOP-7471.patch
        0.6 kB
        Alejandro Abdelnur

        Activity

        Hide
        tucu00 Alejandro Abdelnur added a comment -

        The script should check for '^URL' to handle this case.

        Show
        tucu00 Alejandro Abdelnur added a comment - The script should check for '^URL' to handle this case.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12486884/HADOOP-7471.patch
        against trunk revision 1147952.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/742//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/742//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/742//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12486884/HADOOP-7471.patch against trunk revision 1147952. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/742//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/742//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/742//console This message is automatically generated.
        Hide
        eli Eli Collins added a comment -

        +1

        Show
        eli Eli Collins added a comment - +1
        Hide
        eli Eli Collins added a comment -

        I've committed this.

        Show
        eli Eli Collins added a comment - I've committed this.
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #694 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/694/)
        HADOOP-7471. The saveVersion.sh script sometimes fails to extract SVN URL. Contributed by Alejandro Abdelnur

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147967
        Files :

        • /hadoop/common/trunk/common/src/saveVersion.sh
        • /hadoop/common/trunk/common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #694 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/694/ ) HADOOP-7471 . The saveVersion.sh script sometimes fails to extract SVN URL. Contributed by Alejandro Abdelnur eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147967 Files : /hadoop/common/trunk/common/src/saveVersion.sh /hadoop/common/trunk/common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Common-trunk #751 (See https://builds.apache.org/job/Hadoop-Common-trunk/751/)
        HADOOP-7471. The saveVersion.sh script sometimes fails to extract SVN URL. Contributed by Alejandro Abdelnur

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147967
        Files :

        • /hadoop/common/trunk/common/src/saveVersion.sh
        • /hadoop/common/trunk/common/CHANGES.txt
        Show
        hudson Hudson added a comment - Integrated in Hadoop-Common-trunk #751 (See https://builds.apache.org/job/Hadoop-Common-trunk/751/ ) HADOOP-7471 . The saveVersion.sh script sometimes fails to extract SVN URL. Contributed by Alejandro Abdelnur eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1147967 Files : /hadoop/common/trunk/common/src/saveVersion.sh /hadoop/common/trunk/common/CHANGES.txt

          People

          • Assignee:
            tucu00 Alejandro Abdelnur
            Reporter:
            tucu00 Alejandro Abdelnur
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development