Hadoop Common
  1. Hadoop Common
  2. HADOOP-7449

merge for MR-279: add Data(In,Out)putByteBuffer to work with ByteBuffer similar to Data(In,Out)putBuffer for byte[]

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None

      Description

      Fix incomplete merge from yahoo-merge branch to trunk:
      -r 1079163: Added Data(In,Out)putByteBuffer to work with ByteBuffer similar to Data(In,Out)putBuffer for byte[]. (Chris Douglas)

        Activity

        Hide
        Matt Foley added a comment -

        Already subject to review during merge of yahoo-merge branch, and no changes needed for clean merge.

        Committed to trunk.

        Show
        Matt Foley added a comment - Already subject to review during merge of yahoo-merge branch, and no changes needed for clean merge. Committed to trunk.
        Hide
        Matt Foley added a comment -

        Merged as -r 1143606 in trunk.
        Unfortunately forgot to include this bug number in the commit message, and can't edit after the fact.

        Show
        Matt Foley added a comment - Merged as -r 1143606 in trunk. Unfortunately forgot to include this bug number in the commit message, and can't edit after the fact.
        Hide
        Matt Foley added a comment -

        The three files being merged,

        • src/java/org/apache/hadoop/io/DataInputByteBuffer.java
        • src/java/org/apache/hadoop/io/DataOutputByteBuffer.java
        • src/test/core/org/apache/hadoop/io/TestDataByteBuffers.java
          turn out to lack the Apache license header, picked up by release audit on a different patch.

        The next submission is a patch to correct this, and insure that the findbugs and javadocs tools are also run over these three files.

        Show
        Matt Foley added a comment - The three files being merged, src/java/org/apache/hadoop/io/DataInputByteBuffer.java src/java/org/apache/hadoop/io/DataOutputByteBuffer.java src/test/core/org/apache/hadoop/io/TestDataByteBuffers.java turn out to lack the Apache license header, picked up by release audit on a different patch. The next submission is a patch to correct this, and insure that the findbugs and javadocs tools are also run over these three files.
        Hide
        Jitendra Nath Pandey added a comment -

        +1.

        Show
        Jitendra Nath Pandey added a comment - +1.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12485520/DataByteBuffer_fix.patch
        against trunk revision 1143624.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/707//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/707//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/707//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12485520/DataByteBuffer_fix.patch against trunk revision 1143624. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/707//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/707//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/707//console This message is automatically generated.
        Hide
        Matt Foley added a comment -

        Committed to trunk, with correct Jira reference this time.

        Show
        Matt Foley added a comment - Committed to trunk, with correct Jira reference this time.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #680 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/680/)
        HADOOP-7449. Add Data(In,Out)putByteBuffer to work with ByteBuffer similar to Data(In,Out)putBuffer for byte[]. Merge from yahoo-merge branch, -r 1079163. Fix missing Apache license headers. Contributed by Chris Douglas.

        mattf : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1143681
        Files :

        • /hadoop/common/trunk/common/CHANGES.txt
        • /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/io/TestDataByteBuffers.java
        • /hadoop/common/trunk/common/src/java/org/apache/hadoop/io/DataOutputByteBuffer.java
        • /hadoop/common/trunk/common/src/java/org/apache/hadoop/io/DataInputByteBuffer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #680 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/680/ ) HADOOP-7449 . Add Data(In,Out)putByteBuffer to work with ByteBuffer similar to Data(In,Out)putBuffer for byte[]. Merge from yahoo-merge branch, -r 1079163. Fix missing Apache license headers. Contributed by Chris Douglas. mattf : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1143681 Files : /hadoop/common/trunk/common/CHANGES.txt /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/io/TestDataByteBuffers.java /hadoop/common/trunk/common/src/java/org/apache/hadoop/io/DataOutputByteBuffer.java /hadoop/common/trunk/common/src/java/org/apache/hadoop/io/DataInputByteBuffer.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #740 (See https://builds.apache.org/job/Hadoop-Common-trunk/740/)
        HADOOP-7449. Add Data(In,Out)putByteBuffer to work with ByteBuffer similar to Data(In,Out)putBuffer for byte[]. Merge from yahoo-merge branch, -r 1079163. Fix missing Apache license headers. Contributed by Chris Douglas.

        mattf : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1143681
        Files :

        • /hadoop/common/trunk/common/CHANGES.txt
        • /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/io/TestDataByteBuffers.java
        • /hadoop/common/trunk/common/src/java/org/apache/hadoop/io/DataOutputByteBuffer.java
        • /hadoop/common/trunk/common/src/java/org/apache/hadoop/io/DataInputByteBuffer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #740 (See https://builds.apache.org/job/Hadoop-Common-trunk/740/ ) HADOOP-7449 . Add Data(In,Out)putByteBuffer to work with ByteBuffer similar to Data(In,Out)putBuffer for byte[]. Merge from yahoo-merge branch, -r 1079163. Fix missing Apache license headers. Contributed by Chris Douglas. mattf : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1143681 Files : /hadoop/common/trunk/common/CHANGES.txt /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/io/TestDataByteBuffers.java /hadoop/common/trunk/common/src/java/org/apache/hadoop/io/DataOutputByteBuffer.java /hadoop/common/trunk/common/src/java/org/apache/hadoop/io/DataInputByteBuffer.java

          People

          • Assignee:
            Matt Foley
            Reporter:
            Matt Foley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development