Hadoop Common
  1. Hadoop Common
  2. HADOOP-7428

IPC connection is orphaned with null 'out' member

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We had a situation a JT ended up in a state where a certain user could not submit a job, due to an NPE on the following line in sendParam:

      synchronized (Connection.this.out) {
      

      Looking at the code, my guess is that an RTE was thrown in setupIOstreams, which only catches IOE. This could leave the connection in a half-setup state which is never cleaned up and also cannot perform IPCs.

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #734 (See https://builds.apache.org/job/Hadoop-Common-trunk/734/)
        HADOOP-7428. IPC connection is orphaned with null 'out' member. Contributed by Todd Lipcon

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1141638
        Files :

        • /hadoop/common/trunk/common/CHANGES.txt
        • /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/ipc/TestIPC.java
        • /hadoop/common/trunk/common/src/java/org/apache/hadoop/ipc/Client.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #734 (See https://builds.apache.org/job/Hadoop-Common-trunk/734/ ) HADOOP-7428 . IPC connection is orphaned with null 'out' member. Contributed by Todd Lipcon eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1141638 Files : /hadoop/common/trunk/common/CHANGES.txt /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/ipc/TestIPC.java /hadoop/common/trunk/common/src/java/org/apache/hadoop/ipc/Client.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-maven #45 (See https://builds.apache.org/job/Hadoop-Common-trunk-maven/45/)
        HADOOP-7428. IPC connection is orphaned with null 'out' member. Contributed by Todd Lipcon

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1141638
        Files :

        • /hadoop/common/trunk/common/CHANGES.txt
        • /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/ipc/TestIPC.java
        • /hadoop/common/trunk/common/src/java/org/apache/hadoop/ipc/Client.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-maven #45 (See https://builds.apache.org/job/Hadoop-Common-trunk-maven/45/ ) HADOOP-7428 . IPC connection is orphaned with null 'out' member. Contributed by Todd Lipcon eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1141638 Files : /hadoop/common/trunk/common/CHANGES.txt /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/ipc/TestIPC.java /hadoop/common/trunk/common/src/java/org/apache/hadoop/ipc/Client.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #669 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/669/)
        HADOOP-7428. IPC connection is orphaned with null 'out' member. Contributed by Todd Lipcon

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1141638
        Files :

        • /hadoop/common/trunk/common/CHANGES.txt
        • /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/ipc/TestIPC.java
        • /hadoop/common/trunk/common/src/java/org/apache/hadoop/ipc/Client.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #669 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/669/ ) HADOOP-7428 . IPC connection is orphaned with null 'out' member. Contributed by Todd Lipcon eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1141638 Files : /hadoop/common/trunk/common/CHANGES.txt /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/ipc/TestIPC.java /hadoop/common/trunk/common/src/java/org/apache/hadoop/ipc/Client.java
        Hide
        Eli Collins added a comment -

        I've committed this. Thanks Todd!

        Show
        Eli Collins added a comment - I've committed this. Thanks Todd!
        Hide
        Eli Collins added a comment -

        +1 good catch.

        Show
        Eli Collins added a comment - +1 good catch.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12484478/hadoop-7428.txt
        against trunk revision 1140442.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/681//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/681//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/681//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12484478/hadoop-7428.txt against trunk revision 1140442. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/681//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/681//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/681//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        Here's a patch which demonstrates the issue. The unit test is a little bit contrived, but does demonstrate the issue and act as a regression test.

        Show
        Todd Lipcon added a comment - Here's a patch which demonstrates the issue. The unit test is a little bit contrived, but does demonstrate the issue and act as a regression test.

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development