Hadoop Common
  1. Hadoop Common
  2. HADOOP-7419

new hadoop-config.sh doesn't manage classpath for HADOOP_CONF_DIR correctly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      Since the introduction of the RPM packages, hadoop-config.sh incorrectly puts $HADOOP_HDFS_HOME/conf on the classpath regardless of whether HADOOP_CONF_DIR is already defined in the environment.

      1. HDFS-2089.txt
        0.5 kB
        Bing Zheng
      2. HDFS-2089.txt
        0.5 kB
        Aaron T. Myers
      3. hadoop-7419.txt
        0.9 kB
        Todd Lipcon

        Activity

        Todd Lipcon created issue -
        E. Sammer made changes -
        Field Original Value New Value
        Labels newbie
        Bing Zheng made changes -
        Assignee Bing Zheng [ bzheng ]
        Hide
        Bing Zheng added a comment -

        only set $HADOOP_HDFS_HOME/conf to classpath if HADOOP_CONF_DIR is not set or empty

        Show
        Bing Zheng added a comment - only set $HADOOP_HDFS_HOME/conf to classpath if HADOOP_CONF_DIR is not set or empty
        Bing Zheng made changes -
        Attachment HDFS-2089.txt [ 12483513 ]
        Bing Zheng made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12483513/HDFS-2089.txt
        against trunk revision 1138645.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/820//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483513/HDFS-2089.txt against trunk revision 1138645. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/820//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        Hmmmmm, I just manually applied this patch to my trunk checkout and it worked just fine. Perhaps the test-patch fix to apply patches from either repo root or project root has a bug? Todd?

        Show
        Aaron T. Myers added a comment - Hmmmmm, I just manually applied this patch to my trunk checkout and it worked just fine. Perhaps the test-patch fix to apply patches from either repo root or project root has a bug? Todd?
        Hide
        Aaron T. Myers added a comment -

        Oh, I see. Though this is an HDFS JIRA, the fix is actually in Common. I'll move this JIRA.

        Show
        Aaron T. Myers added a comment - Oh, I see. Though this is an HDFS JIRA, the fix is actually in Common. I'll move this JIRA.
        Aaron T. Myers made changes -
        Project Hadoop HDFS [ 12310942 ] Hadoop Common [ 12310240 ]
        Key HDFS-2089 HADOOP-7419
        Affects Version/s 0.23.0 [ 12315569 ]
        Affects Version/s 0.23.0 [ 12315571 ]
        Fix Version/s 0.23.0 [ 12315569 ]
        Fix Version/s 0.23.0 [ 12315571 ]
        Hide
        Aaron T. Myers added a comment -

        Re-uploading the same patch to re-trigger test-patch.

        Show
        Aaron T. Myers added a comment - Re-uploading the same patch to re-trigger test-patch.
        Aaron T. Myers made changes -
        Attachment HDFS-2089.txt [ 12483545 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12483545/HDFS-2089.txt
        against trunk revision 1137724.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/666//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/666//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/666//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483545/HDFS-2089.txt against trunk revision 1137724. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/666//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/666//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/666//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        Also needs to do the same for MAPRED. Updated patch that I've been testing with for a while.

        Show
        Todd Lipcon added a comment - Also needs to do the same for MAPRED. Updated patch that I've been testing with for a while.
        Todd Lipcon made changes -
        Attachment hadoop-7419.txt [ 12485458 ]
        Hide
        Aaron T. Myers added a comment -

        +1, looks good to me. Thanks Todd.

        Show
        Aaron T. Myers added a comment - +1, looks good to me. Thanks Todd.
        Hide
        Todd Lipcon added a comment -

        Committed to trunk. Thanks Bing.

        Show
        Todd Lipcon added a comment - Committed to trunk. Thanks Bing.
        Todd Lipcon made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12485458/hadoop-7419.txt
        against trunk revision 1143491.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/703//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/703//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/703//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12485458/hadoop-7419.txt against trunk revision 1143491. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/703//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/703//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/703//console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #676 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/676/)
        HADOOP-7419. new hadoop-config.sh doesn't manage classpath for HADOOP_CONF_DIR correctly. Contributed by Bing Zheng and Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1143511
        Files :

        • /hadoop/common/trunk/common/bin/hadoop-config.sh
        • /hadoop/common/trunk/common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #676 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/676/ ) HADOOP-7419 . new hadoop-config.sh doesn't manage classpath for HADOOP_CONF_DIR correctly. Contributed by Bing Zheng and Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1143511 Files : /hadoop/common/trunk/common/bin/hadoop-config.sh /hadoop/common/trunk/common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #740 (See https://builds.apache.org/job/Hadoop-Common-trunk/740/)
        HADOOP-7419. new hadoop-config.sh doesn't manage classpath for HADOOP_CONF_DIR correctly. Contributed by Bing Zheng and Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1143511
        Files :

        • /hadoop/common/trunk/common/bin/hadoop-config.sh
        • /hadoop/common/trunk/common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #740 (See https://builds.apache.org/job/Hadoop-Common-trunk/740/ ) HADOOP-7419 . new hadoop-config.sh doesn't manage classpath for HADOOP_CONF_DIR correctly. Contributed by Bing Zheng and Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1143511 Files : /hadoop/common/trunk/common/bin/hadoop-config.sh /hadoop/common/trunk/common/CHANGES.txt
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Bing Zheng
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development