Hadoop Common
  1. Hadoop Common
  2. HADOOP-7392

Implement capability of querying individual property of a mbean using JMXProxyServlet

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Hadoop-7144 provides the capability to query all the properties of a mbean using JMXProxyServlet. In addition to this, we add the capability to query an individual property of a mbean. Client will send http request,

      http://hostname/jmx?get=meanName::property

      to query from server.

      1. HADOOP-7392.2.patch
        10 kB
        Tanping Wang
      2. HADOOP-7392.patch
        4 kB
        Tanping Wang

        Issue Links

          Activity

          Hide
          Luke Lu added a comment -
          1. I think /jmx should preserve the current behavior: list all mbeans, when no parameters are specified.
          2. Need to document the get syntax in the javadoc.
          3. Need to handle cases when property does(n't exist and make sure propertyinfo doesn't cause NPE later.
          4. Need to set the response status to 404 (SC_NOT_FOUND) if the property is not found.
          Show
          Luke Lu added a comment - I think /jmx should preserve the current behavior: list all mbeans, when no parameters are specified. Need to document the get syntax in the javadoc. Need to handle cases when property does(n't exist and make sure propertyinfo doesn't cause NPE later. Need to set the response status to 404 (SC_NOT_FOUND) if the property is not found.
          Hide
          Tanping Wang added a comment -

          Attach a patch to address the review comments.

          Show
          Tanping Wang added a comment - Attach a patch to address the review comments.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12483831/HADOOP-7392.2.patch
          against trunk revision 1139476.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/674//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/674//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/674//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12483831/HADOOP-7392.2.patch against trunk revision 1139476. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/674//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/674//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/674//console This message is automatically generated.
          Hide
          Luke Lu added a comment -

          +1, lgtm. Thanks Tanping!

          Show
          Luke Lu added a comment - +1, lgtm. Thanks Tanping!
          Hide
          Tanping Wang added a comment -

          Thanks Luke for reviewing. Just committed to trunk.

          Show
          Tanping Wang added a comment - Thanks Luke for reviewing. Just committed to trunk.

            People

            • Assignee:
              Tanping Wang
              Reporter:
              Tanping Wang
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development