Hadoop Common
  1. Hadoop Common
  2. HADOOP-7383

HDFS needs to export protobuf library dependency in pom

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      MR builds are failing since the HDFS protobuf patch went in, since they aren't picking up protobuf as a transitive dependency. I think we just need to add it to the HDFS pom template.

        Activity

        Hide
        Todd Lipcon added a comment -

        Actually it looks like our new methodology is to put all dependencies in common's pom, for whatever reason. I'll move this JIRA.

        Show
        Todd Lipcon added a comment - Actually it looks like our new methodology is to put all dependencies in common's pom, for whatever reason. I'll move this JIRA.
        Hide
        Todd Lipcon added a comment -

        Tested this patch with resolvers=internal, it fixed MR build for me.

        Show
        Todd Lipcon added a comment - Tested this patch with resolvers=internal, it fixed MR build for me.
        Hide
        Eli Collins added a comment -

        +1 (rationale for 2.4.0a btw is that 2.4.1 isn't in maven yet, should be there soon)

        Show
        Eli Collins added a comment - +1 (rationale for 2.4.0a btw is that 2.4.1 isn't in maven yet, should be there soon)
        Hide
        Eli Collins added a comment -

        I've committed this (before the Hudson results are in because in unbreaks the build). Thanks Todd!

        Show
        Eli Collins added a comment - I've committed this (before the Hudson results are in because in unbreaks the build). Thanks Todd!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12482271/hadoop-7383.txt
        against trunk revision 1134854.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/614//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/614//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/614//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12482271/hadoop-7383.txt against trunk revision 1134854. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/614//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/614//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/614//console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #648 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/648/)
        HADOOP-7383. HDFS needs to export protobuf library dependency in pom. Contributed by Todd Lipcon

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134857
        Files :

        • /hadoop/common/trunk/CHANGES.txt
        • /hadoop/common/trunk/ivy.xml
        • /hadoop/common/trunk/ivy/hadoop-common-template.xml
        • /hadoop/common/trunk/ivy/libraries.properties
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #648 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/648/ ) HADOOP-7383 . HDFS needs to export protobuf library dependency in pom. Contributed by Todd Lipcon eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134857 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/ivy.xml /hadoop/common/trunk/ivy/hadoop-common-template.xml /hadoop/common/trunk/ivy/libraries.properties
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-maven #13 (See https://builds.apache.org/job/Hadoop-Common-trunk-maven/13/)
        HADOOP-7383. HDFS needs to export protobuf library dependency in pom. Contributed by Todd Lipcon

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134857
        Files :

        • /hadoop/common/trunk/CHANGES.txt
        • /hadoop/common/trunk/ivy.xml
        • /hadoop/common/trunk/ivy/hadoop-common-template.xml
        • /hadoop/common/trunk/ivy/libraries.properties
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-maven #13 (See https://builds.apache.org/job/Hadoop-Common-trunk-maven/13/ ) HADOOP-7383 . HDFS needs to export protobuf library dependency in pom. Contributed by Todd Lipcon eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134857 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/ivy.xml /hadoop/common/trunk/ivy/hadoop-common-template.xml /hadoop/common/trunk/ivy/libraries.properties
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #717 (See https://builds.apache.org/job/Hadoop-Common-trunk/717/)
        HADOOP-7383. HDFS needs to export protobuf library dependency in pom. Contributed by Todd Lipcon

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134857
        Files :

        • /hadoop/common/trunk/CHANGES.txt
        • /hadoop/common/trunk/ivy.xml
        • /hadoop/common/trunk/ivy/hadoop-common-template.xml
        • /hadoop/common/trunk/ivy/libraries.properties
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #717 (See https://builds.apache.org/job/Hadoop-Common-trunk/717/ ) HADOOP-7383 . HDFS needs to export protobuf library dependency in pom. Contributed by Todd Lipcon eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1134857 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/ivy.xml /hadoop/common/trunk/ivy/hadoop-common-template.xml /hadoop/common/trunk/ivy/libraries.properties

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development