Hadoop Common
  1. Hadoop Common
  2. HADOOP-7356

RPM packages broke bin/hadoop script for hadoop 0.20.205

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.20.204.0
    • Fix Version/s: 0.20.204.0, 0.23.0
    • Component/s: None
    • Labels:
      None
    • Environment:

      Java 6, Redhat EL 5.5

    • Hadoop Flags:
      Reviewed

      Description

      hadoop-config.sh has been moved to libexec for binary package, but developers prefers to have hadoop-config.sh in bin. Hadoo shell scripts should be modified to support both scenarios.

      1. HADOOP-7356.patch
        8 kB
        Eric Yang
      2. HADOOP-7356-1.patch
        8 kB
        Eric Yang
      3. HADOOP-7356-1.patch
        8 kB
        Eric Yang
      4. HADOOP-7356-2.patch
        7 kB
        Eric Yang
      5. HADOOP-7356-trunk.patch
        3 kB
        Eric Yang

        Activity

        Hide
        Eric Yang added a comment -

        Preserve hadoop-config.sh and HADOOP_HOME locations for developers. This only applies to 0.20.204 or 0.20.205 branches.

        Show
        Eric Yang added a comment - Preserve hadoop-config.sh and HADOOP_HOME locations for developers. This only applies to 0.20.204 or 0.20.205 branches.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12481305/HADOOP-7356.patch
        against trunk revision 1130833.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/566//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481305/HADOOP-7356.patch against trunk revision 1130833. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/566//console This message is automatically generated.
        Hide
        Eric Yang added a comment -

        Fixed incorrect file references.

        Show
        Eric Yang added a comment - Fixed incorrect file references.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12481416/HADOOP-7356-1.patch
        against trunk revision 1131268.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/576//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481416/HADOOP-7356-1.patch against trunk revision 1131268. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/576//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        we also need this for trunk, right?

        todd@todd-w510:~/svn/hadoop-common-trunk-commit$ ./bin/hadoop fs -cat /asdf
        ./bin/hadoop: line 24: /home/todd/svn/hadoop-common-trunk-commit/bin/../libexec/hadoop-config.sh: No such file or directory
        ...
        
        Show
        Todd Lipcon added a comment - we also need this for trunk, right? todd@todd-w510:~/svn/hadoop-common-trunk-commit$ ./bin/hadoop fs -cat /asdf ./bin/hadoop: line 24: /home/todd/svn/hadoop-common-trunk-commit/bin/../libexec/hadoop-config.sh: No such file or directory ...
        Hide
        Eric Yang added a comment -

        Same patch for trunk.

        Show
        Eric Yang added a comment - Same patch for trunk.
        Hide
        Todd Lipcon added a comment -

        +1 for trunk patch. I'll commit there, and leave others to review the 205 branch.

        Show
        Todd Lipcon added a comment - +1 for trunk patch. I'll commit there, and leave others to review the 205 branch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12481624/HADOOP-7356-trunk.patch
        against trunk revision 1132776.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/585//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481624/HADOOP-7356-trunk.patch against trunk revision 1132776. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/585//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        Hudson's complaining above because it tried to apply the patch after I already did. I didn't wait for Hudson since it only affects the scripts which are tested manually anyway.

        Show
        Todd Lipcon added a comment - Hudson's complaining above because it tried to apply the patch after I already did. I didn't wait for Hudson since it only affects the scripts which are tested manually anyway.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #644 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/644/)
        HADOOP-7356. RPM packages broke bin/hadoop script in developer environment. Contributed by Eric Yang.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1132776
        Files :

        • /hadoop/common/trunk/bin/hadoop-daemons.sh
        • /hadoop/common/trunk/bin/stop-all.sh
        • /hadoop/common/trunk/bin/hadoop
        • /hadoop/common/trunk/CHANGES.txt
        • /hadoop/common/trunk/bin/hadoop-daemon.sh
        • /hadoop/common/trunk/bin/start-all.sh
        • /hadoop/common/trunk/bin/slaves.sh
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #644 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/644/ ) HADOOP-7356 . RPM packages broke bin/hadoop script in developer environment. Contributed by Eric Yang. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1132776 Files : /hadoop/common/trunk/bin/hadoop-daemons.sh /hadoop/common/trunk/bin/stop-all.sh /hadoop/common/trunk/bin/hadoop /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/bin/hadoop-daemon.sh /hadoop/common/trunk/bin/start-all.sh /hadoop/common/trunk/bin/slaves.sh
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #712 (See https://builds.apache.org/job/Hadoop-Common-trunk/712/)
        HADOOP-7356. RPM packages broke bin/hadoop script in developer environment. Contributed by Eric Yang.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1132776
        Files :

        • /hadoop/common/trunk/bin/hadoop-daemons.sh
        • /hadoop/common/trunk/bin/stop-all.sh
        • /hadoop/common/trunk/bin/hadoop
        • /hadoop/common/trunk/CHANGES.txt
        • /hadoop/common/trunk/bin/hadoop-daemon.sh
        • /hadoop/common/trunk/bin/start-all.sh
        • /hadoop/common/trunk/bin/slaves.sh
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #712 (See https://builds.apache.org/job/Hadoop-Common-trunk/712/ ) HADOOP-7356 . RPM packages broke bin/hadoop script in developer environment. Contributed by Eric Yang. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1132776 Files : /hadoop/common/trunk/bin/hadoop-daemons.sh /hadoop/common/trunk/bin/stop-all.sh /hadoop/common/trunk/bin/hadoop /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/bin/hadoop-daemon.sh /hadoop/common/trunk/bin/start-all.sh /hadoop/common/trunk/bin/slaves.sh
        Hide
        Owen O'Malley added a comment -

        Todd committed this.

        Show
        Owen O'Malley added a comment - Todd committed this.
        Hide
        Todd Lipcon added a comment -

        Hey Owen. As I commented here I left this open since it hasn't been committed to 0.20-security yet. Given the title I thought you might want to commit there before marking resolved.

        Show
        Todd Lipcon added a comment - Hey Owen. As I commented here I left this open since it hasn't been committed to 0.20-security yet. Given the title I thought you might want to commit there before marking resolved.
        Hide
        Eric Yang added a comment -

        Reopen for not yet committed to 0.20.20x branch.

        Show
        Eric Yang added a comment - Reopen for not yet committed to 0.20.20x branch.
        Hide
        Eric Yang added a comment -

        Owen, please review and commit to 0.20.20[4-5] branch. Thanks

        Show
        Eric Yang added a comment - Owen, please review and commit to 0.20.20 [4-5] branch. Thanks
        Hide
        Owen O'Malley added a comment -

        I committed this to 0.20.204.0. I took out the support for running out of non-deployed developer directories.

        Show
        Owen O'Malley added a comment - I committed this to 0.20.204.0. I took out the support for running out of non-deployed developer directories.
        Hide
        Eric Yang added a comment -

        I took out the support for running out of non-deployed developer directories.

        Owen, without support for non-deployed developer directories:

        "ant test-c++-libhdfs would -Dlibhdfs=true" fails because test native hdfs could not start hdfs via bin/hadoop shell script in source directory.

        Show
        Eric Yang added a comment - I took out the support for running out of non-deployed developer directories. Owen, without support for non-deployed developer directories: "ant test-c++-libhdfs would -Dlibhdfs=true" fails because test native hdfs could not start hdfs via bin/hadoop shell script in source directory.
        Hide
        Eric Yang added a comment -

        This blocks 0.20.204 release.

        Show
        Eric Yang added a comment - This blocks 0.20.204 release.
        Hide
        Eric Yang added a comment -

        Same as original patch but synchronized with the HEAD of the 0.20.204 branch.

        Show
        Eric Yang added a comment - Same as original patch but synchronized with the HEAD of the 0.20.204 branch.
        Hide
        Eric Yang added a comment -

        Minimize changes.

        Show
        Eric Yang added a comment - Minimize changes.
        Hide
        Devaraj Das added a comment -

        Giri committed the fix.

        Show
        Devaraj Das added a comment - Giri committed the fix.
        Hide
        Owen O'Malley added a comment -

        Hadoop 0.20.204.0 was released today.

        Show
        Owen O'Malley added a comment - Hadoop 0.20.204.0 was released today.

          People

          • Assignee:
            Eric Yang
            Reporter:
            Eric Yang
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development