Hadoop Common
  1. Hadoop Common
  2. HADOOP-7355

Add audience and stability annotations to HttpServer class

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HttpServer has at least one subclasser in HBase. Flag this class w/ annotations that make this plain so we avoid regressions like HADOOP-7351

      1. 7355.txt
        0.6 kB
        stack
      2. 7355-v2.txt
        1 kB
        stack

        Activity

        Konstantin Shvachko made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #708 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/708/)
        HADOOP-7355 Add audience and stability annotations to HttpServer class

        stack : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130729
        Files :

        • /hadoop/common/trunk/src/java/org/apache/hadoop/http/HttpServer.java
        • /hadoop/common/trunk/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #708 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/708/ ) HADOOP-7355 Add audience and stability annotations to HttpServer class stack : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130729 Files : /hadoop/common/trunk/src/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-22-branch #61 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/61/)
        HADOOP-7355 Add audience and stability annotations to HttpServer class

        stack : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130741
        Files :

        • /hadoop/common/branches/branch-0.22/src/java/org/apache/hadoop/http/HttpServer.java
        • /hadoop/common/branches/branch-0.22/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-22-branch #61 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/61/ ) HADOOP-7355 Add audience and stability annotations to HttpServer class stack : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130741 Files : /hadoop/common/branches/branch-0.22/src/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/branches/branch-0.22/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #633 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/633/)
        HADOOP-7355 Add audience and stability annotations to HttpServer class

        stack : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130729
        Files :

        • /hadoop/common/trunk/src/java/org/apache/hadoop/http/HttpServer.java
        • /hadoop/common/trunk/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #633 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/633/ ) HADOOP-7355 Add audience and stability annotations to HttpServer class stack : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1130729 Files : /hadoop/common/trunk/src/java/org/apache/hadoop/http/HttpServer.java /hadoop/common/trunk/CHANGES.txt
        stack made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 0.22.0 [ 12314296 ]
        Resolution Fixed [ 1 ]
        Hide
        stack added a comment -

        Committed to branch and trunk. Thanks for the review Tom.

        Show
        stack added a comment - Committed to branch and trunk. Thanks for the review Tom.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12481272/7355-v2.txt
        against trunk revision 1129989.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/562//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/562//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/562//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481272/7355-v2.txt against trunk revision 1129989. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/562//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/562//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/562//console This message is automatically generated.
        Hide
        Tom White added a comment -

        +1

        Show
        Tom White added a comment - +1
        stack made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        stack added a comment -

        Added missing import. Resubmit.

        Show
        stack added a comment - Added missing import. Resubmit.
        stack made changes -
        Attachment 7355-v2.txt [ 12481272 ]
        stack made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        stack added a comment -

        Missed import

        Show
        stack added a comment - Missed import
        stack made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        stack made changes -
        Field Original Value New Value
        Attachment 7355.txt [ 12481271 ]
        stack created issue -

          People

          • Assignee:
            stack
            Reporter:
            stack
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development