Hadoop Common
  1. Hadoop Common
  2. HADOOP-7340

incomplete help message is displayed for getmerge [addnl] option

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Duplicate
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.24.0
    • Component/s: fs
    • Labels:
      None

      Description

      The help message for the command "hdfs dfs -help getmerge" is displayed like this:
      "-getmerge <src> <localdst> [addnl]: Get all the files in the directories that
      match the source file pattern and merge and sort them to only
      one file on local fs. <src> is kept."
      and the information about [addnl] option is missed,despite the fact that [addnl] option is implemented.

      Therefore,the expected message should be displayed like this:
      "-getmerge <src> <localdst> [addnl]: Get all the files in the directories that
      match the source file pattern and merge and sort them to only
      one file on local fs. <src> is kept.
      addnl Optionally addnl can be set to enable adding a newline
      character at the end of each file."

      1. HADOOP-7340
        0.8 kB
        XieXianshan

        Issue Links

          Activity

          Hide
          Harsh J added a comment -

          This is now invalid, given HADOOP-7348.

          Resolving as duplicate. Thanks for your efforts Xie!

          Show
          Harsh J added a comment - This is now invalid, given HADOOP-7348 . Resolving as duplicate. Thanks for your efforts Xie!
          Hide
          XieXianshan added a comment -

          Thanks for the comments,i`ll update the patch as soon as possible.
          And meanwhile, i`ll submit another patch to "make it a flag like -addnl".

          Show
          XieXianshan added a comment - Thanks for the comments,i`ll update the patch as soon as possible. And meanwhile, i`ll submit another patch to "make it a flag like -addnl".
          Hide
          Todd Lipcon added a comment -

          apparently [addnl] should be either "true" or "false"... but like the TODO says in CopyCommands.java, we should deprecate that and make it a flag like -addnl

          Show
          Todd Lipcon added a comment - apparently [addnl] should be either "true" or "false"... but like the TODO says in CopyCommands.java, we should deprecate that and make it a flag like -addnl
          Hide
          Harsh J added a comment -

          I think the text can still be improved. For instance, reading that line still doesn't help me (who's never used 'addnl' before) understand what it ought to be set to. Should I type -getmerge path1 path2 addnl or should I type -getmerge path1 path2 '\n'?

          Show
          Harsh J added a comment - I think the text can still be improved. For instance, reading that line still doesn't help me (who's never used 'addnl' before) understand what it ought to be set to. Should I type -getmerge path1 path2 addnl or should I type -getmerge path1 path2 '\n' ?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12480925/HADOOP-7340
          against trunk revision 1128789.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/542//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/542//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/542//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12480925/HADOOP-7340 against trunk revision 1128789. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/542//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/542//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/542//console This message is automatically generated.
          Hide
          XieXianshan added a comment -

          Improve help message for fsShell "getmerge".

          Show
          XieXianshan added a comment - Improve help message for fsShell "getmerge".

            People

            • Assignee:
              XieXianshan
              Reporter:
              XieXianshan
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development