Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: util
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The API of PureJavaCrc32 is stable. It is incorrect to annotate it as private unstable.

      1. c7337_20110527.patch
        0.6 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #703 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/703/)
          HADOOP-7337. Change PureJavaCrc32 annotations to public stable.

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128789
          Files :

          • /hadoop/common/trunk/CHANGES.txt
          • /hadoop/common/trunk/src/java/org/apache/hadoop/util/PureJavaCrc32.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #703 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/703/ ) HADOOP-7337 . Change PureJavaCrc32 annotations to public stable. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128789 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/java/org/apache/hadoop/util/PureJavaCrc32.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #628 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/628/)
          HADOOP-7337. Change PureJavaCrc32 annotations to public stable.

          szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128789
          Files :

          • /hadoop/common/trunk/CHANGES.txt
          • /hadoop/common/trunk/src/java/org/apache/hadoop/util/PureJavaCrc32.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #628 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/628/ ) HADOOP-7337 . Change PureJavaCrc32 annotations to public stable. szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128789 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/java/org/apache/hadoop/util/PureJavaCrc32.java
          Hide
          Tsz Wo Nicholas Sze added a comment -

          No new tests added since this is an annotation and javadoc change.

          Thanks Todd for the review.

          I have committed this.

          Show
          Tsz Wo Nicholas Sze added a comment - No new tests added since this is an annotation and javadoc change. Thanks Todd for the review. I have committed this.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12480721/c7337_20110527.patch
          against trunk revision 1128475.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/537//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/537//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/537//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12480721/c7337_20110527.patch against trunk revision 1128475. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/537//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/537//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/537//console This message is automatically generated.
          Hide
          Todd Lipcon added a comment -

          +1

          Show
          Todd Lipcon added a comment - +1
          Hide
          Tsz Wo Nicholas Sze added a comment -

          c7337_20110527.patch: changed the annotation to public stable.

          Show
          Tsz Wo Nicholas Sze added a comment - c7337_20110527.patch: changed the annotation to public stable.

            People

            • Assignee:
              Tsz Wo Nicholas Sze
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development