Hadoop Common
  1. Hadoop Common
  2. HADOOP-7322

Adding a util method in FileUtil for JDK File.listFiles

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Release Note:
      Use of this new utility method avoids null result from File.listFiles(), and consequent NPEs.

      Description

      While testing Disk Fail Inplace, we encountered lots of NPE from Dir.listFiles API. This API can return null when Dir is not directory or disk is bad. I am proposing to have a File Util which can be used consistently across to deal with disk issues. This util api will do the following:

      1. When error happens it will throw IOException
      2. Else it will return empty list or list of files.

      Signature:
      File[] FileUtil.listFiles(File dir) throws IOException {}

      This way we no need to write wrapper code every where. Also, API is consistent with the signature.

      1. HADOOP-7322-1.patch
        4 kB
        Bharath Mundlapudi
      2. HADOOP-7322-2.patch
        3 kB
        Bharath Mundlapudi
      3. HADOOP-7322-3.patch
        4 kB
        Bharath Mundlapudi

        Issue Links

          Activity

          Bharath Mundlapudi created issue -
          Bharath Mundlapudi made changes -
          Field Original Value New Value
          Link This issue is related to HADOOP-7125 [ HADOOP-7125 ]
          Bharath Mundlapudi made changes -
          Attachment HADOOP-7322-1.patch [ 12480313 ]
          Bharath Mundlapudi made changes -
          Attachment HADOOP-7322-2.patch [ 12480342 ]
          Bharath Mundlapudi made changes -
          Attachment HADOOP-7322-3.patch [ 12480373 ]
          Bharath Mundlapudi made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Matt Foley made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Release Note Use of this new utility method avoids null result from File.listFiles(), and consequent NPEs.
          Resolution Fixed [ 1 ]
          Matt Foley made changes -
          Summary Adding a util method in FileUtil for directory listing Adding a util method in FileUtil for JDK File.listFiles
          Matt Foley made changes -
          Link This issue blocks HDFS-1934 [ HDFS-1934 ]
          Matt Foley made changes -
          Link This issue blocks HDFS-2023 [ HDFS-2023 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Link This issue blocks HDFS-2023 [ HDFS-2023 ]
          Gavin made changes -
          Link This issue is depended upon by HDFS-2023 [ HDFS-2023 ]

            People

            • Assignee:
              Bharath Mundlapudi
              Reporter:
              Bharath Mundlapudi
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development