Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-7308

Remove unused TaskLogAppender configurations from log4j.properties

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 2.9.0, 3.0.0-beta1, 3.1.0
    • Component/s: conf
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      MAPREDUCE-2372 improved TaskLogAppender to no longer need as much "wiring" in log4j.properties. There are also some old properties in there that are no longer used (eg logsRetainHours and noKeepSplits).

      1. HADOOP-7308.1.patch
        1 kB
        J.Andreina
      2. hadoop-7308.txt
        0.8 kB
        Todd Lipcon

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12924 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12924/)
          HADOOP-7308. Remove unused TaskLogAppender configurations from (aajisaka: rev 7e58b2478ce10f54b9b9a647f22a69dd528a81e6)

          • (edit) hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12924 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12924/ ) HADOOP-7308 . Remove unused TaskLogAppender configurations from (aajisaka: rev 7e58b2478ce10f54b9b9a647f22a69dd528a81e6) (edit) hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk, branch-3.0, and branch-2. Thank you!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-3.0, and branch-2. Thank you!
          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM, +1. Checking this in.

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM, +1. Checking this in.
          Hide
          nijel nijel added a comment -

          thanks J.Andreina for the update
          lgtm +1

          Show
          nijel nijel added a comment - thanks J.Andreina for the update lgtm +1
          Hide
          andreina J.Andreina added a comment -

          Attached an updated patch .
          Please review.

          Show
          andreina J.Andreina added a comment - Attached an updated patch . Please review.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12479825/hadoop-7308.txt
          against trunk revision 82db334.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5900//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479825/hadoop-7308.txt against trunk revision 82db334. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5900//console This message is automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          looks OK, +1

          Show
          stevel@apache.org Steve Loughran added a comment - looks OK, +1
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12479825/hadoop-7308.txt
          against trunk revision 1125051.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/486//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/486//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/486//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479825/hadoop-7308.txt against trunk revision 1125051. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/486//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/486//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/486//console This message is automatically generated.

            People

            • Assignee:
              tlipcon Todd Lipcon
              Reporter:
              tlipcon Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development