Hadoop Common
  1. Hadoop Common
  2. HADOOP-7306

Start metrics system even if config files are missing

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: metrics
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Tags:
      metrics, config

      Description

      Per experience and discussion with HDFS-1922, it seems preferable to treat missing metrics config file as empty/default config, which is more compatible with metrics v1 behavior (the MBeans are always registered.)

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #694 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/694/)
          HADOOP-7306. Start metrics system even if config files are missing. Contributed by Luke Lu.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1125216
          Files :

          • /hadoop/common/trunk/CHANGES.txt
          • /hadoop/common/trunk/src/test/core/org/apache/hadoop/metrics2/impl/TestMetricsConfig.java
          • /hadoop/common/trunk/src/java/org/apache/hadoop/metrics2/impl/MetricsConfig.java
          • /hadoop/common/trunk/src/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #694 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/694/ ) HADOOP-7306 . Start metrics system even if config files are missing. Contributed by Luke Lu. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1125216 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/test/core/org/apache/hadoop/metrics2/impl/TestMetricsConfig.java /hadoop/common/trunk/src/java/org/apache/hadoop/metrics2/impl/MetricsConfig.java /hadoop/common/trunk/src/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #612 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/612/)
          HADOOP-7306. Start metrics system even if config files are missing. Contributed by Luke Lu.

          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1125216
          Files :

          • /hadoop/common/trunk/CHANGES.txt
          • /hadoop/common/trunk/src/test/core/org/apache/hadoop/metrics2/impl/TestMetricsConfig.java
          • /hadoop/common/trunk/src/java/org/apache/hadoop/metrics2/impl/MetricsConfig.java
          • /hadoop/common/trunk/src/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #612 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/612/ ) HADOOP-7306 . Start metrics system even if config files are missing. Contributed by Luke Lu. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1125216 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/test/core/org/apache/hadoop/metrics2/impl/TestMetricsConfig.java /hadoop/common/trunk/src/java/org/apache/hadoop/metrics2/impl/MetricsConfig.java /hadoop/common/trunk/src/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java
          Hide
          Todd Lipcon added a comment -

          Committed to trunk, thanks Luke!

          Show
          Todd Lipcon added a comment - Committed to trunk, thanks Luke!
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12479806/hadoop-7306-missing-conf-v1.patch
          against trunk revision 1125051.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/487//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/487//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/487//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479806/hadoop-7306-missing-conf-v1.patch against trunk revision 1125051. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/487//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/487//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/487//console This message is automatically generated.
          Hide
          Todd Lipcon added a comment -

          +1 pending Hudson results. Thanks, Luke

          Show
          Todd Lipcon added a comment - +1 pending Hudson results. Thanks, Luke
          Hide
          Luke Lu added a comment -

          patch v1 also fix a minor bug for metrics system shutdown in mini-cluster mode.

          Show
          Luke Lu added a comment - patch v1 also fix a minor bug for metrics system shutdown in mini-cluster mode.

            People

            • Assignee:
              Luke Lu
              Reporter:
              Luke Lu
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development