Hadoop Common
  1. Hadoop Common
  2. HADOOP-7301

FSDataInputStream should expose a getWrappedStream method

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Ideally FSDataInputStream should expose a getWrappedStream method similarly to how FSDataOutputStream exposes a getWrappedStream method. Exposing this is useful for verifying correctness in tests cases. This FSDataInputStream type is the class that the o.a.h.fs.FileSystem.open call returns.

      1. hadoop-7301.2.patch
        2 kB
        Jonathan Hsieh
      2. hadoop-7301.patch
        1 kB
        Jonathan Hsieh

        Issue Links

          Activity

          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12479628/hadoop-7301.patch
          against trunk revision 1124368.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/471//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/471//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/471//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479628/hadoop-7301.patch against trunk revision 1124368. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/471//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/471//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/471//console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          Let's add a comment similar to the one FSDataOutputStream#getWrappredStream. Otherwise looks good.

             // Returns the underlying output stream. This is used by unit tests.
          
          Show
          Eli Collins added a comment - Let's add a comment similar to the one FSDataOutputStream#getWrappredStream. Otherwise looks good. // Returns the underlying output stream. This is used by unit tests.
          Hide
          Jonathan Hsieh added a comment -

          updated to add requested comment.

          Show
          Jonathan Hsieh added a comment - updated to add requested comment.
          Hide
          Eli Collins added a comment -

          +1

          Show
          Eli Collins added a comment - +1
          Hide
          Eli Collins added a comment -

          I've committed this. Thanks Jon!

          Show
          Eli Collins added a comment - I've committed this. Thanks Jon!
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12479641/hadoop-7301.2.patch
          against trunk revision 1124368.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/472//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/472//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/472//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479641/hadoop-7301.2.patch against trunk revision 1124368. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/472//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/472//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/472//console This message is automatically generated.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #608 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/608/)
          HADOOP-7301. FSDataInputStream should expose a getWrappedStream method. Contributed by Jonathan Hsieh

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124406
          Files :

          • /hadoop/common/trunk/CHANGES.txt
          • /hadoop/common/trunk/src/java/org/apache/hadoop/fs/FSDataInputStream.java
          • /hadoop/common/trunk/src/test/core/org/apache/hadoop/fs/FSMainOperationsBaseTest.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #608 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/608/ ) HADOOP-7301 . FSDataInputStream should expose a getWrappedStream method. Contributed by Jonathan Hsieh eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124406 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/java/org/apache/hadoop/fs/FSDataInputStream.java /hadoop/common/trunk/src/test/core/org/apache/hadoop/fs/FSMainOperationsBaseTest.java
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Hi, new public method needs javadoc.

          Show
          Tsz Wo Nicholas Sze added a comment - Hi, new public method needs javadoc.
          Hide
          Jonathan Hsieh added a comment -

          Nicholas,

          The patch seems to be committed now. Let me know how you would like me to proceed: (new patch? incremental patch? new jira?)

          Jon.

          Show
          Jonathan Hsieh added a comment - Nicholas, The patch seems to be committed now. Let me know how you would like me to proceed: (new patch? incremental patch? new jira?) Jon.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Hi Jon, either reverting the committed patch and reopening this, or fixing it in a new jira is fine. Thanks for the fast response.

          Show
          Tsz Wo Nicholas Sze added a comment - Hi Jon, either reverting the committed patch and reopening this, or fixing it in a new jira is fine. Thanks for the fast response.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #693 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/693/)
          HADOOP-7301. FSDataInputStream should expose a getWrappedStream method. Contributed by Jonathan Hsieh

          eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124406
          Files :

          • /hadoop/common/trunk/CHANGES.txt
          • /hadoop/common/trunk/src/java/org/apache/hadoop/fs/FSDataInputStream.java
          • /hadoop/common/trunk/src/test/core/org/apache/hadoop/fs/FSMainOperationsBaseTest.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #693 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/693/ ) HADOOP-7301 . FSDataInputStream should expose a getWrappedStream method. Contributed by Jonathan Hsieh eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124406 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/java/org/apache/hadoop/fs/FSDataInputStream.java /hadoop/common/trunk/src/test/core/org/apache/hadoop/fs/FSMainOperationsBaseTest.java

            People

            • Assignee:
              Jonathan Hsieh
              Reporter:
              Jonathan Hsieh
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development