Hadoop Common
  1. Hadoop Common
  2. HADOOP-7300

Configuration methods that return collections are inconsistent about mutability

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: conf
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In particular, getTrimmedStringCollection seems to return an immutable collection, whereas getStringCollection returns a mutable one.

      IMO we should always return mutable collections since these methods by definition are doing copies.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        1m 39s 1 Todd Lipcon 18/May/11 18:54
        Patch Available Patch Available Resolved Resolved
        36m 50s 1 Todd Lipcon 18/May/11 19:31
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #693 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/693/)
        HADOOP-7300. Configuration methods that return collections are inconsistent about mutability. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124368
        Files :

        • /hadoop/common/trunk/src/test/core/org/apache/hadoop/conf/TestConfiguration.java
        • /hadoop/common/trunk/CHANGES.txt
        • /hadoop/common/trunk/src/java/org/apache/hadoop/conf/Configuration.java
        • /hadoop/common/trunk/src/java/org/apache/hadoop/util/StringUtils.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #693 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/693/ ) HADOOP-7300 . Configuration methods that return collections are inconsistent about mutability. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124368 Files : /hadoop/common/trunk/src/test/core/org/apache/hadoop/conf/TestConfiguration.java /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/java/org/apache/hadoop/conf/Configuration.java /hadoop/common/trunk/src/java/org/apache/hadoop/util/StringUtils.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-22-branch #51 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/51/)
        HADOOP-7300. Configuration methods that return collections are inconsistent about mutability. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124370
        Files :

        • /hadoop/common/branches/branch-0.22/src/java/org/apache/hadoop/util/StringUtils.java
        • /hadoop/common/branches/branch-0.22/CHANGES.txt
        • /hadoop/common/branches/branch-0.22/src/test/core/org/apache/hadoop/conf/TestConfiguration.java
        • /hadoop/common/branches/branch-0.22/src/java/org/apache/hadoop/conf/Configuration.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-22-branch #51 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/51/ ) HADOOP-7300 . Configuration methods that return collections are inconsistent about mutability. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124370 Files : /hadoop/common/branches/branch-0.22/src/java/org/apache/hadoop/util/StringUtils.java /hadoop/common/branches/branch-0.22/CHANGES.txt /hadoop/common/branches/branch-0.22/src/test/core/org/apache/hadoop/conf/TestConfiguration.java /hadoop/common/branches/branch-0.22/src/java/org/apache/hadoop/conf/Configuration.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #607 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/607/)
        HADOOP-7300. Configuration methods that return collections are inconsistent about mutability. Contributed by Todd Lipcon.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124368
        Files :

        • /hadoop/common/trunk/src/test/core/org/apache/hadoop/conf/TestConfiguration.java
        • /hadoop/common/trunk/CHANGES.txt
        • /hadoop/common/trunk/src/java/org/apache/hadoop/conf/Configuration.java
        • /hadoop/common/trunk/src/java/org/apache/hadoop/util/StringUtils.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #607 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/607/ ) HADOOP-7300 . Configuration methods that return collections are inconsistent about mutability. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124368 Files : /hadoop/common/trunk/src/test/core/org/apache/hadoop/conf/TestConfiguration.java /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/java/org/apache/hadoop/conf/Configuration.java /hadoop/common/trunk/src/java/org/apache/hadoop/util/StringUtils.java
        Todd Lipcon made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Todd Lipcon added a comment -

        Committed to trunk and 0.22. Thanks for the quick review, Chris!

        Show
        Todd Lipcon added a comment - Committed to trunk and 0.22. Thanks for the quick review, Chris!
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12479625/hadoop-7300.txt
        against trunk revision 1104426.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/469//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/469//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/469//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479625/hadoop-7300.txt against trunk revision 1104426. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/469//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/469//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/469//console This message is automatically generated.
        Hide
        Chris Douglas added a comment -

        +1

        Show
        Chris Douglas added a comment - +1
        Todd Lipcon made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Todd Lipcon made changes -
        Field Original Value New Value
        Attachment hadoop-7300.txt [ 12479625 ]
        Todd Lipcon created issue -

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development