Hadoop Common
  1. Hadoop Common
  2. HADOOP-7297

Error in the documentation regarding Checkpoint/Backup Node

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.20.205.0
    • Fix Version/s: 0.20.203.1, 1.1.0
    • Component/s: documentation
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      On http://hadoop.apache.org/common/docs/r0.20.203.0/hdfs_user_guide.html#Checkpoint+Node: the command bin/hdfs namenode -checkpoint required to launch the backup/checkpoint node does not exist.
      I have removed this from the docs.

      1. hadoop-7297.patch
        1 kB
        Christoph Böhm
      2. hadoop-7297.patch
        7 kB
        Harsh J

        Issue Links

          Activity

          Harsh J made changes -
          Link This issue is duplicated by HDFS-4348 [ HDFS-4348 ]
          Matt Foley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop-1.1.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop-1.1.0.
          Hide
          Harsh J added a comment -

          Tony,

          Yes, will be fixed in 1.1.0's doc publishing. Sorry about this.

          Show
          Harsh J added a comment - Tony, Yes, will be fixed in 1.1.0's doc publishing. Sorry about this.
          Hide
          Tony Meng added a comment -
          Show
          Tony Meng added a comment - Seems the document of 0.20.205.0 still has this issue: http://hadoop.apache.org/common/docs/r0.20.205.0/hdfs_user_guide.html#Checkpoint+Node
          Harsh J made changes -
          Hadoop Flags Reviewed [ 10343 ]
          Harsh J made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Harsh J added a comment -

          Thanks for +1 Todd. Committed to branch-0.20-security.

          Unfortunately am unable to remove that 'archived fix version' 0.20.203.1 which isn't gonna be. The true fix version remains 0.20.206.

          Show
          Harsh J added a comment - Thanks for +1 Todd. Committed to branch-0.20-security. Unfortunately am unable to remove that 'archived fix version' 0.20.203.1 which isn't gonna be. The true fix version remains 0.20.206.
          Harsh J made changes -
          Fix Version/s 0.20.206.0 [ 12316501 ]
          Affects Version/s 0.20.205.0 [ 12316390 ]
          Affects Version/s 0.20.203.0 [ 12316064 ]
          Matt Foley made changes -
          Fix Version/s 0.20.205.0 [ 12316390 ]
          Target Version/s 0.20.206.0 [ 12316501 ]
          Hide
          Todd Lipcon added a comment -

          +1. For 20-only patches, you should make and commit them against the "branch-0.20-security". I believe the specific release branches are so that, once an initial RC is cut, people can continue to commit to 20-security without it going into a later rc. So here, you should commit just to branch-0.20-security, and then it will be picked up for the 206 release.

          Show
          Todd Lipcon added a comment - +1. For 20-only patches, you should make and commit them against the "branch-0.20-security". I believe the specific release branches are so that, once an initial RC is cut, people can continue to commit to 20-security without it going into a later rc. So here, you should commit just to branch-0.20-security, and then it will be picked up for the 206 release.
          Harsh J made changes -
          Fix Version/s 0.20.205.0 [ 12316390 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12492712/hadoop-7297.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/125//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12492712/hadoop-7297.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/125//console This message is automatically generated.
          Hide
          Harsh J added a comment -

          Also, what's the branch to do 0.20 stuff? I see one branch each for 203, 204 and 205, which is mighty confusing. Why can't we be cutting out on a serial 0.20 line? That branch has been stagnant for quite a while now, too.

          But anyway, this patch was against branch-0.20-security-203, and hopefully portable (forward/backward/???) to other branches.

          Show
          Harsh J added a comment - Also, what's the branch to do 0.20 stuff? I see one branch each for 203, 204 and 205, which is mighty confusing. Why can't we be cutting out on a serial 0.20 line? That branch has been stagnant for quite a while now, too. But anyway, this patch was against branch-0.20-security-203, and hopefully portable (forward/backward/???) to other branches.
          Harsh J made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Harsh J made changes -
          Attachment hadoop-7297.patch [ 12492712 ]
          Hide
          Harsh J added a comment -

          Updated patch that removes all references. This almost caused confusion again, so picked it up myself.

          (Note: Excuse the space/tab warning on the only modification line in the patch, if you note the other lines, I've tried to maintain it the same as <4sp><tab><tab>.)

          Show
          Harsh J added a comment - Updated patch that removes all references. This almost caused confusion again, so picked it up myself. (Note: Excuse the space/tab warning on the only modification line in the patch, if you note the other lines, I've tried to maintain it the same as <4sp><tab><tab>.)
          Harsh J made changes -
          Assignee Christoph Böhm [ chrisbo ] Harsh J [ qwertymaniac ]
          Hide
          Jakob Homan added a comment -

          Christoph - can you remove the rest of the references to backup and checkpoint node? I'll manually test the patch since it's a bit of a pain without Jenkins.

          Thanks. -jg

          Show
          Jakob Homan added a comment - Christoph - can you remove the rest of the references to backup and checkpoint node? I'll manually test the patch since it's a bit of a pain without Jenkins. Thanks. -jg
          Jakob Homan made changes -
          Assignee Christoph Böhm [ chrisbo ]
          Harsh J made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Fix Version/s 0.20.203.1 [ 12316290 ]
          Hide
          Harsh J added a comment -

          (Cancelling patch, needs more removals)

          Show
          Harsh J added a comment - (Cancelling patch, needs more removals)
          Hide
          Todd Lipcon added a comment -

          If the patch is against non-trunk, the QA Bot isn't smart enough to apply a patch.

          Show
          Todd Lipcon added a comment - If the patch is against non-trunk, the QA Bot isn't smart enough to apply a patch.
          Hide
          Harsh J added a comment -

          Christoph,

          Thank you very much for contributing a patch fix!

          Since CN and BN nodes are both not present in this release, all documentation that refers to it around ought to be removed. Could you re-up a fresh patch with all relevant documentation and references removed?

          I'm unsure as to how it got in (perhaps a bad documentation cherry-pick while implementing the branch?)

          I think the QA failed to apply the patch because of Eclipse specific lines in it (as seen on top). Could you try with a simple svn diff or a git diff --no-prefix and re-upload?

          Show
          Harsh J added a comment - Christoph, Thank you very much for contributing a patch fix! Since CN and BN nodes are both not present in this release, all documentation that refers to it around ought to be removed. Could you re-up a fresh patch with all relevant documentation and references removed? I'm unsure as to how it got in (perhaps a bad documentation cherry-pick while implementing the branch?) I think the QA failed to apply the patch because of Eclipse specific lines in it (as seen on top). Could you try with a simple svn diff or a git diff --no-prefix and re-upload?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12481942/hadoop-7297.patch
          against trunk revision 1133125.

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/600//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481942/hadoop-7297.patch against trunk revision 1133125. +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/600//console This message is automatically generated.
          Christoph Böhm made changes -
          Attachment hadoop-7297.patch [ 12481942 ]
          Hide
          Christoph Böhm added a comment -

          I have removed this from the docs.

          Show
          Christoph Böhm added a comment - I have removed this from the docs.
          Christoph Böhm made changes -
          Description On http://hadoop.apache.org/common/docs/r0.20.203.0/hdfs_user_guide.html#Checkpoint+Node: the command bin/hdfs namenode -checkpoint required to launch the backup/checkpoint node does not exist. On http://hadoop.apache.org/common/docs/r0.20.203.0/hdfs_user_guide.html#Checkpoint+Node: the command bin/hdfs namenode -checkpoint required to launch the backup/checkpoint node does not exist.
          I have removed this from the docs.
          made changes -
          Status Reopened [ 4 ] Patch Available [ 10002 ]
          Hide
          Harsh J added a comment -

          (What I mean is the bad docs ought to be removed, not the inclusion of CN/BN).

          Show
          Harsh J added a comment - (What I mean is the bad docs ought to be removed, not the inclusion of CN/BN).
          Harsh J made changes -
          Resolution Not A Problem [ 8 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          Harsh J added a comment -

          Reopening since the issue of docs is valid. There are CN and BN node docs on the tagged svn rev: http://svn.apache.org/repos/asf/hadoop/common/tags/release-0.20.203.0/src/docs/src/documentation/content/xdocs/hdfs_user_guide.xml

          Show
          Harsh J added a comment - Reopening since the issue of docs is valid. There are CN and BN node docs on the tagged svn rev: http://svn.apache.org/repos/asf/hadoop/common/tags/release-0.20.203.0/src/docs/src/documentation/content/xdocs/hdfs_user_guide.xml
          Hide
          Harsh J added a comment -

          Suresh - They are present in the docs, so one would think they exist in 203 as well. The docs surely ought to be fixed if these features are not present.

          (This since OP had posted a link that's 203 doc specific)

          Show
          Harsh J added a comment - Suresh - They are present in the docs, so one would think they exist in 203 as well. The docs surely ought to be fixed if these features are not present. (This since OP had posted a link that's 203 doc specific)
          Suresh Srinivas made changes -
          Field Original Value New Value
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Not A Problem [ 8 ]
          Hide
          Suresh Srinivas added a comment -

          I do not think this is a problem for 0.20.203.

          Show
          Suresh Srinivas added a comment - I do not think this is a problem for 0.20.203.
          Hide
          Suresh Srinivas added a comment -

          namenode -checkpoint and backup nodes were added in 0.21 and they are not in 0.20.203 release.

          Show
          Suresh Srinivas added a comment - namenode -checkpoint and backup nodes were added in 0.21 and they are not in 0.20.203 release.
          arnaud p created issue -

            People

            • Assignee:
              Harsh J
              Reporter:
              arnaud p
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development