Hadoop Common
  1. Hadoop Common
  2. HADOOP-7277

Add Eclipse launch tasks for the 0.20-security branch

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.20.204.0
    • Fix Version/s: 0.20.204.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This is to add the eclipse launchers from HADOOP-5911 to the 0.20 security branch.

      Eclipse has a notion of "run configuration", which encapsulates what's needed to run or debug an application. I use this quite a bit to start various Hadoop daemons in debug mode, with breakpoints set, to inspect state and what not.

      This is simply configuration, so no tests are provided. After running "ant eclipse" and refreshing your project, you should see entries in the Run Configurations and Debug Configurations for launching the various hadoop daemons from within eclipse. There's a template for testing a specific test, and also templates to run all the tests, the job tracker, and a task tracker. It's likely that some parameters need to be further tweaked to have the same behavior as "ant test", but for most tests, this works.

      This also requires a small change to build.xml for the eclipse classpath.

      1. HADOOP-7277-0.20s.patch
        20 kB
        Jeffrey Naisbitt

        Activity

        Hide
        Jeffrey Naisbitt added a comment -

        Patch for the 0.20-security branch

        Show
        Jeffrey Naisbitt added a comment - Patch for the 0.20-security branch
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12478849/HADOOP-7277-0.20s.patch
        against trunk revision 1101735.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/432//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478849/HADOOP-7277-0.20s.patch against trunk revision 1101735. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/432//console This message is automatically generated.
        Hide
        Jeffrey Naisbitt added a comment -

        The patch is for the 0.20-security branch, so the above results should be ignored. Here are the results from my manual run:
        [exec] -1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 6 new or modified tests.
        [exec]
        [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] -1 Eclipse classpath. The patch causes the Eclipse classpath to differ from the contents of the lib directories.

        The javadoc and Eclipse classpath issues are unrelated to these changes. I'm also not sure why it says 6 new/modified tests are included since none are included in this patch. None are needed though since it's just eclipse things.

        Show
        Jeffrey Naisbitt added a comment - The patch is for the 0.20-security branch, so the above results should be ignored. Here are the results from my manual run: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] -1 Eclipse classpath. The patch causes the Eclipse classpath to differ from the contents of the lib directories. The javadoc and Eclipse classpath issues are unrelated to these changes. I'm also not sure why it says 6 new/modified tests are included since none are included in this patch. None are needed though since it's just eclipse things.
        Hide
        Chris Douglas added a comment -

        +1

        Ran the eclipse target, tried a unit test. I committed this to the 20-security branch. Thanks, Jeff!

        Show
        Chris Douglas added a comment - +1 Ran the eclipse target, tried a unit test. I committed this to the 20-security branch. Thanks, Jeff!
        Hide
        Jeffrey Naisbitt added a comment -

        We should probably also add .launches to the svn:ignore property. Do you want to do that, Chris?

        Show
        Jeffrey Naisbitt added a comment - We should probably also add .launches to the svn:ignore property. Do you want to do that, Chris?
        Hide
        Chris Douglas added a comment -

        nod Good point. Updated .gitignore file and svn:ignore properties for .launches/ and .externalToolBuilders/

        Show
        Chris Douglas added a comment - nod Good point. Updated .gitignore file and svn:ignore properties for .launches/ and .externalToolBuilders/
        Hide
        Owen O'Malley added a comment -

        Hadoop 0.20.204.0 was released today.

        Show
        Owen O'Malley added a comment - Hadoop 0.20.204.0 was released today.

          People

          • Assignee:
            Jeffrey Naisbitt
            Reporter:
            Jeffrey Naisbitt
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development