Hadoop Common
  1. Hadoop Common
  2. HADOOP-7272

Remove unnecessary security related info logs

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.22.1
    • Component/s: ipc, security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Two info logs are printed when connection to RPC server is established, is not necessary. On a production cluster, these log lines made up of close to 50% of lines in the namenode log. I propose changing them into debug logs.

      1. HADOOP-7272.patch
        1 kB
        Suresh Srinivas
      2. HADOOP-7272.rel205.patch
        2 kB
        Suresh Srinivas
      3. HADOOP-7272.rel205.patch
        2 kB
        Suresh Srinivas
      4. hadoop-7272-022.patch
        2 kB
        Benoy Antony

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-22-branch #106 (See https://builds.apache.org/job/Hadoop-Common-22-branch/106/)
          HADOOP-7272. Remove unnecessary security related info logs. Contributed by Suresh Srinivas and Benoy Antony. (Revision 1346236)

          Result = SUCCESS
          shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1346236
          Files :

          • /hadoop/common/branches/branch-0.22/common/CHANGES.txt
          • /hadoop/common/branches/branch-0.22/common/src/java/org/apache/hadoop/ipc/Server.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-22-branch #106 (See https://builds.apache.org/job/Hadoop-Common-22-branch/106/ ) HADOOP-7272 . Remove unnecessary security related info logs. Contributed by Suresh Srinivas and Benoy Antony. (Revision 1346236) Result = SUCCESS shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1346236 Files : /hadoop/common/branches/branch-0.22/common/CHANGES.txt /hadoop/common/branches/branch-0.22/common/src/java/org/apache/hadoop/ipc/Server.java
          Hide
          Konstantin Shvachko added a comment -

          I just committed this to branch 0.22.1. Thank you Benoy.

          Show
          Konstantin Shvachko added a comment - I just committed this to branch 0.22.1. Thank you Benoy.
          Hide
          Benoy Antony added a comment -

          Patch for 22 is attached.

          Show
          Benoy Antony added a comment - Patch for 22 is attached.
          Hide
          Suresh Srinivas added a comment -

          I committed the change to 0.20.security branch. I am not going to commit this to 0.20.205 branch, as this is not a big issue. LOG.info is surrounded by LOG.isDebugEnabled(). Hence for setup where debug is not enabled, this log is not printed. If debug is enabled, it just gets printed as info instead of debug.

          Show
          Suresh Srinivas added a comment - I committed the change to 0.20.security branch. I am not going to commit this to 0.20.205 branch, as this is not a big issue. LOG.info is surrounded by LOG.isDebugEnabled(). Hence for setup where debug is not enabled, this log is not printed. If debug is enabled, it just gets printed as info instead of debug.
          Hide
          Suresh Srinivas added a comment -

          Thanks for catching that Eli. I will commit the right version of the patch.

          Show
          Suresh Srinivas added a comment - Thanks for catching that Eli. I will commit the right version of the patch.
          Hide
          Eli Collins added a comment -

          Looks like the wrong patch for 205 got checked in (it has info instead of debug).

          Show
          Eli Collins added a comment - Looks like the wrong patch for 205 got checked in (it has info instead of debug).
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 the new 205 patch looks good.

          Show
          Tsz Wo Nicholas Sze added a comment - +1 the new 205 patch looks good.
          Hide
          Suresh Srinivas added a comment -

          New patch addresses the comment.

          Show
          Suresh Srinivas added a comment - New patch addresses the comment.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          LOG.info should be LOG.debug in the 205 patch.

          Show
          Tsz Wo Nicholas Sze added a comment - LOG.info should be LOG.debug in the 205 patch.
          Hide
          Suresh Srinivas added a comment -

          Patch for 0.20.security branch - to become part of 0.20.205 release.

          Show
          Suresh Srinivas added a comment - Patch for 0.20.security branch - to become part of 0.20.205 release.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #685 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/685/)
          HADOOP-7272. Remove unnecessary security related info logs. Contributed by Suresh Srinivas.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #685 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/685/ ) HADOOP-7272 . Remove unnecessary security related info logs. Contributed by Suresh Srinivas.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #585 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/585/)
          HADOOP-7272. Remove unnecessary security related info logs. Contributed by Suresh Srinivas.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #585 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/585/ ) HADOOP-7272 . Remove unnecessary security related info logs. Contributed by Suresh Srinivas.
          Hide
          Suresh Srinivas added a comment -

          I committed the change.

          Show
          Suresh Srinivas added a comment - I committed the change.
          Hide
          Suresh Srinivas added a comment -

          Since this is a trivial log change, I compiled the change to make sure the code compiles. Not planning to run hudson job or add tests.

          Show
          Suresh Srinivas added a comment - Since this is a trivial log change, I compiled the change to make sure the code compiles. Not planning to run hudson job or add tests.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good.

          Show
          Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
          Hide
          Suresh Srinivas added a comment -

          The logs are:

          LOG.info("SASL server context established. Negotiated QoP is "
                 + saslServer.getNegotiatedProperty(Sasl.QOP));
          LOG.info("SASL server successfully authenticated client: " + user);
          

          Of this the second log is also recorded in audit logs.

          Show
          Suresh Srinivas added a comment - The logs are: LOG.info("SASL server context established. Negotiated QoP is " + saslServer.getNegotiatedProperty(Sasl.QOP)); LOG.info("SASL server successfully authenticated client: " + user); Of this the second log is also recorded in audit logs.

            People

            • Assignee:
              Suresh Srinivas
              Reporter:
              Suresh Srinivas
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development