Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The FsShell commands have no standard format for the same error message. For instance, here is a snippet of the variations of just one of many error messages:

      cmd: $path: No such file or directory
      cmd: cannot stat `$path': No such file or directory
      cmd: Can not find listing for $path
      cmd: Cannot access $path: No such file or directory.
      cmd: No such file or directory `$path'
      cmd: File does not exist: $path
      cmd: File $path does not exist
      ... etc ...

      These need to be common.

      1. HADOOP-7271.patch
        27 kB
        Daryn Sharp
      2. HADOOP-7271-2.patch
        27 kB
        Daryn Sharp

        Issue Links

          Activity

          Hide
          Daryn Sharp added a comment -

          Create path exceptions that encapsulate and enforce a standard posix/unix error message.

          Change cmds, both redesigned and pending redesign, to use the new exceptions. The changes made to the pending cmds are to facilitate a redesign of multiple commands w/o constantly breaking hdfs tests each time a command is updated.

          Took out some of the TODO items related to standardizing.

          Show
          Daryn Sharp added a comment - Create path exceptions that encapsulate and enforce a standard posix/unix error message. Change cmds, both redesigned and pending redesign, to use the new exceptions. The changes made to the pending cmds are to facilitate a redesign of multiple commands w/o constantly breaking hdfs tests each time a command is updated. Took out some of the TODO items related to standardizing.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12478716/HADOOP-7271.patch
          against trunk revision 1101570.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.fs.shell.TestPathExceptions

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/422//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/422//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/422//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478716/HADOOP-7271.patch against trunk revision 1101570. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.fs.shell.TestPathExceptions +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/422//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/422//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/422//console This message is automatically generated.
          Hide
          Daryn Sharp added a comment -

          Add the apostrophes needed to make the tests pass.

          Show
          Daryn Sharp added a comment - Add the apostrophes needed to make the tests pass.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12478720/HADOOP-7271-2.patch
          against trunk revision 1101570.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/423//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/423//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/423//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478720/HADOOP-7271-2.patch against trunk revision 1101570. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/423//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/423//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/423//console This message is automatically generated.
          Hide
          John George added a comment -

          +1. looks good to me.

          Show
          John George added a comment - +1. looks good to me.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks, Daryn!

          Also thanks John for reviewing it.

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Daryn! Also thanks John for reviewing it.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #584 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/584/)
          HADOOP-7271. Standardize shell command error messages. Contributed by Daryn Sharp

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #584 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/584/ ) HADOOP-7271 . Standardize shell command error messages. Contributed by Daryn Sharp
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #685 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/685/)
          HADOOP-7271. Standardize shell command error messages. Contributed by Daryn Sharp

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #685 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/685/ ) HADOOP-7271 . Standardize shell command error messages. Contributed by Daryn Sharp

            People

            • Assignee:
              Daryn Sharp
              Reporter:
              Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development