Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Refactor to conform to the FsCommand class.

      1. HADOOP-7267.patch
        15 kB
        Daryn Sharp
      2. HADOOP-7267-2.patch
        15 kB
        Daryn Sharp
      3. HADOOP-7267-3.patch
        15 kB
        Daryn Sharp

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #686 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/686/)
        HADOOP-7267. Refactor the rm/rmr/expunge commands to conform to new FsCommand class. Contributed by Daryn Sharp

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #686 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/686/ ) HADOOP-7267 . Refactor the rm/rmr/expunge commands to conform to new FsCommand class. Contributed by Daryn Sharp
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #591 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/591/)
        HADOOP-7267. Refactor the rm/rmr/expunge commands to conform to new FsCommand class. Contributed by Daryn Sharp

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #591 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/591/ ) HADOOP-7267 . Refactor the rm/rmr/expunge commands to conform to new FsCommand class. Contributed by Daryn Sharp
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Daryn!

        Also thanks John for reviewing it.

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Daryn! Also thanks John for reviewing it.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12478880/HADOOP-7267-3.patch
        against trunk revision 1102068.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/435//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/435//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/435//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478880/HADOOP-7267-3.patch against trunk revision 1102068. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/435//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/435//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/435//console This message is automatically generated.
        Hide
        Daryn Sharp added a comment -

        upmerge again, third time is a charm...

        Show
        Daryn Sharp added a comment - upmerge again, third time is a charm...
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12478879/HADOOP-7267-2.patch
        against trunk revision 1102068.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/434//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478879/HADOOP-7267-2.patch against trunk revision 1102068. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/434//console This message is automatically generated.
        Hide
        Daryn Sharp added a comment -

        upmerge to resolve conflict from removal of other commands

        Show
        Daryn Sharp added a comment - upmerge to resolve conflict from removal of other commands
        Hide
        John George added a comment -

        +1 The code seems to do what it did before.

        Show
        John George added a comment - +1 The code seems to do what it did before.
        Hide
        Daryn Sharp added a comment -

        The findbugs warning is not in the code that I modified. Note that it is in code that will soon be removed.

        Show
        Daryn Sharp added a comment - The findbugs warning is not in the code that I modified. Note that it is in code that will soon be removed.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12478830/HADOOP-7267.patch
        against trunk revision 1101735.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/428//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/428//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/428//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478830/HADOOP-7267.patch against trunk revision 1101735. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/428//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/428//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/428//console This message is automatically generated.

          People

          • Assignee:
            Daryn Sharp
            Reporter:
            Daryn Sharp
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development