Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: metrics
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    1. HADOOP-7266.001.patch
      40 kB
      Akira Ajisaka
    2. HADOOP-7266.002.patch
      41 kB
      Akira Ajisaka
    3. HADOOP-7266.003.patch
      42 kB
      Akira Ajisaka
    4. HADOOP-7266.004.patch
      40 kB
      Akira Ajisaka
    5. HADOOP-7266.005.patch
      43 kB
      Akira Ajisaka
    6. HADOOP-7266.006.patch
      27 kB
      Akira Ajisaka
    7. HADOOP-7266.007.patch
      25 kB
      Akira Ajisaka
    8. HADOOP-7266-remove.001.patch
      186 kB
      Akira Ajisaka

      Issue Links

        Activity

        Hide
        Luke Lu added a comment -

        After all framework metrics have been ported to metrics v2.

        Show
        Luke Lu added a comment - After all framework metrics have been ported to metrics v2.
        Hide
        Luke Lu added a comment -

        By framework, I meant non-user/downstream metrics related code in common, hdfs and mapreduce, as per discussion in HADOOP-6728.

        Show
        Luke Lu added a comment - By framework, I meant non-user/downstream metrics related code in common, hdfs and mapreduce, as per discussion in HADOOP-6728 .
        Hide
        Allen Wittenauer added a comment -

        Fixed. I think.

        Show
        Allen Wittenauer added a comment - Fixed. I think.
        Hide
        Allen Wittenauer added a comment -

        Nope, looks like metricsv1 is still there.

        Show
        Allen Wittenauer added a comment - Nope, looks like metricsv1 is still there.
        Hide
        Allen Wittenauer added a comment -

        Making this a blocker for 2.8.0 so we these can be removed in 3.0.0

        Show
        Allen Wittenauer added a comment - Making this a blocker for 2.8.0 so we these can be removed in 3.0.0
        Hide
        Akira Ajisaka added a comment -

        Hi Luke Lu, what's going on this issue? I'd like to take over and fix this issue quickly as it has been marked as blocker for the next minor release.

        Show
        Akira Ajisaka added a comment - Hi Luke Lu , what's going on this issue? I'd like to take over and fix this issue quickly as it has been marked as blocker for the next minor release.
        Hide
        Akira Ajisaka added a comment -

        Attaching a patch to add @Deprecated annotation to all the metrics v1 classes.

        Show
        Akira Ajisaka added a comment - Attaching a patch to add @Deprecated annotation to all the metrics v1 classes.
        Hide
        Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 33s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
        -1 javac 7m 29s The applied patch generated 186 additional warning messages.
        +1 javadoc 9m 30s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 17s The applied patch generated 117 new checkstyle issues (total was 447, now 558).
        -1 whitespace 0m 12s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 2m 20s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 common tests 23m 5s Tests passed in hadoop-common.
        +1 tools/hadoop tests 6m 9s Tests passed in hadoop-streaming.
            67m 23s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12731148/HADOOP-7266.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / d335071
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/diffJavacWarnings.txt
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/diffcheckstylehadoop-common.txt
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/whitespace.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/testrun_hadoop-common.txt
        hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/testrun_hadoop-streaming.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 33s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. -1 javac 7m 29s The applied patch generated 186 additional warning messages. +1 javadoc 9m 30s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 17s The applied patch generated 117 new checkstyle issues (total was 447, now 558). -1 whitespace 0m 12s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 2m 20s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 23m 5s Tests passed in hadoop-common. +1 tools/hadoop tests 6m 9s Tests passed in hadoop-streaming.     67m 23s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731148/HADOOP-7266.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d335071 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/diffJavacWarnings.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/diffcheckstylehadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/testrun_hadoop-common.txt hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/testrun_hadoop-streaming.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/console This message was automatically generated.
        Hide
        Haohui Mai added a comment -

        It might make it only applicable for branch-2 – we can probably remove metrics v1 in trunk directly without marking them as deprecated.

        Show
        Haohui Mai added a comment - It might make it only applicable for branch-2 – we can probably remove metrics v1 in trunk directly without marking them as deprecated.
        Hide
        Luke Lu added a comment -

        Akira Ajisaka, thanks for taking this over. Changed job, have different priorities I remember that the reason v1 is still around is mostly due to the downstream projects (e.g. Hive?) needed them. I think that's no longer the case now.

        Show
        Luke Lu added a comment - Akira Ajisaka , thanks for taking this over. Changed job, have different priorities I remember that the reason v1 is still around is mostly due to the downstream projects (e.g. Hive?) needed them. I think that's no longer the case now.
        Hide
        Akira Ajisaka added a comment -

        Thanks Haohui Mai and Luke Lu for comments. Jenkins found there are some classes using metrics v1. (https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/diffJavacWarnings.txt)

        • LocalJobRunnerMetrics
        • ShuffleClientMetrics
        • LocalFetcher

        If we cannot remove them, we should fix them to use metrics v2 in this jira.

        Show
        Akira Ajisaka added a comment - Thanks Haohui Mai and Luke Lu for comments. Jenkins found there are some classes using metrics v1. ( https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/diffJavacWarnings.txt ) LocalJobRunnerMetrics ShuffleClientMetrics LocalFetcher If we cannot remove them, we should fix them to use metrics v2 in this jira.
        Hide
        Akira Ajisaka added a comment -

        edit: If we cannot remove them, we should fix them to use metrics v2 before removing metrics v1 from trunk.

        Show
        Akira Ajisaka added a comment - edit: If we cannot remove them, we should fix them to use metrics v2 before removing metrics v1 from trunk.
        Hide
        Akira Ajisaka added a comment -

        v2 patch fixes javac warnings.

        Show
        Akira Ajisaka added a comment - v2 patch fixes javac warnings.
        Hide
        Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 0s The patch command could not apply the patch during dryrun.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12735279/HADOOP-7266.002.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 56996a6
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6823/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735279/HADOOP-7266.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 56996a6 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6823/console This message was automatically generated.
        Hide
        Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 41s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
        -1 javac 7m 36s The applied patch generated 59 additional warning messages.
        +1 javadoc 9m 38s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 16s There were no new checkstyle issues.
        -1 whitespace 0m 4s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 36s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 3m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 23m 9s Tests passed in hadoop-common.
        +1 mapreduce tests 1m 35s Tests passed in hadoop-mapreduce-client-core.
        +1 tools/hadoop tests 6m 9s Tests passed in hadoop-streaming.
            71m 17s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12735287/HADOOP-7266.002.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 56996a6
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/artifact/patchprocess/diffJavacWarnings.txt
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/artifact/patchprocess/whitespace.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/artifact/patchprocess/testrun_hadoop-common.txt
        hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
        hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/artifact/patchprocess/testrun_hadoop-streaming.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/testReport/
        Java 1.7.0_55
        uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 41s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. -1 javac 7m 36s The applied patch generated 59 additional warning messages. +1 javadoc 9m 38s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 16s There were no new checkstyle issues. -1 whitespace 0m 4s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 3m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 9s Tests passed in hadoop-common. +1 mapreduce tests 1m 35s Tests passed in hadoop-mapreduce-client-core. +1 tools/hadoop tests 6m 9s Tests passed in hadoop-streaming.     71m 17s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735287/HADOOP-7266.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 56996a6 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/artifact/patchprocess/diffJavacWarnings.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/artifact/patchprocess/testrun_hadoop-common.txt hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/artifact/patchprocess/testrun_hadoop-streaming.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/console This message was automatically generated.
        Hide
        Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 39s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
        -1 javac 7m 36s The applied patch generated 58 additional warning messages.
        +1 javadoc 9m 36s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 19s There were no new checkstyle issues.
        -1 whitespace 0m 5s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 23m 21s Tests passed in hadoop-common.
        +1 mapreduce tests 1m 36s Tests passed in hadoop-mapreduce-client-core.
        +1 tools/hadoop tests 6m 8s Tests passed in hadoop-streaming.
            71m 33s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12735846/HADOOP-7266.003.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 7e509f5
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/artifact/patchprocess/diffJavacWarnings.txt
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/artifact/patchprocess/whitespace.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/artifact/patchprocess/testrun_hadoop-common.txt
        hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
        hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/artifact/patchprocess/testrun_hadoop-streaming.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 39s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. -1 javac 7m 36s The applied patch generated 58 additional warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 19s There were no new checkstyle issues. -1 whitespace 0m 5s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 21s Tests passed in hadoop-common. +1 mapreduce tests 1m 36s Tests passed in hadoop-mapreduce-client-core. +1 tools/hadoop tests 6m 8s Tests passed in hadoop-streaming.     71m 33s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735846/HADOOP-7266.003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7e509f5 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/artifact/patchprocess/diffJavacWarnings.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/artifact/patchprocess/testrun_hadoop-common.txt hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/artifact/patchprocess/testrun_hadoop-streaming.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/console This message was automatically generated.
        Hide
        Akira Ajisaka added a comment -

        The applied patch generated 58 additional warning messages.

        The warnings are caused by import sentences. @SuppressWarnings("deprecation") is not effective for them. We can suppress the warnings by using fully qualified class instead of importing them, however, that's worthless for me.

        Show
        Akira Ajisaka added a comment - The applied patch generated 58 additional warning messages. The warnings are caused by import sentences. @SuppressWarnings("deprecation") is not effective for them. We can suppress the warnings by using fully qualified class instead of importing them, however, that's worthless for me.
        Hide
        Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 32s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
        -1 javac 7m 32s The applied patch generated 58 additional warning messages.
        +1 javadoc 9m 35s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 17s There were no new checkstyle issues.
        -1 whitespace 0m 4s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 38s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 4m 2s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 common tests 22m 33s Tests failed in hadoop-common.
        +1 mapreduce tests 1m 36s Tests passed in hadoop-mapreduce-client-core.
        +1 tools/hadoop tests 6m 9s Tests passed in hadoop-streaming.
            74m 58s  



        Reason Tests
        Failed unit tests hadoop.security.token.delegation.web.TestWebDelegationToken



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12736017/HADOOP-7266.004.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 788bfa0
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/artifact/patchprocess/diffJavacWarnings.txt
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/artifact/patchprocess/whitespace.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/artifact/patchprocess/testrun_hadoop-common.txt
        hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
        hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/artifact/patchprocess/testrun_hadoop-streaming.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 32s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. -1 javac 7m 32s The applied patch generated 58 additional warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 17s There were no new checkstyle issues. -1 whitespace 0m 4s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 4m 2s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 22m 33s Tests failed in hadoop-common. +1 mapreduce tests 1m 36s Tests passed in hadoop-mapreduce-client-core. +1 tools/hadoop tests 6m 9s Tests passed in hadoop-streaming.     74m 58s   Reason Tests Failed unit tests hadoop.security.token.delegation.web.TestWebDelegationToken Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12736017/HADOOP-7266.004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 788bfa0 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/artifact/patchprocess/diffJavacWarnings.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/artifact/patchprocess/testrun_hadoop-common.txt hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/artifact/patchprocess/testrun_hadoop-streaming.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/console This message was automatically generated.
        Hide
        Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 34s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
        -1 javac 7m 35s The applied patch generated 58 additional warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 14s There were no new checkstyle issues.
        -1 whitespace 0m 7s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 22s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 4m 1s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 22m 29s Tests passed in hadoop-common.
        +1 mapreduce tests 1m 44s Tests passed in hadoop-mapreduce-client-core.
        +1 tools/hadoop tests 6m 12s Tests passed in hadoop-streaming.
            74m 55s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12736017/HADOOP-7266.004.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 1df7868
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/artifact/patchprocess/diffJavacWarnings.txt
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/artifact/patchprocess/whitespace.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/artifact/patchprocess/testrun_hadoop-common.txt
        hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
        hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/artifact/patchprocess/testrun_hadoop-streaming.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 34s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. -1 javac 7m 35s The applied patch generated 58 additional warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 14s There were no new checkstyle issues. -1 whitespace 0m 7s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 22s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 1s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 29s Tests passed in hadoop-common. +1 mapreduce tests 1m 44s Tests passed in hadoop-mapreduce-client-core. +1 tools/hadoop tests 6m 12s Tests passed in hadoop-streaming.     74m 55s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12736017/HADOOP-7266.004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1df7868 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/artifact/patchprocess/diffJavacWarnings.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/artifact/patchprocess/testrun_hadoop-common.txt hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/artifact/patchprocess/testrun_hadoop-streaming.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/console This message was automatically generated.
        Hide
        Akira Ajisaka added a comment -

        As I said, the javac warnings are inevitable. The patch is ready for review.

        Show
        Akira Ajisaka added a comment - As I said , the javac warnings are inevitable. The patch is ready for review.
        Hide
        Akira Ajisaka added a comment -

        FYI: According to JEP-211, JDK9 will not issue deprecation warnings for import statements. Therefore I'm thinking we can ignore the warnings.

        Show
        Akira Ajisaka added a comment - FYI: According to JEP-211 , JDK9 will not issue deprecation warnings for import statements. Therefore I'm thinking we can ignore the warnings.
        Hide
        Akira Ajisaka added a comment -

        Sample patch for removing metrics v1. I'd like to start removing metrics v1 after deprecating it.

        Show
        Akira Ajisaka added a comment - Sample patch for removing metrics v1. I'd like to start removing metrics v1 after deprecating it.
        Hide
        Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 19m 34s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
        +1 javac 7m 45s There were no new javac warning messages.
        +1 javadoc 10m 9s There were no new javadoc warning messages.
        +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 2m 31s The applied patch generated 2 new checkstyle issues (total was 16, now 18).
        -1 whitespace 0m 4s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 29s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 4m 23s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 common tests 7m 35s Tests failed in hadoop-common.
        +1 mapreduce tests 0m 48s Tests passed in hadoop-mapreduce-client-common.
        +1 mapreduce tests 1m 46s Tests passed in hadoop-mapreduce-client-core.
            57m 7s  



        Reason Tests
        Failed unit tests hadoop.http.TestHttpServer
          hadoop.metrics2.impl.TestGangliaMetrics
          hadoop.fs.shell.TestCopyPreserveFlag



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12767202/HADOOP-7266-remove.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 58590fe
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7838/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-core.txt
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7838/artifact/patchprocess/whitespace.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7838/artifact/patchprocess/testrun_hadoop-common.txt
        hadoop-mapreduce-client-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7838/artifact/patchprocess/testrun_hadoop-mapreduce-client-common.txt
        hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7838/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7838/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7838/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 34s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. +1 javac 7m 45s There were no new javac warning messages. +1 javadoc 10m 9s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 31s The applied patch generated 2 new checkstyle issues (total was 16, now 18). -1 whitespace 0m 4s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 29s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 23s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 7m 35s Tests failed in hadoop-common. +1 mapreduce tests 0m 48s Tests passed in hadoop-mapreduce-client-common. +1 mapreduce tests 1m 46s Tests passed in hadoop-mapreduce-client-core.     57m 7s   Reason Tests Failed unit tests hadoop.http.TestHttpServer   hadoop.metrics2.impl.TestGangliaMetrics   hadoop.fs.shell.TestCopyPreserveFlag Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767202/HADOOP-7266-remove.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 58590fe checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7838/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-core.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7838/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7838/artifact/patchprocess/testrun_hadoop-common.txt hadoop-mapreduce-client-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7838/artifact/patchprocess/testrun_hadoop-mapreduce-client-common.txt hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7838/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7838/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7838/console This message was automatically generated.
        Hide
        Tsuyoshi Ozawa added a comment -

        Akira Ajisaka thank you for taking this issue.

        +@Deprecated
        +@SuppressWarnings("deprecation")

        I thought we should mark this as just deprecated and no need to suppress warnings. Could you clarify the reason why we need to mark suppress warnings here?

        Show
        Tsuyoshi Ozawa added a comment - Akira Ajisaka thank you for taking this issue. +@Deprecated +@SuppressWarnings("deprecation") I thought we should mark this as just deprecated and no need to suppress warnings. Could you clarify the reason why we need to mark suppress warnings here?
        Hide
        Akira Ajisaka added a comment -

        For example, we need to add @SuppressWarnings to GangliaContext to suppress warning for extending deprecated class.

        @Deprecated
        @SuppressWarnings("deprecation")
        @InterfaceAudience.Public
        @InterfaceStability.Evolving
        public class GangliaContext extends AbstractMetricsContext {
        

        I suppressed warnings only for reducing javac warnings as possible. I have no other reason to do that.

        Show
        Akira Ajisaka added a comment - For example, we need to add @SuppressWarnings to GangliaContext to suppress warning for extending deprecated class. @Deprecated @SuppressWarnings( "deprecation" ) @InterfaceAudience.Public @InterfaceStability.Evolving public class GangliaContext extends AbstractMetricsContext { I suppressed warnings only for reducing javac warnings as possible. I have no other reason to do that.
        Hide
        Akira Ajisaka added a comment -

        05 patch: Removed useless @SuppressWarnings

        Show
        Akira Ajisaka added a comment - 05 patch: Removed useless @SuppressWarnings
        Hide
        Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        +1 mvninstall 8m 51s trunk passed
        +1 compile 4m 38s trunk passed with JDK v1.8.0
        +1 compile 4m 18s trunk passed with JDK v1.7.0_79
        +1 checkstyle 1m 12s trunk passed
        +1 mvneclipse 0m 45s trunk passed
        +1 findbugs 4m 7s trunk passed
        +1 javadoc 2m 2s trunk passed with JDK v1.8.0
        +1 javadoc 1m 58s trunk passed with JDK v1.7.0_79
        +1 mvninstall 1m 35s the patch passed
        +1 compile 5m 25s the patch passed with JDK v1.8.0
        +1 javac 5m 25s the patch passed
        +1 compile 4m 12s the patch passed with JDK v1.7.0_79
        +1 javac 4m 12s the patch passed
        +1 checkstyle 1m 2s the patch passed
        +1 mvneclipse 0m 40s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 4m 4s the patch passed
        +1 javadoc 1m 43s the patch passed with JDK v1.8.0
        +1 javadoc 1m 46s the patch passed with JDK v1.7.0_79
        +1 unit 22m 2s hadoop-common in the patch passed with JDK v1.8.0.
        +1 unit 1m 36s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0.
        +1 unit 6m 30s hadoop-streaming in the patch passed with JDK v1.8.0.
        -1 unit 24m 11s hadoop-common in the patch failed with JDK v1.7.0_79.
        +1 unit 1m 54s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_79.
        +1 unit 6m 29s hadoop-streaming in the patch passed with JDK v1.7.0_79.
        -1 asflicense 0m 21s Patch generated 1 ASF License warnings.
        113m 10s



        Reason Tests
        JDK v1.7.0_79 Failed junit tests hadoop.metrics2.impl.TestMetricsSystemImpl



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767244/HADOOP-7266.005.patch
        JIRA Issue HADOOP-7266
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-ef9723d/dev-support/personality/hadoop.sh
        git revision trunk / 58590fe
        Default Java 1.7.0_79
        Multi-JDK versions /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7858/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7858/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7858/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7858/artifact/patchprocess/patch-asflicense-problems.txt
        Max memory used 266MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7858/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 8m 51s trunk passed +1 compile 4m 38s trunk passed with JDK v1.8.0 +1 compile 4m 18s trunk passed with JDK v1.7.0_79 +1 checkstyle 1m 12s trunk passed +1 mvneclipse 0m 45s trunk passed +1 findbugs 4m 7s trunk passed +1 javadoc 2m 2s trunk passed with JDK v1.8.0 +1 javadoc 1m 58s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 35s the patch passed +1 compile 5m 25s the patch passed with JDK v1.8.0 +1 javac 5m 25s the patch passed +1 compile 4m 12s the patch passed with JDK v1.7.0_79 +1 javac 4m 12s the patch passed +1 checkstyle 1m 2s the patch passed +1 mvneclipse 0m 40s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 4s the patch passed +1 javadoc 1m 43s the patch passed with JDK v1.8.0 +1 javadoc 1m 46s the patch passed with JDK v1.7.0_79 +1 unit 22m 2s hadoop-common in the patch passed with JDK v1.8.0. +1 unit 1m 36s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0. +1 unit 6m 30s hadoop-streaming in the patch passed with JDK v1.8.0. -1 unit 24m 11s hadoop-common in the patch failed with JDK v1.7.0_79. +1 unit 1m 54s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_79. +1 unit 6m 29s hadoop-streaming in the patch passed with JDK v1.7.0_79. -1 asflicense 0m 21s Patch generated 1 ASF License warnings. 113m 10s Reason Tests JDK v1.7.0_79 Failed junit tests hadoop.metrics2.impl.TestMetricsSystemImpl Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767244/HADOOP-7266.005.patch JIRA Issue HADOOP-7266 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-ef9723d/dev-support/personality/hadoop.sh git revision trunk / 58590fe Default Java 1.7.0_79 Multi-JDK versions /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7858/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7858/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7858/testReport/ asflicense https://builds.apache.org/job/PreCommit-HADOOP-Build/7858/artifact/patchprocess/patch-asflicense-problems.txt Max memory used 266MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7858/console This message was automatically generated.
        Hide
        Tsuyoshi Ozawa added a comment -

        I see. Should we also remove SuppressWarning annotation for fields and caller of deprecated methods? IMHO, the javac warnings added by the patch helps us to fix them on following JIRAs. What do you think?

        Show
        Tsuyoshi Ozawa added a comment - I see. Should we also remove SuppressWarning annotation for fields and caller of deprecated methods? IMHO, the javac warnings added by the patch helps us to fix them on following JIRAs. What do you think?
        Hide
        Akira Ajisaka added a comment -

        I don't think it's good idea to commit a patch that adds warnings and then commit another patch that fixes the warnings. I'd like to keep the source code clean in any revision.

        If we are to add warnings in this issue, we will

        • deprecate metrics1 and then remove metrics1 in trunk,
        • deprecate metrics1 and then fix javac warnings in branch-2.

        I'm thinking it is simpler to

        • deprecate metrics1 and then remove metrics1 in trunk,
        • deprecate metrics1 in branch-2.
        Show
        Akira Ajisaka added a comment - I don't think it's good idea to commit a patch that adds warnings and then commit another patch that fixes the warnings. I'd like to keep the source code clean in any revision. If we are to add warnings in this issue, we will deprecate metrics1 and then remove metrics1 in trunk, deprecate metrics1 and then fix javac warnings in branch-2. I'm thinking it is simpler to deprecate metrics1 and then remove metrics1 in trunk, deprecate metrics1 in branch-2.
        Hide
        Tsuyoshi Ozawa added a comment -

        I don't think it's good idea to commit a patch that adds warnings and then commit another patch that fixes the warnings. I'd like to keep the source code clean in any revision.

        I think we cannot say it's clean code by fixing warnings with SuppressWarning annotation, unfortunately It's just a workaround to make a illusion of clean code.

        If we are to add warnings in this issue, we will

        • deprecate metrics1 and then remove metrics1 in trunk
        • deprecate metrics1 and then fix javac warnings in branch-2

        To make the code clean in this case, we need to replace them with metrics v2 code. For instance, MetricsServles shoulld be moved under metrics 2 directory and HttpServer2 code should use it. Do you mean we should do this on this issue? It sounds good, but the patch is not enough.
        I also thought some projects use metrics v1. They need grace period to replace them - some libraries, like Guava, removes useless methods after annotating @Deprecated during a limited time. This is a good mark not only for us, but also for users. This policy is good culture of Guava and we can imitate it. Thoughts?

        http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/io/InputSupplier.html

        Show
        Tsuyoshi Ozawa added a comment - I don't think it's good idea to commit a patch that adds warnings and then commit another patch that fixes the warnings. I'd like to keep the source code clean in any revision. I think we cannot say it's clean code by fixing warnings with SuppressWarning annotation, unfortunately It's just a workaround to make a illusion of clean code. If we are to add warnings in this issue, we will deprecate metrics1 and then remove metrics1 in trunk deprecate metrics1 and then fix javac warnings in branch-2 To make the code clean in this case, we need to replace them with metrics v2 code. For instance, MetricsServles shoulld be moved under metrics 2 directory and HttpServer2 code should use it. Do you mean we should do this on this issue? It sounds good, but the patch is not enough. I also thought some projects use metrics v1. They need grace period to replace them - some libraries, like Guava, removes useless methods after annotating @Deprecated during a limited time. This is a good mark not only for us, but also for users. This policy is good culture of Guava and we can imitate it. Thoughts? http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/io/InputSupplier.html
        Hide
        Allen Wittenauer added a comment -

        They need grace period to replace them

        The grace period as dictated by Hadoop's compatibility guidelines is technically deprecate in branch-2, remove in a later release. Given that trunk has been sitting there without a release for five years (or is it six now?), there are likely to be a lot of things that are going to surprise developers. I don't see any particular reason why this shouldn't be amongst the list. Because let's be honest: now that the vendors control Hadoop's future, it's going to be another five years before we see Hadoop 4.x. Let's take this opportunity to remove all the cruft the community can.

        Show
        Allen Wittenauer added a comment - They need grace period to replace them The grace period as dictated by Hadoop's compatibility guidelines is technically deprecate in branch-2, remove in a later release. Given that trunk has been sitting there without a release for five years (or is it six now?), there are likely to be a lot of things that are going to surprise developers. I don't see any particular reason why this shouldn't be amongst the list. Because let's be honest: now that the vendors control Hadoop's future, it's going to be another five years before we see Hadoop 4.x. Let's take this opportunity to remove all the cruft the community can.
        Hide
        Tsuyoshi Ozawa added a comment -

        Yeah, I agree with removing metrics v1 from trunk. On branch-2, I think we should fix to use metrics v2 instead of v1 code. This can be enough grace period as you mentioned.

        On this jira, should we focus on removing metrics v1 on trunk or marking metrics v1 as deprecated?

        Show
        Tsuyoshi Ozawa added a comment - Yeah, I agree with removing metrics v1 from trunk. On branch-2, I think we should fix to use metrics v2 instead of v1 code. This can be enough grace period as you mentioned. On this jira, should we focus on removing metrics v1 on trunk or marking metrics v1 as deprecated?
        Hide
        Akira Ajisaka added a comment -

        I think we cannot say it's clean code by fixing warnings with SuppressWarning annotation, unfortunately It's just a workaround to make a illusion of clean code.

        Agree.

        To make the code clean in this case, we need to replace them with metrics v2 code.

        If we are to replace metrics1 code with metrics2, old configuration for ShuffleClientMetrics and LocalJobRunnerMetrics will not work.

        Show
        Akira Ajisaka added a comment - I think we cannot say it's clean code by fixing warnings with SuppressWarning annotation, unfortunately It's just a workaround to make a illusion of clean code. Agree. To make the code clean in this case, we need to replace them with metrics v2 code. If we are to replace metrics1 code with metrics2, old configuration for ShuffleClientMetrics and LocalJobRunnerMetrics will not work.
        Hide
        Tsuyoshi Ozawa added a comment -

        If we are to replace metrics1 code with metrics2, old configuration for ShuffleClientMetrics and LocalJobRunnerMetrics will not work.

        How about creating subtasks to migrating these code from metrics v1 to metrics v2 with compatibility?

        Show
        Tsuyoshi Ozawa added a comment - If we are to replace metrics1 code with metrics2, old configuration for ShuffleClientMetrics and LocalJobRunnerMetrics will not work. How about creating subtasks to migrating these code from metrics v1 to metrics v2 with compatibility?
        Hide
        Allen Wittenauer added a comment -

        On this jira, should we focus on removing metrics v1 on trunk or marking metrics v1 as deprecated?

        The typical pattern is:

        • 1 jira to deprecate
        • 1 jira to remove

        So these are two separate steps since the patches are effectively different.

        If we are to replace metrics1 code with metrics2, old configuration for ShuffleClientMetrics and LocalJobRunnerMetrics will not work.

        So we can't make an incompatible change in branch-2. Which means if we can't make "bridge code" that converts v1 to v2 quietly as part of this patch, we are going to knowingly add warnings to the Hadoop code base. There's nothing wrong with that so long as we do it with full knowledge of why we're adding warnings. They will not be the only ones. (and FWIW, test-patch is aware of pre-existing warnings and won't flag users on them) I think the key thing is to put a comment near the places that generate the warnings to point out that, yes, this generates warnings, but it's temporary and fixed in a later release.

        Show
        Allen Wittenauer added a comment - On this jira, should we focus on removing metrics v1 on trunk or marking metrics v1 as deprecated? The typical pattern is: 1 jira to deprecate 1 jira to remove So these are two separate steps since the patches are effectively different. If we are to replace metrics1 code with metrics2, old configuration for ShuffleClientMetrics and LocalJobRunnerMetrics will not work. So we can't make an incompatible change in branch-2. Which means if we can't make "bridge code" that converts v1 to v2 quietly as part of this patch, we are going to knowingly add warnings to the Hadoop code base. There's nothing wrong with that so long as we do it with full knowledge of why we're adding warnings. They will not be the only ones. (and FWIW, test-patch is aware of pre-existing warnings and won't flag users on them) I think the key thing is to put a comment near the places that generate the warnings to point out that, yes, this generates warnings, but it's temporary and fixed in a later release.
        Hide
        Akira Ajisaka added a comment -

        Okay, I'll deprecate metrics v1 in this jira.

        Which means if we can't make "bridge code" that converts v1 to v2 quietly as part of this patch, we are going to knowingly add warnings to the Hadoop code base. (snip) I think the key thing is to put a comment near the places that generate the warnings to point out that, yes, this generates warnings, but it's temporary and fixed in a later release.

        I prefer putting a comment rather than making "bridge code". There are many difference such as configuration file, how to configure, and the architecture itself between metrics v1 and v2. I'm thinking making "bridge code" will be very hard work but the value of the work is little. What do you think?

        Show
        Akira Ajisaka added a comment - Okay, I'll deprecate metrics v1 in this jira. Which means if we can't make "bridge code" that converts v1 to v2 quietly as part of this patch, we are going to knowingly add warnings to the Hadoop code base. (snip) I think the key thing is to put a comment near the places that generate the warnings to point out that, yes, this generates warnings, but it's temporary and fixed in a later release. I prefer putting a comment rather than making "bridge code". There are many difference such as configuration file, how to configure, and the architecture itself between metrics v1 and v2. I'm thinking making "bridge code" will be very hard work but the value of the work is little. What do you think?
        Hide
        Allen Wittenauer added a comment -

        I think you're absolutely correct in not wanting bridge code, given the (hopefully) relatively short time period in which it will exist.

        While I know we would all love pristine code, I think this is going to be one of those times where the ugliness of development is unavoidable.

        Show
        Allen Wittenauer added a comment - I think you're absolutely correct in not wanting bridge code, given the (hopefully) relatively short time period in which it will exist. While I know we would all love pristine code, I think this is going to be one of those times where the ugliness of development is unavoidable.
        Hide
        Akira Ajisaka added a comment -

        Attaching a patch to deprecate metrics v1.

        Show
        Akira Ajisaka added a comment - Attaching a patch to deprecate metrics v1.
        Hide
        Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 43s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        +1 mvninstall 10m 11s trunk passed
        +1 compile 5m 43s trunk passed with JDK v1.8.0_60
        +1 compile 5m 9s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 22s trunk passed
        +1 mvneclipse 0m 23s trunk passed
        +1 findbugs 2m 12s trunk passed
        +1 javadoc 1m 11s trunk passed with JDK v1.8.0_60
        +1 javadoc 1m 15s trunk passed with JDK v1.7.0_79
        -1 mvninstall 0m 16s hadoop-common in the patch failed.
        -1 compile 0m 23s root in the patch failed with JDK v1.8.0_60.
        -1 javac 0m 23s root in the patch failed with JDK v1.8.0_60.
        -1 compile 0m 22s root in the patch failed with JDK v1.7.0_79.
        -1 javac 0m 22s root in the patch failed with JDK v1.7.0_79.
        +1 checkstyle 0m 18s the patch passed
        +1 mvneclipse 0m 18s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        -1 findbugs 0m 17s hadoop-common in the patch failed.
        -1 javadoc 0m 17s hadoop-common in the patch failed with JDK v1.8.0_60.
        -1 javadoc 0m 17s hadoop-common in the patch failed with JDK v1.7.0_79.
        -1 unit 0m 16s hadoop-common in the patch failed with JDK v1.8.0_60.
        -1 unit 0m 15s hadoop-common in the patch failed with JDK v1.7.0_79.
        +1 asflicense 0m 30s Patch does not generate ASF License warnings.
        31m 50s



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-22
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767965/HADOOP-7266.006.patch
        JIRA Issue HADOOP-7266
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux 15375d49d022 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-28a3a3d/dev-support/personality/hadoop.sh
        git revision trunk / 381610d
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        findbugs v3.0.0
        mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt
        compile https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/artifact/patchprocess/patch-compile-root-jdk1.8.0_60.txt
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/artifact/patchprocess/patch-compile-root-jdk1.8.0_60.txt
        compile https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/artifact/patchprocess/patch-compile-root-jdk1.7.0_79.txt
        javac https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/artifact/patchprocess/patch-compile-root-jdk1.7.0_79.txt
        findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt
        javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
        javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/testReport/
        Max memory used 230MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 43s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 10m 11s trunk passed +1 compile 5m 43s trunk passed with JDK v1.8.0_60 +1 compile 5m 9s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 22s trunk passed +1 mvneclipse 0m 23s trunk passed +1 findbugs 2m 12s trunk passed +1 javadoc 1m 11s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 15s trunk passed with JDK v1.7.0_79 -1 mvninstall 0m 16s hadoop-common in the patch failed. -1 compile 0m 23s root in the patch failed with JDK v1.8.0_60. -1 javac 0m 23s root in the patch failed with JDK v1.8.0_60. -1 compile 0m 22s root in the patch failed with JDK v1.7.0_79. -1 javac 0m 22s root in the patch failed with JDK v1.7.0_79. +1 checkstyle 0m 18s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 0m 17s hadoop-common in the patch failed. -1 javadoc 0m 17s hadoop-common in the patch failed with JDK v1.8.0_60. -1 javadoc 0m 17s hadoop-common in the patch failed with JDK v1.7.0_79. -1 unit 0m 16s hadoop-common in the patch failed with JDK v1.8.0_60. -1 unit 0m 15s hadoop-common in the patch failed with JDK v1.7.0_79. +1 asflicense 0m 30s Patch does not generate ASF License warnings. 31m 50s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-22 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767965/HADOOP-7266.006.patch JIRA Issue HADOOP-7266 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 15375d49d022 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-28a3a3d/dev-support/personality/hadoop.sh git revision trunk / 381610d Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/artifact/patchprocess/patch-mvninstall-hadoop-common-project_hadoop-common.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/artifact/patchprocess/patch-compile-root-jdk1.8.0_60.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/artifact/patchprocess/patch-compile-root-jdk1.8.0_60.txt compile https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/artifact/patchprocess/patch-compile-root-jdk1.7.0_79.txt javac https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/artifact/patchprocess/patch-compile-root-jdk1.7.0_79.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/artifact/patchprocess/patch-findbugs-hadoop-common-project_hadoop-common.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt javadoc https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/artifact/patchprocess/patch-javadoc-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/testReport/ Max memory used 230MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7909/console This message was automatically generated.
        Hide
        Tsuyoshi Ozawa added a comment -

        Akira Ajisaka thank you for updating a patch. Looks good to me overall.

        The new Jenkins CI shows us that we cannot use deprecated modifier in package-info.java(Good job, Allen!). Could you fix it?

        [ERROR] /testptch/hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/package-info.java:[25,1] modifier deprecated not allowed here

        Show
        Tsuyoshi Ozawa added a comment - Akira Ajisaka thank you for updating a patch. Looks good to me overall. The new Jenkins CI shows us that we cannot use deprecated modifier in package-info.java(Good job, Allen!). Could you fix it? [ERROR] /testptch/hadoop/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/package-info.java: [25,1] modifier deprecated not allowed here
        Hide
        Akira Ajisaka added a comment -

        Thanks Tsuyoshi Ozawa for reviewing the patch. Fixed package-info.java files.

        Show
        Akira Ajisaka added a comment - Thanks Tsuyoshi Ozawa for reviewing the patch. Fixed package-info.java files.
        Hide
        Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        +1 mvninstall 3m 57s trunk passed
        +1 compile 5m 50s trunk passed with JDK v1.8.0_60
        +1 compile 5m 12s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 18s trunk passed
        +1 mvneclipse 0m 18s trunk passed
        +1 findbugs 2m 4s trunk passed
        +1 javadoc 1m 11s trunk passed with JDK v1.8.0_60
        +1 javadoc 1m 16s trunk passed with JDK v1.7.0_79
        +1 mvninstall 1m 42s the patch passed
        +1 compile 5m 35s the patch passed with JDK v1.8.0_60
        +1 javac 5m 35s the patch passed
        +1 compile 5m 16s the patch passed with JDK v1.7.0_79
        +1 javac 5m 16s the patch passed
        +1 checkstyle 0m 18s the patch passed
        +1 mvneclipse 0m 17s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 21s the patch passed
        +1 javadoc 1m 16s the patch passed with JDK v1.8.0_60
        +1 javadoc 1m 21s the patch passed with JDK v1.7.0_79
        -1 unit 8m 46s hadoop-common in the patch failed with JDK v1.8.0_60.
        -1 unit 7m 30s hadoop-common in the patch failed with JDK v1.7.0_79.
        +1 asflicense 0m 24s Patch does not generate ASF License warnings.
        56m 27s



        Reason Tests
        JDK v1.7.0_79 Failed junit tests hadoop.ipc.TestRPC
          hadoop.fs.TestLocalFsFCStatistics
          hadoop.metrics2.impl.TestGangliaMetrics
          hadoop.ipc.TestIPC
          hadoop.test.TestTimedOutTestsListener
          hadoop.metrics2.impl.TestMetricsSystemImpl
          hadoop.security.ssl.TestReloadingX509TrustManager



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-22
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767972/HADOOP-7266.007.patch
        JIRA Issue HADOOP-7266
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux cff602cb8fd2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-28a3a3d/dev-support/personality/hadoop.sh
        git revision trunk / 381610d
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7910/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7910/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7910/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/7910/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7910/testReport/
        Max memory used 227MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7910/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 3m 57s trunk passed +1 compile 5m 50s trunk passed with JDK v1.8.0_60 +1 compile 5m 12s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 18s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 2m 4s trunk passed +1 javadoc 1m 11s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 16s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 42s the patch passed +1 compile 5m 35s the patch passed with JDK v1.8.0_60 +1 javac 5m 35s the patch passed +1 compile 5m 16s the patch passed with JDK v1.7.0_79 +1 javac 5m 16s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 21s the patch passed +1 javadoc 1m 16s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 21s the patch passed with JDK v1.7.0_79 -1 unit 8m 46s hadoop-common in the patch failed with JDK v1.8.0_60. -1 unit 7m 30s hadoop-common in the patch failed with JDK v1.7.0_79. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 56m 27s Reason Tests JDK v1.7.0_79 Failed junit tests hadoop.ipc.TestRPC   hadoop.fs.TestLocalFsFCStatistics   hadoop.metrics2.impl.TestGangliaMetrics   hadoop.ipc.TestIPC   hadoop.test.TestTimedOutTestsListener   hadoop.metrics2.impl.TestMetricsSystemImpl   hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-22 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767972/HADOOP-7266.007.patch JIRA Issue HADOOP-7266 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux cff602cb8fd2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-28a3a3d/dev-support/personality/hadoop.sh git revision trunk / 381610d Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7910/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7910/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7910/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/7910/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7910/testReport/ Max memory used 227MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7910/console This message was automatically generated.
        Hide
        Akira Ajisaka added a comment -

        The test failures are not related to the patch because the patch is only to deprecate metrics v1. Would you review the latest patch, Tsuyoshi Ozawa?

        Show
        Akira Ajisaka added a comment - The test failures are not related to the patch because the patch is only to deprecate metrics v1. Would you review the latest patch, Tsuyoshi Ozawa ?
        Hide
        Tsuyoshi Ozawa added a comment -

        +1, checking this in.

        Show
        Tsuyoshi Ozawa added a comment - +1, checking this in.
        Hide
        Tsuyoshi Ozawa added a comment -

        Committed this to trunk and branch-2. Thanks Akira Ajisaka and Luke Lu for the patch and Allen Wittenauer and Haohui Mai for your reviews.

        Show
        Tsuyoshi Ozawa added a comment - Committed this to trunk and branch-2. Thanks Akira Ajisaka and Luke Lu for the patch and Allen Wittenauer and Haohui Mai for your reviews.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8694 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8694/)
        HADOOP-7266. Deprecate metrics v1. Contributed by Akira AJISAKA. (ozawa: rev 35a303dfbe348f96c465fb8778ced6b5bb617e89)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/EventCounter.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsException.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/AbstractMetricsContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricValue.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingInt.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsRegistry.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/TestMetricsServlet.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsRecord.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricsRecordImpl.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/JvmMetrics.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsIntValue.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/Util.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ContextFactory.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/OutputRecord.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContextWithUpdateThread.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NoEmitMetricsContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsLongValue.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MBeanUtil.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsBase.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingLong.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/spi/TestOutputRecord.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/ganglia/TestGangliaContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext31.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsServlet.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/CompositeContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsUtil.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/Updater.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8694 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8694/ ) HADOOP-7266 . Deprecate metrics v1. Contributed by Akira AJISAKA. (ozawa: rev 35a303dfbe348f96c465fb8778ced6b5bb617e89) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/EventCounter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsException.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/AbstractMetricsContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricValue.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingInt.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsRegistry.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/TestMetricsServlet.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsRecord.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricsRecordImpl.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/JvmMetrics.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsIntValue.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/Util.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ContextFactory.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/OutputRecord.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContextWithUpdateThread.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NoEmitMetricsContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsLongValue.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MBeanUtil.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsBase.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingLong.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/spi/TestOutputRecord.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/ganglia/TestGangliaContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext31.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsServlet.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/CompositeContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsUtil.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/Updater.java
        Hide
        Akira Ajisaka added a comment -

        Thank you Tsuyoshi Ozawa, Allen Wittenauer and Haohui Mai for review comments!

        Show
        Akira Ajisaka added a comment - Thank you Tsuyoshi Ozawa , Allen Wittenauer and Haohui Mai for review comments!
        Hide
        Akira Ajisaka added a comment -

        Filed HADOOP-12504 for removing metrics v1 from trunk.

        Show
        Akira Ajisaka added a comment - Filed HADOOP-12504 for removing metrics v1 from trunk.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #573 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/573/)
        HADOOP-7266. Deprecate metrics v1. Contributed by Akira AJISAKA. (ozawa: rev 35a303dfbe348f96c465fb8778ced6b5bb617e89)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricsRecordImpl.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsRecord.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/CompositeContext.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/ganglia/TestGangliaContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsException.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingLong.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsBase.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MBeanUtil.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext31.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/AbstractMetricsContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsLongValue.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/Util.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingInt.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricValue.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContextWithUpdateThread.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsServlet.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/Updater.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/EventCounter.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NoEmitMetricsContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsRegistry.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/OutputRecord.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/TestMetricsServlet.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsIntValue.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsUtil.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/JvmMetrics.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/spi/TestOutputRecord.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ContextFactory.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #573 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/573/ ) HADOOP-7266 . Deprecate metrics v1. Contributed by Akira AJISAKA. (ozawa: rev 35a303dfbe348f96c465fb8778ced6b5bb617e89) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricsRecordImpl.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsRecord.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/CompositeContext.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/ganglia/TestGangliaContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsException.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingLong.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsBase.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MBeanUtil.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext31.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/AbstractMetricsContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsLongValue.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/Util.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingInt.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricValue.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContextWithUpdateThread.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsServlet.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/Updater.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/EventCounter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NoEmitMetricsContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsRegistry.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/OutputRecord.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/TestMetricsServlet.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsIntValue.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsUtil.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/JvmMetrics.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/spi/TestOutputRecord.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ContextFactory.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2519 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2519/)
        HADOOP-7266. Deprecate metrics v1. Contributed by Akira AJISAKA. (ozawa: rev 35a303dfbe348f96c465fb8778ced6b5bb617e89)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ContextFactory.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/Updater.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsRecord.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/Util.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NoEmitMetricsContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricValue.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/CompositeContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/OutputRecord.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsServlet.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContextWithUpdateThread.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingInt.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsRegistry.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext31.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MBeanUtil.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsLongValue.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsUtil.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/JvmMetrics.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsContext.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/ganglia/TestGangliaContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsIntValue.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsException.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/spi/TestOutputRecord.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/TestMetricsServlet.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingLong.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/EventCounter.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricsRecordImpl.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/AbstractMetricsContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsBase.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2519 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2519/ ) HADOOP-7266 . Deprecate metrics v1. Contributed by Akira AJISAKA. (ozawa: rev 35a303dfbe348f96c465fb8778ced6b5bb617e89) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ContextFactory.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/Updater.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsRecord.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/Util.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NoEmitMetricsContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricValue.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/CompositeContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/OutputRecord.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsServlet.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContextWithUpdateThread.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingInt.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsRegistry.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext31.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MBeanUtil.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsLongValue.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsUtil.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/JvmMetrics.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsContext.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/ganglia/TestGangliaContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsIntValue.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsException.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/spi/TestOutputRecord.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/TestMetricsServlet.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingLong.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/EventCounter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricsRecordImpl.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/AbstractMetricsContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsBase.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1309 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1309/)
        HADOOP-7266. Deprecate metrics v1. Contributed by Akira AJISAKA. (ozawa: rev 35a303dfbe348f96c465fb8778ced6b5bb617e89)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsException.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContextWithUpdateThread.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsServlet.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsUtil.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MBeanUtil.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/ganglia/TestGangliaContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingInt.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ContextFactory.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsBase.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/AbstractMetricsContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/EventCounter.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/Updater.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/CompositeContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsRegistry.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsIntValue.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricValue.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext31.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsRecord.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NoEmitMetricsContext.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/spi/TestOutputRecord.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingLong.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricsRecordImpl.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/JvmMetrics.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/OutputRecord.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/TestMetricsServlet.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/Util.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsLongValue.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContext.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1309 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1309/ ) HADOOP-7266 . Deprecate metrics v1. Contributed by Akira AJISAKA. (ozawa: rev 35a303dfbe348f96c465fb8778ced6b5bb617e89) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsException.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContextWithUpdateThread.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsServlet.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsUtil.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MBeanUtil.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/ganglia/TestGangliaContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingInt.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ContextFactory.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsBase.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/AbstractMetricsContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/EventCounter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/Updater.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/CompositeContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsRegistry.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsIntValue.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricValue.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext31.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsRecord.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NoEmitMetricsContext.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/spi/TestOutputRecord.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingLong.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricsRecordImpl.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/JvmMetrics.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/OutputRecord.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/TestMetricsServlet.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/Util.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsLongValue.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContext.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #587 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/587/)
        HADOOP-7266. Deprecate metrics v1. Contributed by Akira AJISAKA. (ozawa: rev 35a303dfbe348f96c465fb8778ced6b5bb617e89)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricsRecordImpl.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/OutputRecord.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MBeanUtil.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext31.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsIntValue.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsLongValue.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/Util.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/ganglia/TestGangliaContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContextWithUpdateThread.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingInt.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/CompositeContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/JvmMetrics.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingLong.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ContextFactory.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NoEmitMetricsContext.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/TestMetricsServlet.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsServlet.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricValue.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsUtil.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsRecord.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/EventCounter.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/AbstractMetricsContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/Updater.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/spi/TestOutputRecord.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsRegistry.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsBase.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsException.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #587 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/587/ ) HADOOP-7266 . Deprecate metrics v1. Contributed by Akira AJISAKA. (ozawa: rev 35a303dfbe348f96c465fb8778ced6b5bb617e89) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricsRecordImpl.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/OutputRecord.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MBeanUtil.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext31.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsIntValue.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsLongValue.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/Util.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/ganglia/TestGangliaContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContextWithUpdateThread.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingInt.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/CompositeContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/JvmMetrics.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingLong.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ContextFactory.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NoEmitMetricsContext.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/TestMetricsServlet.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsServlet.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricValue.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsUtil.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsRecord.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/EventCounter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/AbstractMetricsContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/Updater.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/spi/TestOutputRecord.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsRegistry.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsBase.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsException.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #530 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/530/)
        HADOOP-7266. Deprecate metrics v1. Contributed by Akira AJISAKA. (ozawa: rev 35a303dfbe348f96c465fb8778ced6b5bb617e89)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsBase.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingInt.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsServlet.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsUtil.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/Updater.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricsRecordImpl.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsRegistry.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsException.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/JvmMetrics.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NoEmitMetricsContext.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/ganglia/TestGangliaContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/CompositeContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MBeanUtil.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ContextFactory.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/AbstractMetricsContext.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/TestMetricsServlet.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContextWithUpdateThread.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/spi/TestOutputRecord.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsRecord.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/EventCounter.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/Util.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext31.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/OutputRecord.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsIntValue.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricValue.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsLongValue.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingLong.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #530 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/530/ ) HADOOP-7266 . Deprecate metrics v1. Contributed by Akira AJISAKA. (ozawa: rev 35a303dfbe348f96c465fb8778ced6b5bb617e89) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsBase.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingInt.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsServlet.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsUtil.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/Updater.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricsRecordImpl.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsRegistry.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsException.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/JvmMetrics.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NoEmitMetricsContext.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/ganglia/TestGangliaContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/CompositeContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MBeanUtil.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ContextFactory.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/AbstractMetricsContext.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/TestMetricsServlet.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContextWithUpdateThread.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/spi/TestOutputRecord.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsRecord.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/EventCounter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/Util.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext31.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/OutputRecord.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsIntValue.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricValue.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsLongValue.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingLong.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2466 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2466/)
        HADOOP-7266. Deprecate metrics v1. Contributed by Akira AJISAKA. (ozawa: rev 35a303dfbe348f96c465fb8778ced6b5bb617e89)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsRecord.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/Util.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingLong.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsUtil.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/ganglia/TestGangliaContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsLongValue.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/TestMetricsServlet.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/Updater.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingInt.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsServlet.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsRegistry.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext31.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/JvmMetrics.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/EventCounter.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsException.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MBeanUtil.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/CompositeContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContextWithUpdateThread.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NoEmitMetricsContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsIntValue.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/AbstractMetricsContext.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ContextFactory.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/OutputRecord.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsBase.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricsRecordImpl.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricValue.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContext.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/spi/TestOutputRecord.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsContext.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2466 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2466/ ) HADOOP-7266 . Deprecate metrics v1. Contributed by Akira AJISAKA. (ozawa: rev 35a303dfbe348f96c465fb8778ced6b5bb617e89) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsRecord.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/Util.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingLong.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsUtil.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/ganglia/TestGangliaContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsLongValue.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/TestMetricsServlet.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/Updater.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingInt.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsServlet.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsRegistry.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext31.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/JvmMetrics.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/jvm/EventCounter.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsException.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MBeanUtil.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsTimeVaryingRate.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/CompositeContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContextWithUpdateThread.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NoEmitMetricsContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsDynamicMBeanBase.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsIntValue.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/AbstractMetricsContext.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ContextFactory.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/OutputRecord.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/util/MetricsBase.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricsRecordImpl.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/MetricValue.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/spi/NullContext.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics/spi/TestOutputRecord.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/MetricsContext.java

          People

          • Assignee:
            Akira Ajisaka
            Reporter:
            Luke Lu
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development