Details

    • Type: Improvement Improvement
    • Status: Patch Available
    • Priority: Blocker Blocker
    • Resolution: Unresolved
    • Affects Version/s: 2.8.0
    • Fix Version/s: None
    • Component/s: metrics
    • Labels:
      None
    • Target Version/s:
    1. HADOOP-7266.004.patch
      40 kB
      Akira AJISAKA
    2. HADOOP-7266.003.patch
      42 kB
      Akira AJISAKA
    3. HADOOP-7266.002.patch
      41 kB
      Akira AJISAKA
    4. HADOOP-7266.001.patch
      40 kB
      Akira AJISAKA

      Activity

      Hide
      Akira AJISAKA added a comment -

      FYI: According to JEP-211, JDK9 will not issue deprecation warnings for import statements. Therefore I'm thinking we can ignore the warnings.

      Show
      Akira AJISAKA added a comment - FYI: According to JEP-211 , JDK9 will not issue deprecation warnings for import statements. Therefore I'm thinking we can ignore the warnings.
      Hide
      Akira AJISAKA added a comment -

      As I said, the javac warnings are inevitable. The patch is ready for review.

      Show
      Akira AJISAKA added a comment - As I said , the javac warnings are inevitable. The patch is ready for review.
      Hide
      Hadoop QA added a comment -



      -1 overall



      Vote Subsystem Runtime Comment
      0 pre-patch 18m 34s Pre-patch trunk compilation is healthy.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
      -1 javac 7m 35s The applied patch generated 58 additional warning messages.
      +1 javadoc 9m 37s There were no new javadoc warning messages.
      +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
      +1 checkstyle 2m 14s There were no new checkstyle issues.
      -1 whitespace 0m 7s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
      +1 install 1m 22s mvn install still works.
      +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
      +1 findbugs 4m 1s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
      +1 common tests 22m 29s Tests passed in hadoop-common.
      +1 mapreduce tests 1m 44s Tests passed in hadoop-mapreduce-client-core.
      +1 tools/hadoop tests 6m 12s Tests passed in hadoop-streaming.
          74m 55s  



      Subsystem Report/Notes
      Patch URL http://issues.apache.org/jira/secure/attachment/12736017/HADOOP-7266.004.patch
      Optional Tests javadoc javac unit findbugs checkstyle
      git revision trunk / 1df7868
      javac https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/artifact/patchprocess/diffJavacWarnings.txt
      whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/artifact/patchprocess/whitespace.txt
      hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/artifact/patchprocess/testrun_hadoop-common.txt
      hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
      hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/artifact/patchprocess/testrun_hadoop-streaming.txt
      Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/testReport/
      Java 1.7.0_55
      uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/console

      This message was automatically generated.

      Show
      Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 34s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. -1 javac 7m 35s The applied patch generated 58 additional warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 14s There were no new checkstyle issues. -1 whitespace 0m 7s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 22s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 1s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 29s Tests passed in hadoop-common. +1 mapreduce tests 1m 44s Tests passed in hadoop-mapreduce-client-core. +1 tools/hadoop tests 6m 12s Tests passed in hadoop-streaming.     74m 55s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12736017/HADOOP-7266.004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1df7868 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/artifact/patchprocess/diffJavacWarnings.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/artifact/patchprocess/testrun_hadoop-common.txt hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/artifact/patchprocess/testrun_hadoop-streaming.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7343/console This message was automatically generated.
      Hide
      Hadoop QA added a comment -



      -1 overall



      Vote Subsystem Runtime Comment
      0 pre-patch 18m 32s Pre-patch trunk compilation is healthy.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
      -1 javac 7m 32s The applied patch generated 58 additional warning messages.
      +1 javadoc 9m 35s There were no new javadoc warning messages.
      +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
      +1 checkstyle 2m 17s There were no new checkstyle issues.
      -1 whitespace 0m 4s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
      +1 install 1m 38s mvn install still works.
      +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
      +1 findbugs 4m 2s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
      -1 common tests 22m 33s Tests failed in hadoop-common.
      +1 mapreduce tests 1m 36s Tests passed in hadoop-mapreduce-client-core.
      +1 tools/hadoop tests 6m 9s Tests passed in hadoop-streaming.
          74m 58s  



      Reason Tests
      Failed unit tests hadoop.security.token.delegation.web.TestWebDelegationToken



      Subsystem Report/Notes
      Patch URL http://issues.apache.org/jira/secure/attachment/12736017/HADOOP-7266.004.patch
      Optional Tests javadoc javac unit findbugs checkstyle
      git revision trunk / 788bfa0
      javac https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/artifact/patchprocess/diffJavacWarnings.txt
      whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/artifact/patchprocess/whitespace.txt
      hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/artifact/patchprocess/testrun_hadoop-common.txt
      hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
      hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/artifact/patchprocess/testrun_hadoop-streaming.txt
      Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/testReport/
      Java 1.7.0_55
      uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/console

      This message was automatically generated.

      Show
      Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 32s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. -1 javac 7m 32s The applied patch generated 58 additional warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 17s There were no new checkstyle issues. -1 whitespace 0m 4s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 4m 2s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 22m 33s Tests failed in hadoop-common. +1 mapreduce tests 1m 36s Tests passed in hadoop-mapreduce-client-core. +1 tools/hadoop tests 6m 9s Tests passed in hadoop-streaming.     74m 58s   Reason Tests Failed unit tests hadoop.security.token.delegation.web.TestWebDelegationToken Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12736017/HADOOP-7266.004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 788bfa0 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/artifact/patchprocess/diffJavacWarnings.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/artifact/patchprocess/testrun_hadoop-common.txt hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/artifact/patchprocess/testrun_hadoop-streaming.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6863/console This message was automatically generated.
      Hide
      Akira AJISAKA added a comment -

      The applied patch generated 58 additional warning messages.

      The warnings are caused by import sentences. @SuppressWarnings("deprecation") is not effective for them. We can suppress the warnings by using fully qualified class instead of importing them, however, that's worthless for me.

      Show
      Akira AJISAKA added a comment - The applied patch generated 58 additional warning messages. The warnings are caused by import sentences. @SuppressWarnings("deprecation") is not effective for them. We can suppress the warnings by using fully qualified class instead of importing them, however, that's worthless for me.
      Hide
      Hadoop QA added a comment -



      -1 overall



      Vote Subsystem Runtime Comment
      0 pre-patch 14m 39s Pre-patch trunk compilation is healthy.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
      -1 javac 7m 36s The applied patch generated 58 additional warning messages.
      +1 javadoc 9m 36s There were no new javadoc warning messages.
      +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
      +1 checkstyle 2m 19s There were no new checkstyle issues.
      -1 whitespace 0m 5s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
      +1 install 1m 35s mvn install still works.
      +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
      +1 findbugs 3m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
      +1 common tests 23m 21s Tests passed in hadoop-common.
      +1 mapreduce tests 1m 36s Tests passed in hadoop-mapreduce-client-core.
      +1 tools/hadoop tests 6m 8s Tests passed in hadoop-streaming.
          71m 33s  



      Subsystem Report/Notes
      Patch URL http://issues.apache.org/jira/secure/attachment/12735846/HADOOP-7266.003.patch
      Optional Tests javadoc javac unit findbugs checkstyle
      git revision trunk / 7e509f5
      javac https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/artifact/patchprocess/diffJavacWarnings.txt
      whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/artifact/patchprocess/whitespace.txt
      hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/artifact/patchprocess/testrun_hadoop-common.txt
      hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
      hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/artifact/patchprocess/testrun_hadoop-streaming.txt
      Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/testReport/
      Java 1.7.0_55
      uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/console

      This message was automatically generated.

      Show
      Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 39s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. -1 javac 7m 36s The applied patch generated 58 additional warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 19s There were no new checkstyle issues. -1 whitespace 0m 5s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 21s Tests passed in hadoop-common. +1 mapreduce tests 1m 36s Tests passed in hadoop-mapreduce-client-core. +1 tools/hadoop tests 6m 8s Tests passed in hadoop-streaming.     71m 33s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735846/HADOOP-7266.003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 7e509f5 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/artifact/patchprocess/diffJavacWarnings.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/artifact/patchprocess/testrun_hadoop-common.txt hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/artifact/patchprocess/testrun_hadoop-streaming.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6855/console This message was automatically generated.
      Hide
      Hadoop QA added a comment -



      -1 overall



      Vote Subsystem Runtime Comment
      0 pre-patch 14m 41s Pre-patch trunk compilation is healthy.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
      -1 javac 7m 36s The applied patch generated 59 additional warning messages.
      +1 javadoc 9m 38s There were no new javadoc warning messages.
      +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
      +1 checkstyle 2m 16s There were no new checkstyle issues.
      -1 whitespace 0m 4s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
      +1 install 1m 36s mvn install still works.
      +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
      +1 findbugs 3m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
      +1 common tests 23m 9s Tests passed in hadoop-common.
      +1 mapreduce tests 1m 35s Tests passed in hadoop-mapreduce-client-core.
      +1 tools/hadoop tests 6m 9s Tests passed in hadoop-streaming.
          71m 17s  



      Subsystem Report/Notes
      Patch URL http://issues.apache.org/jira/secure/attachment/12735287/HADOOP-7266.002.patch
      Optional Tests javadoc javac unit findbugs checkstyle
      git revision trunk / 56996a6
      javac https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/artifact/patchprocess/diffJavacWarnings.txt
      whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/artifact/patchprocess/whitespace.txt
      hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/artifact/patchprocess/testrun_hadoop-common.txt
      hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
      hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/artifact/patchprocess/testrun_hadoop-streaming.txt
      Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/testReport/
      Java 1.7.0_55
      uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/console

      This message was automatically generated.

      Show
      Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 41s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. -1 javac 7m 36s The applied patch generated 59 additional warning messages. +1 javadoc 9m 38s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 16s There were no new checkstyle issues. -1 whitespace 0m 4s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 3m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 9s Tests passed in hadoop-common. +1 mapreduce tests 1m 35s Tests passed in hadoop-mapreduce-client-core. +1 tools/hadoop tests 6m 9s Tests passed in hadoop-streaming.     71m 17s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735287/HADOOP-7266.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 56996a6 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/artifact/patchprocess/diffJavacWarnings.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/artifact/patchprocess/testrun_hadoop-common.txt hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/artifact/patchprocess/testrun_hadoop-streaming.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6824/console This message was automatically generated.
      Hide
      Hadoop QA added a comment -



      -1 overall



      Vote Subsystem Runtime Comment
      -1 patch 0m 0s The patch command could not apply the patch during dryrun.



      Subsystem Report/Notes
      Patch URL http://issues.apache.org/jira/secure/attachment/12735279/HADOOP-7266.002.patch
      Optional Tests javadoc javac unit findbugs checkstyle
      git revision trunk / 56996a6
      Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6823/console

      This message was automatically generated.

      Show
      Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735279/HADOOP-7266.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 56996a6 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6823/console This message was automatically generated.
      Hide
      Akira AJISAKA added a comment -

      v2 patch fixes javac warnings.

      Show
      Akira AJISAKA added a comment - v2 patch fixes javac warnings.
      Hide
      Akira AJISAKA added a comment -

      edit: If we cannot remove them, we should fix them to use metrics v2 before removing metrics v1 from trunk.

      Show
      Akira AJISAKA added a comment - edit: If we cannot remove them, we should fix them to use metrics v2 before removing metrics v1 from trunk.
      Hide
      Akira AJISAKA added a comment -

      Thanks Haohui Mai and Luke Lu for comments. Jenkins found there are some classes using metrics v1. (https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/diffJavacWarnings.txt)

      • LocalJobRunnerMetrics
      • ShuffleClientMetrics
      • LocalFetcher

      If we cannot remove them, we should fix them to use metrics v2 in this jira.

      Show
      Akira AJISAKA added a comment - Thanks Haohui Mai and Luke Lu for comments. Jenkins found there are some classes using metrics v1. ( https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/diffJavacWarnings.txt ) LocalJobRunnerMetrics ShuffleClientMetrics LocalFetcher If we cannot remove them, we should fix them to use metrics v2 in this jira.
      Hide
      Luke Lu added a comment -

      Akira AJISAKA, thanks for taking this over. Changed job, have different priorities I remember that the reason v1 is still around is mostly due to the downstream projects (e.g. Hive?) needed them. I think that's no longer the case now.

      Show
      Luke Lu added a comment - Akira AJISAKA , thanks for taking this over. Changed job, have different priorities I remember that the reason v1 is still around is mostly due to the downstream projects (e.g. Hive?) needed them. I think that's no longer the case now.
      Hide
      Haohui Mai added a comment -

      It might make it only applicable for branch-2 – we can probably remove metrics v1 in trunk directly without marking them as deprecated.

      Show
      Haohui Mai added a comment - It might make it only applicable for branch-2 – we can probably remove metrics v1 in trunk directly without marking them as deprecated.
      Hide
      Hadoop QA added a comment -



      -1 overall



      Vote Subsystem Runtime Comment
      0 pre-patch 14m 33s Pre-patch trunk compilation is healthy.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
      -1 javac 7m 29s The applied patch generated 186 additional warning messages.
      +1 javadoc 9m 30s There were no new javadoc warning messages.
      +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
      -1 checkstyle 1m 17s The applied patch generated 117 new checkstyle issues (total was 447, now 558).
      -1 whitespace 0m 12s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
      +1 install 1m 34s mvn install still works.
      +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
      +1 findbugs 2m 20s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
      +1 common tests 23m 5s Tests passed in hadoop-common.
      +1 tools/hadoop tests 6m 9s Tests passed in hadoop-streaming.
          67m 23s  



      Subsystem Report/Notes
      Patch URL http://issues.apache.org/jira/secure/attachment/12731148/HADOOP-7266.001.patch
      Optional Tests javadoc javac unit findbugs checkstyle
      git revision trunk / d335071
      javac https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/diffJavacWarnings.txt
      checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/diffcheckstylehadoop-common.txt
      whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/whitespace.txt
      hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/testrun_hadoop-common.txt
      hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/testrun_hadoop-streaming.txt
      Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/testReport/
      Java 1.7.0_55
      uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/console

      This message was automatically generated.

      Show
      Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 33s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. -1 javac 7m 29s The applied patch generated 186 additional warning messages. +1 javadoc 9m 30s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 17s The applied patch generated 117 new checkstyle issues (total was 447, now 558). -1 whitespace 0m 12s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 2m 20s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 23m 5s Tests passed in hadoop-common. +1 tools/hadoop tests 6m 9s Tests passed in hadoop-streaming.     67m 23s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731148/HADOOP-7266.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d335071 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/diffJavacWarnings.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/diffcheckstylehadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/testrun_hadoop-common.txt hadoop-streaming test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/artifact/patchprocess/testrun_hadoop-streaming.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6519/console This message was automatically generated.
      Hide
      Akira AJISAKA added a comment -

      Attaching a patch to add @Deprecated annotation to all the metrics v1 classes.

      Show
      Akira AJISAKA added a comment - Attaching a patch to add @Deprecated annotation to all the metrics v1 classes.
      Hide
      Akira AJISAKA added a comment -

      Hi Luke Lu, what's going on this issue? I'd like to take over and fix this issue quickly as it has been marked as blocker for the next minor release.

      Show
      Akira AJISAKA added a comment - Hi Luke Lu , what's going on this issue? I'd like to take over and fix this issue quickly as it has been marked as blocker for the next minor release.
      Hide
      Allen Wittenauer added a comment -

      Making this a blocker for 2.8.0 so we these can be removed in 3.0.0

      Show
      Allen Wittenauer added a comment - Making this a blocker for 2.8.0 so we these can be removed in 3.0.0
      Hide
      Allen Wittenauer added a comment -

      Nope, looks like metricsv1 is still there.

      Show
      Allen Wittenauer added a comment - Nope, looks like metricsv1 is still there.
      Hide
      Allen Wittenauer added a comment -

      Fixed. I think.

      Show
      Allen Wittenauer added a comment - Fixed. I think.
      Hide
      Luke Lu added a comment -

      By framework, I meant non-user/downstream metrics related code in common, hdfs and mapreduce, as per discussion in HADOOP-6728.

      Show
      Luke Lu added a comment - By framework, I meant non-user/downstream metrics related code in common, hdfs and mapreduce, as per discussion in HADOOP-6728 .
      Hide
      Luke Lu added a comment -

      After all framework metrics have been ported to metrics v2.

      Show
      Luke Lu added a comment - After all framework metrics have been ported to metrics v2.

        People

        • Assignee:
          Akira AJISAKA
          Reporter:
          Luke Lu
        • Votes:
          0 Vote for this issue
          Watchers:
          6 Start watching this issue

          Dates

          • Created:
            Updated:

            Development