Hadoop Common
  1. Hadoop Common
  2. HADOOP-7258

Gzip codec should not return null decompressors

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.20.203.0, 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In HADOOP-6315, the gzip codec was changed to return a null codec with the intent to disallow pooling of the decompressors. Rather than break the interface, we can use an annotation to achieve the goal.

      1. gzip-decomp.patch
        6 kB
        Owen O'Malley
      2. fix.patch
        4 kB
        Owen O'Malley

        Activity

        Hide
        Owen O'Malley added a comment -

        This patch fixes the problem and the testcases.

        Show
        Owen O'Malley added a comment - This patch fixes the problem and the testcases.
        Hide
        Chris Douglas added a comment -

        +1 Good catch

        Show
        Chris Douglas added a comment - +1 Good catch
        Hide
        Owen O'Malley added a comment -

        I messed up the previous patch by putting the annotation on the constructor rather than the class. I fix the definition of the annotation to only apply to types and put it in the right place.

        Show
        Owen O'Malley added a comment - I messed up the previous patch by putting the annotation on the constructor rather than the class. I fix the definition of the annotation to only apply to types and put it in the right place.
        Hide
        Owen O'Malley added a comment -

        I just committed this.

        Show
        Owen O'Malley added a comment - I just committed this.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #617 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/617/)
        HADOOP-7258. The Gzip codec should not return null decompressors. (omalley)

        omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127215
        Files :

        • /hadoop/common/trunk/CHANGES.txt
        • /hadoop/common/trunk/src/java/org/apache/hadoop/io/compress/DoNotPool.java
        • /hadoop/common/trunk/src/java/org/apache/hadoop/io/compress/CodecPool.java
        • /hadoop/common/trunk/src/test/core/org/apache/hadoop/io/compress/TestCodec.java
        • /hadoop/common/trunk/src/java/org/apache/hadoop/io/compress/zlib/BuiltInGzipDecompressor.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #617 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/617/ ) HADOOP-7258 . The Gzip codec should not return null decompressors. (omalley) omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127215 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/java/org/apache/hadoop/io/compress/DoNotPool.java /hadoop/common/trunk/src/java/org/apache/hadoop/io/compress/CodecPool.java /hadoop/common/trunk/src/test/core/org/apache/hadoop/io/compress/TestCodec.java /hadoop/common/trunk/src/java/org/apache/hadoop/io/compress/zlib/BuiltInGzipDecompressor.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #699 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/699/)
        HADOOP-7258. The Gzip codec should not return null decompressors. (omalley)

        omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127215
        Files :

        • /hadoop/common/trunk/CHANGES.txt
        • /hadoop/common/trunk/src/java/org/apache/hadoop/io/compress/DoNotPool.java
        • /hadoop/common/trunk/src/java/org/apache/hadoop/io/compress/CodecPool.java
        • /hadoop/common/trunk/src/test/core/org/apache/hadoop/io/compress/TestCodec.java
        • /hadoop/common/trunk/src/java/org/apache/hadoop/io/compress/zlib/BuiltInGzipDecompressor.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #699 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/699/ ) HADOOP-7258 . The Gzip codec should not return null decompressors. (omalley) omalley : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1127215 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/java/org/apache/hadoop/io/compress/DoNotPool.java /hadoop/common/trunk/src/java/org/apache/hadoop/io/compress/CodecPool.java /hadoop/common/trunk/src/test/core/org/apache/hadoop/io/compress/TestCodec.java /hadoop/common/trunk/src/java/org/apache/hadoop/io/compress/zlib/BuiltInGzipDecompressor.java
        Hide
        Owen O'Malley added a comment -

        Closing for 0.20.203.0

        Show
        Owen O'Malley added a comment - Closing for 0.20.203.0

          People

          • Assignee:
            Owen O'Malley
            Reporter:
            Owen O'Malley
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development