Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Need to refactor getmerge to conform to new FsCommand class.

      1. HADOOP-7251.patch
        9 kB
        Daryn Sharp
      2. HADOOP-7251-2.patch
        9 kB
        Daryn Sharp

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #681 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/681/)
          HADOOP-7251. Refactor the getmerge command to conform to new FsCommand class. Contributed by Daryn Sharp

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #681 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/681/ ) HADOOP-7251 . Refactor the getmerge command to conform to new FsCommand class. Contributed by Daryn Sharp
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #579 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/579/)
          HADOOP-7251. Refactor the getmerge command to conform to new FsCommand class. Contributed by Daryn Sharp

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #579 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/579/ ) HADOOP-7251 . Refactor the getmerge command to conform to new FsCommand class. Contributed by Daryn Sharp
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks, Daryn!

          Thanks also Matt for reviewing it.

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Daryn! Thanks also Matt for reviewing it.
          Hide
          Matt Foley added a comment -

          Never mind about the ctor, I wasn't expressing myself clearly.
          This new patch changed exactly what I asked for.
          +1.

          Show
          Matt Foley added a comment - Never mind about the ctor, I wasn't expressing myself clearly. This new patch changed exactly what I asked for. +1.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12478182/HADOOP-7251-2.patch
          against trunk revision 1099284.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/397//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/397//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/397//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478182/HADOOP-7251-2.patch against trunk revision 1099284. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/397//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/397//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/397//console This message is automatically generated.
          Hide
          Daryn Sharp added a comment -

          Thanks for the comments!

          The method parseOptions is now explicitly defining the delimiter to be null or newline in event of re-use – which isn't currently possible, but is a good idea.

          I'm not sure I understand the value of adding a ctor to explicitly set an instance var to null, when the instance var is already initialized to null? Did I misunderstand?

          Show
          Daryn Sharp added a comment - Thanks for the comments! The method parseOptions is now explicitly defining the delimiter to be null or newline in event of re-use – which isn't currently possible, but is a good idea. I'm not sure I understand the value of adding a ctor to explicitly set an instance var to null, when the instance var is already initialized to null? Did I misunderstand?
          Hide
          Matt Foley added a comment -

          I understand that the lifetime of the Merge object is only a single invocation, but I would prefer to have Merge.delimiter conditionally set to either null or "\n" at the decision point in processOptions(), in addition to being initialized to null by ctor. It's just to remove concern about re-use, or in case the object ever changes to be re-used.

          Show
          Matt Foley added a comment - I understand that the lifetime of the Merge object is only a single invocation, but I would prefer to have Merge.delimiter conditionally set to either null or "\n" at the decision point in processOptions(), in addition to being initialized to null by ctor. It's just to remove concern about re-use, or in case the object ever changes to be re-used.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12477765/HADOOP-7251.patch
          against trunk revision 1097322.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/388//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/388//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/388//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12477765/HADOOP-7251.patch against trunk revision 1097322. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/388//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/388//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/388//console This message is automatically generated.

            People

            • Assignee:
              Daryn Sharp
              Reporter:
              Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development