Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Need to refactor permissions commands to conform to new FsCommand class.

      1. HADOOP-7249-2.patch
        39 kB
        Daryn Sharp
      2. HADOOP-7249.patch
        39 kB
        Daryn Sharp

        Issue Links

          Activity

          Hide
          Daryn Sharp added a comment -

          Converted commands to FsCommand.

          Removed cruft in FsShell only used by these commands.

          Add exitCodeForError() to account for inconsistencies in the exit code returned by various commands.

          Greatly improved testing of exit codes related to these commands due to prior issues of returning the exit code of the last argument only.

          Show
          Daryn Sharp added a comment - Converted commands to FsCommand. Removed cruft in FsShell only used by these commands. Add exitCodeForError() to account for inconsistencies in the exit code returned by various commands. Greatly improved testing of exit codes related to these commands due to prior issues of returning the exit code of the last argument only.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12477719/HADOOP-7249.patch
          against trunk revision 1097322.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 10 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/384//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/384//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/384//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12477719/HADOOP-7249.patch against trunk revision 1097322. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 10 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/384//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/384//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/384//console This message is automatically generated.
          Hide
          Matt Foley added a comment -

          Hi Daryn, generally looks good but in FsShellPermissions.parseOwnerGroup() a tab (instead of spaces) crept in to the added lines just below "group = null;", to wit:
          if (group != null && group.length() == 0)

          { - group = null; - }

          + group = null;
          + } <-- problem here, and possibly prev line

          Show
          Matt Foley added a comment - Hi Daryn, generally looks good but in FsShellPermissions.parseOwnerGroup() a tab (instead of spaces) crept in to the added lines just below "group = null;", to wit: if (group != null && group.length() == 0) { - group = null; - } + group = null; + } <-- problem here, and possibly prev line
          Hide
          Matt Foley added a comment -
                if (group != null && group.length() == 0) {
          -        group = null;
          -      }
          +          group = null;
          +          } <-- problem here, and possibly prev line
          
          Show
          Matt Foley added a comment - if (group != null && group.length() == 0) { - group = null ; - } + group = null ; + } <-- problem here, and possibly prev line
          Hide
          Daryn Sharp added a comment -

          Removed tabs.

          Show
          Daryn Sharp added a comment - Removed tabs.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12478308/HADOOP-7249-2.patch
          against trunk revision 1099633.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 10 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/406//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/406//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/406//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478308/HADOOP-7249-2.patch against trunk revision 1099633. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 10 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/406//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/406//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/406//console This message is automatically generated.
          Hide
          Matt Foley added a comment -

          +1

          Show
          Matt Foley added a comment - +1
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks, Daryn!

          Thanks also Matt for reviewing it.

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Daryn! Thanks also Matt for reviewing it.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #578 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/578/)
          HADOOP-7249. Refactor the chmod/chown/chgrp command to conform to new FsCommand class. Contributed by Daryn Sharp

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #578 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/578/ ) HADOOP-7249 . Refactor the chmod/chown/chgrp command to conform to new FsCommand class. Contributed by Daryn Sharp
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #580 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/580/)
          Remove the empty file accidentally checked it with HADOOP-7249.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #580 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/580/ ) Remove the empty file accidentally checked it with HADOOP-7249 .
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #681 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/681/)
          Remove the empty file accidentally checked it with HADOOP-7249.
          HADOOP-7249. Refactor the chmod/chown/chgrp command to conform to new FsCommand class. Contributed by Daryn Sharp

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #681 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/681/ ) Remove the empty file accidentally checked it with HADOOP-7249 . HADOOP-7249 . Refactor the chmod/chown/chgrp command to conform to new FsCommand class. Contributed by Daryn Sharp

            People

            • Assignee:
              Daryn Sharp
              Reporter:
              Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development