Hadoop Common
  1. Hadoop Common
  2. HADOOP-7245

FsConfig should use constants in CommonConfigurationKeys

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In particular, FsConfig should use fs.defaultFS instead of the deprecated fs.default.name.

      1. hadoop-7245-1.patch
        6 kB
        Eli Collins
      2. HADOOP-7245.patch
        4 kB
        Tom White

        Activity

        Hide
        Tom White added a comment -

        This patch changes FsConfig to use the constants defined in CommonConfigurationKeys and CommonConfigurationKeysPublic.

        Show
        Tom White added a comment - This patch changes FsConfig to use the constants defined in CommonConfigurationKeys and CommonConfigurationKeysPublic.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12477574/HADOOP-7245.patch
        against trunk revision 1096988.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The patch appears to cause tar ant target to fail.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:

        -1 contrib tests. The patch failed contrib unit tests.

        -1 system test framework. The patch failed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/382//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/382//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/382//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12477574/HADOOP-7245.patch against trunk revision 1096988. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: -1 contrib tests. The patch failed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/382//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/382//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/382//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        Patch attached fixes the compilation errors in the S3 tests.

        Show
        Eli Collins added a comment - Patch attached fixes the compilation errors in the S3 tests.
        Hide
        Eli Collins added a comment -

        Hey Tom,

        The change in your patch looks good. Latest patch just updates two tests. I'll commit this if Hudson comes back OK.

        Thanks,
        Eli

        Show
        Eli Collins added a comment - Hey Tom, The change in your patch looks good. Latest patch just updates two tests. I'll commit this if Hudson comes back OK. Thanks, Eli
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12478362/hadoop-7245-1.patch
        against trunk revision 1100026.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/413//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/413//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/413//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478362/hadoop-7245-1.patch against trunk revision 1100026. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/413//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/413//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/413//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        +1

        Show
        Eli Collins added a comment - +1
        Hide
        Eli Collins added a comment -

        I've committed this to trunk and merged to 22. Thanks Tom!

        Show
        Eli Collins added a comment - I've committed this to trunk and merged to 22. Thanks Tom!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #574 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/574/)
        HADOOP-7245. FsConfig should use constants in CommonConfigurationKeys. Contributed by Tom White

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #574 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/574/ ) HADOOP-7245 . FsConfig should use constants in CommonConfigurationKeys. Contributed by Tom White
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-22-branch #44 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/44/)
        HADOOP-7245. svn merge -c 1100044 from trunk

        Show
        Hudson added a comment - Integrated in Hadoop-Common-22-branch #44 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/44/ ) HADOOP-7245 . svn merge -c 1100044 from trunk
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #680 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/680/)
        HADOOP-7245. FsConfig should use constants in CommonConfigurationKeys. Contributed by Tom White

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #680 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/680/ ) HADOOP-7245 . FsConfig should use constants in CommonConfigurationKeys. Contributed by Tom White

          People

          • Assignee:
            Tom White
            Reporter:
            Tom White
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development