Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-7230

Move -fs usage tests from hdfs into common

    Details

    • Type: Test
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The -fs usage tests are in hdfs which causes an unnecessary synchronization of a common & hdfs bug when changing the text. The usages have no ties to hdfs, so they should be moved into common.

        Issue Links

          Activity

          Hide
          daryn Daryn Sharp added a comment -

          Copy all the fs -help tests into common. Will remove from hdfs after this change is committed.

          Show
          daryn Daryn Sharp added a comment - Copy all the fs -help tests into common. Will remove from hdfs after this change is committed.
          Hide
          atm Aaron T. Myers added a comment -

          Thanks a lot for this, Daryn. I've reviewed the code and it looks good to me.

          Show
          atm Aaron T. Myers added a comment - Thanks a lot for this, Daryn. I've reviewed the code and it looks good to me.
          Hide
          atm Aaron T. Myers added a comment -

          Also, I don't think the precommit Hudson job is working at the moment for common, so you might want to run it and paste the results here yourself.

          Show
          atm Aaron T. Myers added a comment - Also, I don't think the precommit Hudson job is working at the moment for common, so you might want to run it and paste the results here yourself.
          Hide
          daryn Daryn Sharp added a comment -

          [exec] +1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] +1 tests included. The patch appears to include 61 new or modified tests.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
          [exec]
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          [exec]
          [exec] +1 system test framework. The patch passed system test framework compile.

          Show
          daryn Daryn Sharp added a comment - [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 61 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile.
          Hide
          atm Aaron T. Myers added a comment -

          +1

          Show
          atm Aaron T. Myers added a comment - +1
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12476633/HADOOP-7230.patch
          against trunk revision 1092853.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 61 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/350//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/350//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/350//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12476633/HADOOP-7230.patch against trunk revision 1092853. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 61 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/350//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/350//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/350//console This message is automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks, Daryn!

          Thanks also Aaron for reviewing it.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Daryn! Thanks also Aaron for reviewing it.
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #558 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/558/)
          HADOOP-7230. Move "fs -help" shell command tests from HDFS to COMMOM. Contributed by Daryn Sharp

          Show
          hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #558 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/558/ ) HADOOP-7230 . Move "fs -help" shell command tests from HDFS to COMMOM. Contributed by Daryn Sharp
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Common-trunk #666 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/666/)
          HADOOP-7230. Move "fs -help" shell command tests from HDFS to COMMOM. Contributed by Daryn Sharp

          Show
          hudson Hudson added a comment - Integrated in Hadoop-Common-trunk #666 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/666/ ) HADOOP-7230 . Move "fs -help" shell command tests from HDFS to COMMOM. Contributed by Daryn Sharp

            People

            • Assignee:
              daryn Daryn Sharp
              Reporter:
              daryn Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development