Hadoop Common
  1. Hadoop Common
  2. HADOOP-7227

Remove protocol version check at proxy creation in Hadoop RPC.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Hide
      1. Protocol version check is removed from proxy creation, instead version check is performed at server in every rpc call.
      2. This change is backward incompatible because format of the rpc messages is changed to include client version, client method hash and rpc version.
      3. rpc version is introduced which should change when the format of rpc messages is changed.
      Show
      1. Protocol version check is removed from proxy creation, instead version check is performed at server in every rpc call. 2. This change is backward incompatible because format of the rpc messages is changed to include client version, client method hash and rpc version. 3. rpc version is introduced which should change when the format of rpc messages is changed.

      Description

      Currently when a proxy is created for a protocol, there is a round trip of messages to check the protocol version. The protocol version is not checked in any subsequent rpc which could be a problem if the server restarts with a new protocol version. This issue and also the additional round-trip at proxy creation can be avoided if we add the protocol version in every rpc, and server checks the protocol version for every call.

      1. HADOOP-7227.6.patch
        16 kB
        Jitendra Nath Pandey
      2. HADOOP-7227.5.patch
        16 kB
        Jitendra Nath Pandey
      3. HADOOP-7227.4.patch
        16 kB
        Jitendra Nath Pandey
      4. HADOOP-7227.3.patch
        16 kB
        Jitendra Nath Pandey
      5. HADOOP-7227.2.patch
        15 kB
        Jitendra Nath Pandey

        Issue Links

          Activity

          Jitendra Nath Pandey created issue -
          Jitendra Nath Pandey made changes -
          Field Original Value New Value
          Attachment HADOOP-7227.2.patch [ 12477465 ]
          Jitendra Nath Pandey made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Jitendra Nath Pandey made changes -
          Attachment HADOOP-7227.3.patch [ 12477850 ]
          Jitendra Nath Pandey made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Jitendra Nath Pandey made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Jitendra Nath Pandey made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Jitendra Nath Pandey made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Jitendra Nath Pandey made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Jitendra Nath Pandey made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Jitendra Nath Pandey made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Jitendra Nath Pandey made changes -
          Attachment HADOOP-7227.4.patch [ 12477977 ]
          Jitendra Nath Pandey made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Tsz Wo Nicholas Sze made changes -
          Hadoop Flags [Incompatible change, Reviewed]
          Issue Type New Feature [ 2 ] Improvement [ 4 ]
          Component/s ipc [ 12310688 ]
          Jitendra Nath Pandey made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.23.0 [ 12315569 ]
          Resolution Fixed [ 1 ]
          Jitendra Nath Pandey made changes -
          Release Note 1. Protocol version check is removed from proxy creation, instead version check is performed at server in every rpc call.
          2. This change is backward incompatible because format of the rpc messages is changed to include client version, client method hash and rpc version.
          3. rpc version is introduced which should change when the format of rpc messages is changed.
          Todd Lipcon made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Jitendra Nath Pandey made changes -
          Attachment HADOOP-7227.5.patch [ 12478032 ]
          Jitendra Nath Pandey made changes -
          Status Reopened [ 4 ] Patch Available [ 10002 ]
          Jitendra Nath Pandey made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Jitendra Nath Pandey made changes -
          Attachment HADOOP-7227.6.patch [ 12478070 ]
          Jitendra Nath Pandey made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Jitendra Nath Pandey made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Konstantin Shvachko made changes -
          Link This issue breaks HADOOP-8558 [ HADOOP-8558 ]

            People

            • Assignee:
              Jitendra Nath Pandey
              Reporter:
              Jitendra Nath Pandey
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development