Hadoop Common
  1. Hadoop Common
  2. HADOOP-7227

Remove protocol version check at proxy creation in Hadoop RPC.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Hide
      1. Protocol version check is removed from proxy creation, instead version check is performed at server in every rpc call.
      2. This change is backward incompatible because format of the rpc messages is changed to include client version, client method hash and rpc version.
      3. rpc version is introduced which should change when the format of rpc messages is changed.
      Show
      1. Protocol version check is removed from proxy creation, instead version check is performed at server in every rpc call. 2. This change is backward incompatible because format of the rpc messages is changed to include client version, client method hash and rpc version. 3. rpc version is introduced which should change when the format of rpc messages is changed.

      Description

      Currently when a proxy is created for a protocol, there is a round trip of messages to check the protocol version. The protocol version is not checked in any subsequent rpc which could be a problem if the server restarts with a new protocol version. This issue and also the additional round-trip at proxy creation can be avoided if we add the protocol version in every rpc, and server checks the protocol version for every call.

      1. HADOOP-7227.2.patch
        15 kB
        Jitendra Nath Pandey
      2. HADOOP-7227.3.patch
        16 kB
        Jitendra Nath Pandey
      3. HADOOP-7227.4.patch
        16 kB
        Jitendra Nath Pandey
      4. HADOOP-7227.5.patch
        16 kB
        Jitendra Nath Pandey
      5. HADOOP-7227.6.patch
        16 kB
        Jitendra Nath Pandey

        Issue Links

          Activity

          Hide
          Jitendra Nath Pandey added a comment -

          First patch uploaded.

          Show
          Jitendra Nath Pandey added a comment - First patch uploaded.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12477465/HADOOP-7227.2.patch
          against trunk revision 1096522.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/381//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/381//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/381//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12477465/HADOOP-7227.2.patch against trunk revision 1096522. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/381//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/381//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/381//console This message is automatically generated.
          Hide
          Hairong Kuang added a comment -

          We have already moved away from RPC protocol version, right?

          Show
          Hairong Kuang added a comment - We have already moved away from RPC protocol version, right?
          Hide
          Jitendra Nath Pandey added a comment -

          This patch does not change the semantics of protocol versions. It only moves the version check from client at proxy creation to rpc call at server, and thus saving a round-trip of messages.
          HADOOP-6904 introduced isMethodSupported in ProtocolProxy, which needs server methods. That logic is also maintained except that the server methods are fetched when isMethodSupported is called for the first time.

          Show
          Jitendra Nath Pandey added a comment - This patch does not change the semantics of protocol versions. It only moves the version check from client at proxy creation to rpc call at server, and thus saving a round-trip of messages. HADOOP-6904 introduced isMethodSupported in ProtocolProxy, which needs server methods. That logic is also maintained except that the server methods are fetched when isMethodSupported is called for the first time.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Jitendra, I think the title "Remove protocol version check ..." may be misleading. You are actually moving protocol version check to the call for saving the initial round trip in proxy creation but not removing it.

          Show
          Tsz Wo Nicholas Sze added a comment - Jitendra, I think the title "Remove protocol version check ..." may be misleading. You are actually moving protocol version check to the call for saving the initial round trip in proxy creation but not removing it.
          Hide
          Tsz Wo Nicholas Sze added a comment -
          • serverMethodsFetched should be synchronized unless it is done elsewhere
          • supportServerMethodCheck should be final.
          • Please add a test for rpcVersion
          • I found protocolVersion, serverVersion and clientVersion, which refer to the same version number, a little bit confusion. See if you could make it more clear.
          Show
          Tsz Wo Nicholas Sze added a comment - serverMethodsFetched should be synchronized unless it is done elsewhere supportServerMethodCheck should be final. Please add a test for rpcVersion I found protocolVersion , serverVersion and clientVersion , which refer to the same version number, a little bit confusion. See if you could make it more clear.
          Hide
          Jitendra Nath Pandey added a comment -

          New patch addressing the comments.

          Show
          Jitendra Nath Pandey added a comment - New patch addressing the comments.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12477850/HADOOP-7227.3.patch
          against trunk revision 1097322.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:

          -1 contrib tests. The patch failed contrib unit tests.

          -1 system test framework. The patch failed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/390//testReport/
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/390//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12477850/HADOOP-7227.3.patch against trunk revision 1097322. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: -1 contrib tests. The patch failed contrib unit tests. -1 system test framework. The patch failed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/390//testReport/ Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/390//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12477977/HADOOP-7227.4.patch
          against trunk revision 1097322.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/391//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/391//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/391//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12477977/HADOOP-7227.4.patch against trunk revision 1097322. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/391//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/391//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/391//console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good.

          Show
          Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
          Hide
          Jitendra Nath Pandey added a comment -

          I have committed this!

          Show
          Jitendra Nath Pandey added a comment - I have committed this!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #567 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/567/)
          HADOOP-7227. Remove protocol version check at proxy creation in Hadoop RPC. Contributed by jitendra.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #567 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/567/ ) HADOOP-7227 . Remove protocol version check at proxy creation in Hadoop RPC. Contributed by jitendra.
          Hide
          Todd Lipcon added a comment -

          This patch seems to have broken MR. I'm getting:

          [junit] 11/05/02 15:51:51 ERROR mapred.TaskTracker: Caught exception: java.lang.RuntimeException: java.lang.IllegalAccessException: Class org.apache.hadoop.ipc.WritableRpcEngine$Invocation can not access a member of class org.apache.hadoop.mapred.InterTrackerProtocol with modifiers "public static final"
          [junit] at org.apache.hadoop.ipc.WritableRpcEngine$Invocation.<init>(WritableRpcEngine.java:85)
          [junit] at org.apache.hadoop.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:249)
          [junit] at org.apache.hadoop.mapred.$Proxy7.getBuildVersion(Unknown Source)
          [junit] at org.apache.hadoop.mapred.TaskTracker.offerService(TaskTracker.java:1500)

          in a tight loop.

          Show
          Todd Lipcon added a comment - This patch seems to have broken MR. I'm getting: [junit] 11/05/02 15:51:51 ERROR mapred.TaskTracker: Caught exception: java.lang.RuntimeException: java.lang.IllegalAccessException: Class org.apache.hadoop.ipc.WritableRpcEngine$Invocation can not access a member of class org.apache.hadoop.mapred.InterTrackerProtocol with modifiers "public static final" [junit] at org.apache.hadoop.ipc.WritableRpcEngine$Invocation.<init>(WritableRpcEngine.java:85) [junit] at org.apache.hadoop.ipc.WritableRpcEngine$Invoker.invoke(WritableRpcEngine.java:249) [junit] at org.apache.hadoop.mapred.$Proxy7.getBuildVersion(Unknown Source) [junit] at org.apache.hadoop.mapred.TaskTracker.offerService(TaskTracker.java:1500) in a tight loop.
          Hide
          Todd Lipcon added a comment -

          I believe we either need to make all protocols public interfaces, or we need to call setAccessible(true) on the Field instance.

          Show
          Todd Lipcon added a comment - I believe we either need to make all protocols public interfaces, or we need to call setAccessible(true) on the Field instance.
          Hide
          Todd Lipcon added a comment -

          Making InterTrackerProtocol public got past that issue, but now hitting:

          [junit] java.lang.IllegalAccessError: tried to access class org.apache.hadoop.mapred.HeartbeatResponse from class $Proxy7
          [junit] at $Proxy7.heartbeat(Unknown Source)
          [junit] at org.apache.hadoop.mapred.TaskTracker.transmitHeartBeat(TaskTracker.java:1692)
          [junit] at org.apache.hadoop.mapred.TaskTracker.offerService(TaskTracker.java:1523)
          [junit] at org.apache.hadoop.mapred.TaskTracker.run(TaskTracker.java:2428)
          [junit] at org.apache.hadoop.mapred.MiniMRCluster$TaskTrackerRunner.run(MiniMRCluster.java:229)

          I am going to temporarily revert this patch from common, since it was insufficiently tested and is breaking the dependent projects.

          Show
          Todd Lipcon added a comment - Making InterTrackerProtocol public got past that issue, but now hitting: [junit] java.lang.IllegalAccessError: tried to access class org.apache.hadoop.mapred.HeartbeatResponse from class $Proxy7 [junit] at $Proxy7.heartbeat(Unknown Source) [junit] at org.apache.hadoop.mapred.TaskTracker.transmitHeartBeat(TaskTracker.java:1692) [junit] at org.apache.hadoop.mapred.TaskTracker.offerService(TaskTracker.java:1523) [junit] at org.apache.hadoop.mapred.TaskTracker.run(TaskTracker.java:2428) [junit] at org.apache.hadoop.mapred.MiniMRCluster$TaskTrackerRunner.run(MiniMRCluster.java:229) I am going to temporarily revert this patch from common, since it was insufficiently tested and is breaking the dependent projects.
          Hide
          Jitendra Nath Pandey added a comment -

          I am running mr tests to look into the issue.

          Show
          Jitendra Nath Pandey added a comment - I am running mr tests to look into the issue.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #568 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/568/)
          Revert HADOOP-7227 from r1098792 since it broke HDFS and MR builds.

          ( svn merge -c -1098792 )

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #568 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/568/ ) Revert HADOOP-7227 from r1098792 since it broke HDFS and MR builds. ( svn merge -c -1098792 )
          Hide
          Jitendra Nath Pandey added a comment -

          New patch calls setAccessible(true) for versionID field.

          Show
          Jitendra Nath Pandey added a comment - New patch calls setAccessible(true) for versionID field.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12478032/HADOOP-7227.5.patch
          against trunk revision 1098840.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/393//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/393//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/393//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478032/HADOOP-7227.5.patch against trunk revision 1098840. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/393//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/393//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/393//console This message is automatically generated.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #677 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/677/)
          Revert HADOOP-7227 from r1098792 since it broke HDFS and MR builds.

          ( svn merge -c -1098792 )
          HADOOP-7227. Remove protocol version check at proxy creation in Hadoop RPC. Contributed by jitendra.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #677 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/677/ ) Revert HADOOP-7227 from r1098792 since it broke HDFS and MR builds. ( svn merge -c -1098792 ) HADOOP-7227 . Remove protocol version check at proxy creation in Hadoop RPC. Contributed by jitendra.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 the new patch looks good.

          Show
          Tsz Wo Nicholas Sze added a comment - +1 the new patch looks good.
          Hide
          Jitendra Nath Pandey added a comment -

          I ran hdfs tests and mr tests with this patch in common.

          hdfs: All tests pass except TestHdfsTrash, TestReplaceDatanodeOnFailure, TestMetaSave which failed for unrelated reasons

          mr: All tests passed except TestMiniMRChildTask which also failed for unrelated reason.

          Show
          Jitendra Nath Pandey added a comment - I ran hdfs tests and mr tests with this patch in common. hdfs: All tests pass except TestHdfsTrash, TestReplaceDatanodeOnFailure, TestMetaSave which failed for unrelated reasons mr: All tests passed except TestMiniMRChildTask which also failed for unrelated reason.
          Hide
          Jitendra Nath Pandey added a comment -

          Similar change as previous one in fetchServerMethods in ProtocolProxy as well.

          Show
          Jitendra Nath Pandey added a comment - Similar change as previous one in fetchServerMethods in ProtocolProxy as well.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12478070/HADOOP-7227.6.patch
          against trunk revision 1098840.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 9 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/394//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/394//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/394//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478070/HADOOP-7227.6.patch against trunk revision 1098840. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/394//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/394//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/394//console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1

          Minor: The following codes repeat twice. It may deserve putting them in a utility method. Otherwise, we won't miss the other "versionID" previously.

          +    try {
          +      Field versionField = method.getDeclaringClass().getField("versionID");
          +      versionField.setAccessible(true);
          +      clientVersion = versionField.getLong(method.getDeclaringClass());
          +    } catch (NoSuchFieldException ex) {
          +      throw new RuntimeException(ex);
          +    } catch (IllegalAccessException ex) {
          +      throw new RuntimeException(ex);
          +    }
          
          Show
          Tsz Wo Nicholas Sze added a comment - +1 Minor: The following codes repeat twice. It may deserve putting them in a utility method. Otherwise, we won't miss the other "versionID" previously. + try { + Field versionField = method.getDeclaringClass().getField( "versionID" ); + versionField.setAccessible( true ); + clientVersion = versionField.getLong(method.getDeclaringClass()); + } catch (NoSuchFieldException ex) { + throw new RuntimeException(ex); + } catch (IllegalAccessException ex) { + throw new RuntimeException(ex); + }
          Hide
          Jitendra Nath Pandey added a comment -

          > The following codes repeat twice. It may deserve putting them in a utility method.
          That is correct! I would like to add a RPCUtil class and add a method there to get the version. I would prefer to do it in a separate patch as a refactor. Is that ok?

          Show
          Jitendra Nath Pandey added a comment - > The following codes repeat twice. It may deserve putting them in a utility method. That is correct! I would like to add a RPCUtil class and add a method there to get the version. I would prefer to do it in a separate patch as a refactor. Is that ok?
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Sure. Let's do it separately.

          Show
          Tsz Wo Nicholas Sze added a comment - Sure. Let's do it separately.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #570 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/570/)
          HADOOP-7227. Remove protocol version check at proxy creation in Hadoop RPC. Contributed by jitendra.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #570 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/570/ ) HADOOP-7227 . Remove protocol version check at proxy creation in Hadoop RPC. Contributed by jitendra.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #678 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/678/)
          HADOOP-7227. Remove protocol version check at proxy creation in Hadoop RPC. Contributed by jitendra.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #678 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/678/ ) HADOOP-7227 . Remove protocol version check at proxy creation in Hadoop RPC. Contributed by jitendra.
          Hide
          Jitendra Nath Pandey added a comment -

          This has been committed!

          Show
          Jitendra Nath Pandey added a comment - This has been committed!

            People

            • Assignee:
              Jitendra Nath Pandey
              Reporter:
              Jitendra Nath Pandey
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development