Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The commit of HADOOP-7202 now requires that classes that extend FsCommand implement the void run(PathData) method. The Count class was changed to extend FsCommand, but renamed the run method and did not provide a replacement.

      1. HADOOP-7216-1.patch
        3 kB
        Daryn Sharp
      2. hadoop-7216.0.txt
        0.8 kB
        Aaron T. Myers

        Issue Links

          Activity

          Hide
          Aaron T. Myers added a comment -

          Trivial patch to add an implementation of the run method to the Count class. I manually verified that this fixes the test in HDFS.

          Show
          Aaron T. Myers added a comment - Trivial patch to add an implementation of the run method to the Count class. I manually verified that this fixes the test in HDFS.
          Hide
          Todd Lipcon added a comment -

          I'm not sure if this is the right spot, or if FsCommand.java's run method should have this as a body. Daryn, can you comment?

          Show
          Todd Lipcon added a comment - I'm not sure if this is the right spot, or if FsCommand.java's run method should have this as a body. Daryn, can you comment?
          Hide
          Daryn Sharp added a comment -

          Yes, I think it should be FsCommand along with a few other small tweaks. I can take over this bug if that's ok. I'm already in the process of testing a fix to retain complete compatibility.

          Show
          Daryn Sharp added a comment - Yes, I think it should be FsCommand along with a few other small tweaks. I can take over this bug if that's ok. I'm already in the process of testing a fix to retain complete compatibility.
          Hide
          Aaron T. Myers added a comment -

          I can take over this bug if that's OK.

          Please do. Reassigning to you.

          Show
          Aaron T. Myers added a comment - I can take over this bug if that's OK. Please do. Reassigning to you.
          Hide
          Daryn Sharp added a comment -

          make a few changes for better backwards compat

          Show
          Daryn Sharp added a comment - make a few changes for better backwards compat
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12475845/HADOOP-7216-1.patch
          against trunk revision 1090039.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/336//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/336//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/336//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12475845/HADOOP-7216-1.patch against trunk revision 1090039. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/336//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/336//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/336//console This message is automatically generated.
          Hide
          Daryn Sharp added a comment -

          There are no tests, because it's designed to fix tests in hdfs.

          Show
          Daryn Sharp added a comment - There are no tests, because it's designed to fix tests in hdfs.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good.

          Show
          Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks Daryn!

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks Daryn!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #546 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/546/)
          HADOOP-7216. Add FsCommand.runAll() with deprecated annotation for the transition of Command base class improvement. Contributed by Daryn Sharp

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #546 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/546/ ) HADOOP-7216 . Add FsCommand.runAll() with deprecated annotation for the transition of Command base class improvement. Contributed by Daryn Sharp
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #656 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/656/)
          HADOOP-7216. Add FsCommand.runAll() with deprecated annotation for the transition of Command base class improvement. Contributed by Daryn Sharp

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #656 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/656/ ) HADOOP-7216 . Add FsCommand.runAll() with deprecated annotation for the transition of Command base class improvement. Contributed by Daryn Sharp

            People

            • Assignee:
              Daryn Sharp
              Reporter:
              Aaron T. Myers
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development