Hadoop Common
  1. Hadoop Common
  2. HADOOP-7193

Help message is wrong for touchz command.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.1, 0.22.0, 0.23.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Updated the help for the touchz command.

      Description

      Help message for touchz command is
      -touchz <path>: Write a timestamp in yyyy-MM-dd HH:mm:ss format
      in a file at <path>. An error is returned if the file exists with non-zero length.

      Actually current DFS behaviour is that it will not write any time stamp in created file. Just it is creating zero size file.

      So better to change the help message to give exact meaning.

      1. HADOOP-7193.patch
        0.9 kB
        Uma Maheswara Rao G
      2. HADOOP-7193.patch
        0.9 kB
        James Seigel

        Activity

        Hide
        Radek Skokan added a comment -

        Hi guys, it seems that hadoop-1.0.4 still has the old help message text:

        $ hadoop fs -help touchz
        -touchz <path>: Write a timestamp in yyyy-MM-dd HH:mm:ss format
        in a file at <path>. An error is returned if the file exists with non-zero length

        Show
        Radek Skokan added a comment - Hi guys, it seems that hadoop-1.0.4 still has the old help message text: $ hadoop fs -help touchz -touchz <path>: Write a timestamp in yyyy-MM-dd HH:mm:ss format in a file at <path>. An error is returned if the file exists with non-zero length
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-22-branch #35 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/35/)
        HADOOP-7193. Correct the "fs -touchz" command help message. Contributed by Uma Maheswara Rao G

        Show
        Hudson added a comment - Integrated in Hadoop-Common-22-branch #35 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/35/ ) HADOOP-7193 . Correct the "fs -touchz" command help message. Contributed by Uma Maheswara Rao G
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #533 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/533/)
        HADOOP-7193. Correct the "fs -touchz" command help message. Contributed by Uma Maheswara Rao G

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #533 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/533/ ) HADOOP-7193 . Correct the "fs -touchz" command help message. Contributed by Uma Maheswara Rao G
        Hide
        Tsz Wo Nicholas Sze added a comment -

        > Please justify why no new tests are needed for this patch.
        This only fixes an help message.

        I have committed this. Thanks, Uma!

        Show
        Tsz Wo Nicholas Sze added a comment - > Please justify why no new tests are needed for this patch. This only fixes an help message. I have committed this. Thanks, Uma!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12473984/HADOOP-7193.patch
        against trunk revision 1084415.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/317//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/317//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/317//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12473984/HADOOP-7193.patch against trunk revision 1084415. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/317//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/317//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/317//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Hide
        Uma Maheswara Rao G added a comment -

        Thanks James,
        Small change in message, HDFS will not write any time stamp in file. Just it will create zero size files and modified/created time as current time.
        Updated the appropriate message.

        Show
        Uma Maheswara Rao G added a comment - Thanks James, Small change in message, HDFS will not write any time stamp in file. Just it will create zero size files and modified/created time as current time. Updated the appropriate message.

          People

          • Assignee:
            Uma Maheswara Rao G
            Reporter:
            Uma Maheswara Rao G
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development