Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-7183

WritableComparator.get should not cache comparator objects

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.21.1, 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HADOOP-6881 modified WritableComparator.get such that the constructed WritableComparator gets saved back into the static map. This is fine for stateless comparators, but some comparators have per-instance state, and thus this becomes thread-unsafe and causes errors in the shuffle where multiple threads are doing comparisons. An example of a Comparator with per-instance state is WritableComparator itself.

        Attachments

        1. HADOOP-7183.patch
          0.9 kB
          Tom White
        2. HADOOP-7183.patch
          2 kB
          Tom White

          Issue Links

            Activity

              People

              • Assignee:
                tomwhite Tom White
                Reporter:
                tlipcon Todd Lipcon
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: