Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The moveToTrash method returns false in a number of cases. It's not possible to discern if false means an error occurred. In particular, it's not possible to know if the trash is disabled vs. an error occurred.

      1. HADOOP-7175-2.patch
        2 kB
        Daryn Sharp
      2. HADOOP-7175.patch
        2 kB
        Daryn Sharp

        Issue Links

          Activity

          Daryn Sharp created issue -
          Daryn Sharp made changes -
          Field Original Value New Value
          Link This issue is related to HADOOP-6236 [ HADOOP-6236 ]
          Daryn Sharp made changes -
          Link This issue is related to HADOOP-6345 [ HADOOP-6345 ]
          Hide
          Daryn Sharp added a comment -

          Adds isEnabled() method and corresponding tests.

          Show
          Daryn Sharp added a comment - Adds isEnabled() method and corresponding tests.
          Daryn Sharp made changes -
          Attachment HADOOP-7175.patch [ 12473173 ]
          Daryn Sharp made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Daryn Sharp made changes -
          Link This issue blocks HADOOP-7176 [ HADOOP-7176 ]
          Tsz Wo Nicholas Sze made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Affects Version/s 0.22.0 [ 12314296 ]
          Fix Version/s 0.22.0 [ 12314296 ]
          Tsz Wo Nicholas Sze made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Assignee Daryn Sharp [ daryn ]
          Fix Version/s 0.23.0 [ 12315569 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Hi Daryn, there is a tab in the new isEnabled() method. We don't use tabs in Hadoop. Could you remove it? Other then that the patch looks good.

          Show
          Tsz Wo Nicholas Sze added a comment - Hi Daryn, there is a tab in the new isEnabled() method. We don't use tabs in Hadoop. Could you remove it? Other then that the patch looks good.
          Hide
          Daryn Sharp added a comment -

          Remove tab.

          Show
          Daryn Sharp added a comment - Remove tab.
          Daryn Sharp made changes -
          Attachment HADOOP-7175-2.patch [ 12473427 ]
          Hide
          Daryn Sharp added a comment -

          test-contrib:

          test:

          compile:

          test:

          python.pathcheck:
          [echo] 'python.home' is not defined. Please pass -Dpython.home=<Path to Python> to Ant on the command-line.

          checkAndRunTests:

          BUILD SUCCESSFUL

          Show
          Daryn Sharp added a comment - test-contrib: test: compile: test: python.pathcheck: [echo] 'python.home' is not defined. Please pass -Dpython.home=<Path to Python> to Ant on the command-line. checkAndRunTests: BUILD SUCCESSFUL
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12473427/HADOOP-7175-2.patch
          against trunk revision 1080817.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/309//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/309//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/309//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12473427/HADOOP-7175-2.patch against trunk revision 1080817. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/309//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/309//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/309//console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks, Daryn!

          (Hudson seems not able to pick up COMMON patches automatically. I have manually started the hudson build.)

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Daryn! (Hudson seems not able to pick up COMMON patches automatically. I have manually started the hudson build.)
          Tsz Wo Nicholas Sze made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #528 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/528/)
          HADOOP-7175. Add isEnabled() to Trash. Contributed by Daryn Sharp

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #528 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/528/ ) HADOOP-7175 . Add isEnabled() to Trash. Contributed by Daryn Sharp
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #631 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/631/)
          HADOOP-7175. Add isEnabled() to Trash. Contributed by Daryn Sharp

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #631 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/631/ ) HADOOP-7175 . Add isEnabled() to Trash. Contributed by Daryn Sharp
          Matt Foley made changes -
          Link This issue relates to HADOOP-7284 [ HADOOP-7284 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Daryn Sharp
              Reporter:
              Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 24h
                24h
                Remaining:
                Remaining Estimate - 24h
                24h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development