Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-7161

Remove unnecessary oro package from dependency management section

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.0, 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: build
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      Best I can tell we never use the "oro" dependency, but it's been in ivy.xml forever. Does anyone know any reason we might need it?

        Issue Links

          Activity

          Hide
          vicaya Luke Lu added a comment -

          oro is a transitive dependency from commons-net. Feel free to remove it from ivy.xml though, as it'll get pulled in anyway

          Show
          vicaya Luke Lu added a comment - oro is a transitive dependency from commons-net. Feel free to remove it from ivy.xml though, as it'll get pulled in anyway
          Hide
          busbey Sean Busbey added a comment -

          -01 Remove Jakarta Oro from pom

          • remove oro from dependency management

          HADOOP-8278 removed Oro from the dependency list for hadoop-common, but left it in the dependency management section of hadoop-project.

          commons-net stopped using oro in 2.x (and we rely on a much later version).

          Show
          busbey Sean Busbey added a comment - -01 Remove Jakarta Oro from pom remove oro from dependency management HADOOP-8278 removed Oro from the dependency list for hadoop-common, but left it in the dependency management section of hadoop-project. commons-net stopped using oro in 2.x (and we rely on a much later version).
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 1s trunk passed
          +1 compile 0m 9s trunk passed with JDK v1.8.0_66
          +1 compile 0m 9s trunk passed with JDK v1.7.0_91
          +1 mvnsite 0m 13s trunk passed
          +1 mvneclipse 0m 10s trunk passed
          +1 javadoc 0m 10s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 10s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 8s the patch passed
          +1 compile 0m 6s the patch passed with JDK v1.8.0_66
          +1 javac 0m 6s the patch passed
          +1 compile 0m 7s the patch passed with JDK v1.7.0_91
          +1 javac 0m 7s the patch passed
          +1 mvnsite 0m 10s the patch passed
          +1 mvneclipse 0m 8s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 xml 0m 0s The patch has no ill-formed XML file.
          +1 javadoc 0m 7s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 8s the patch passed with JDK v1.7.0_91
          +1 unit 0m 6s hadoop-project in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 7s hadoop-project in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 17s Patch does not generate ASF License warnings.
          11m 22s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782134/HADOOP-7161.1.patch
          JIRA Issue HADOOP-7161
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux 16326a1e2371 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 321072b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8403/testReport/
          modules C: hadoop-project U: hadoop-project
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8403/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 1s trunk passed +1 compile 0m 9s trunk passed with JDK v1.8.0_66 +1 compile 0m 9s trunk passed with JDK v1.7.0_91 +1 mvnsite 0m 13s trunk passed +1 mvneclipse 0m 10s trunk passed +1 javadoc 0m 10s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 10s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 8s the patch passed +1 compile 0m 6s the patch passed with JDK v1.8.0_66 +1 javac 0m 6s the patch passed +1 compile 0m 7s the patch passed with JDK v1.7.0_91 +1 javac 0m 7s the patch passed +1 mvnsite 0m 10s the patch passed +1 mvneclipse 0m 8s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 javadoc 0m 7s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 8s the patch passed with JDK v1.7.0_91 +1 unit 0m 6s hadoop-project in the patch passed with JDK v1.8.0_66. +1 unit 0m 7s hadoop-project in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 11m 22s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782134/HADOOP-7161.1.patch JIRA Issue HADOOP-7161 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 16326a1e2371 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 321072b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8403/testReport/ modules C: hadoop-project U: hadoop-project Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8403/console This message was automatically generated.
          Hide
          busbey Sean Busbey added a comment -

          no new tests because it's a pom-only change.

          Show
          busbey Sean Busbey added a comment - no new tests because it's a pom-only change.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, committing this.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, committing this.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk, branch-2, and branch-2.8. Thanks Sean Busbey for the contribution!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.8. Thanks Sean Busbey for the contribution!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9152 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9152/)
          HADOOP-7161. Remove unnecessary oro package from dependency management (aajisaka: rev 2ac39ca762fd7e47b7b9a7b3308b31138b0f59be)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-project/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9152 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9152/ ) HADOOP-7161 . Remove unnecessary oro package from dependency management (aajisaka: rev 2ac39ca762fd7e47b7b9a7b3308b31138b0f59be) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-project/pom.xml

            People

            • Assignee:
              busbey Sean Busbey
              Reporter:
              tlipcon Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development