Hadoop Common
  1. Hadoop Common
  2. HADOOP-7139

Allow appending to existing SequenceFiles

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 2.6.1, 2.7.2
    • Component/s: io
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Existing sequence files can be appended.
    1. HADOOP-7139.patch
      7 kB
      Stephen Rose
    2. HADOOP-7139.patch
      7 kB
      Stephen Rose
    3. HADOOP-7139.patch
      7 kB
      Stephen Rose
    4. HADOOP-7139.patch
      7 kB
      Stephen Rose
    5. HADOOP-7139-01.patch
      11 kB
      Kanaka Kumar Avvaru
    6. HADOOP-7139-02.patch
      9 kB
      Kanaka Kumar Avvaru
    7. HADOOP-7139-03.patch
      9 kB
      Kanaka Kumar Avvaru
    8. HADOOP-7139-04.patch
      17 kB
      Kanaka Kumar Avvaru
    9. HADOOP-7139-05.patch
      17 kB
      Kanaka Kumar Avvaru
    10. HADOOP-7139-kt.patch
      41 kB
      Kristofer Tomasette

      Issue Links

        Activity

        Hide
        Stephen Rose added a comment -

        Didn't mean to close it

        Show
        Stephen Rose added a comment - Didn't mean to close it
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12470968/HADOOP-7139.patch
        against trunk revision 1070021.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.io.compress.TestCodec
        org.apache.hadoop.io.TestArrayFile
        org.apache.hadoop.io.TestBloomMapFile
        org.apache.hadoop.io.TestMapFile
        org.apache.hadoop.io.TestSequenceFileSerialization
        org.apache.hadoop.io.TestSequenceFile
        org.apache.hadoop.io.TestSetFile

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/232//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/232//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/232//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12470968/HADOOP-7139.patch against trunk revision 1070021. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.io.compress.TestCodec org.apache.hadoop.io.TestArrayFile org.apache.hadoop.io.TestBloomMapFile org.apache.hadoop.io.TestMapFile org.apache.hadoop.io.TestSequenceFileSerialization org.apache.hadoop.io.TestSequenceFile org.apache.hadoop.io.TestSetFile +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/232//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/232//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/232//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12470970/HADOOP-7139.patch
        against trunk revision 1070021.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.io.compress.TestCodec
        org.apache.hadoop.io.TestArrayFile
        org.apache.hadoop.io.TestBloomMapFile
        org.apache.hadoop.io.TestMapFile
        org.apache.hadoop.io.TestSequenceFileSerialization
        org.apache.hadoop.io.TestSequenceFile
        org.apache.hadoop.io.TestSetFile

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/233//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/233//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/233//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12470970/HADOOP-7139.patch against trunk revision 1070021. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.io.compress.TestCodec org.apache.hadoop.io.TestArrayFile org.apache.hadoop.io.TestBloomMapFile org.apache.hadoop.io.TestMapFile org.apache.hadoop.io.TestSequenceFileSerialization org.apache.hadoop.io.TestSequenceFile org.apache.hadoop.io.TestSetFile +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/233//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/233//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/233//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12471759/HADOOP-7139.patch
        against trunk revision 1071364.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/295//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/295//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/295//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12471759/HADOOP-7139.patch against trunk revision 1071364. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/295//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/295//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/295//console This message is automatically generated.
        Hide
        Stephen Rose added a comment -

        No additional unit tests created as checksum fs doesn't support append. Have tested on HDFS.

        Show
        Stephen Rose added a comment - No additional unit tests created as checksum fs doesn't support append. Have tested on HDFS.
        Hide
        Todd Lipcon added a comment -
        • looks like the patch introduces some incorrect whitespace - our coding style is to use two spaces for indentation, and no "hard tabs"
        • appending to a seqfile should probably check that the version of the seqfile to be appended is the same as the current file format version - I see you added a getVersion() function but it's not used.
        • the Release Note and JIRA description indicates support for appending to MapFile, but that isn't available in the API.
        • It seems the change to be able to specify the compression block size is a separate logical change from the ability to append. We should probably break this into two JIRAs since it's two different features.
        Show
        Todd Lipcon added a comment - looks like the patch introduces some incorrect whitespace - our coding style is to use two spaces for indentation, and no "hard tabs" appending to a seqfile should probably check that the version of the seqfile to be appended is the same as the current file format version - I see you added a getVersion() function but it's not used. the Release Note and JIRA description indicates support for appending to MapFile, but that isn't available in the API. It seems the change to be able to specify the compression block size is a separate logical change from the ability to append. We should probably break this into two JIRAs since it's two different features.
        Hide
        Todd Lipcon added a comment -

        Also, could you write a unit test for this against RawLocalFileSystem? eg create a seqfile, close it, reopen it, append, close it, and then verify you can read the whole thing?

        Show
        Todd Lipcon added a comment - Also, could you write a unit test for this against RawLocalFileSystem? eg create a seqfile, close it, reopen it, append, close it, and then verify you can read the whole thing?
        Hide
        Tom White added a comment -

        Sorry, I made a mistake assigning this a moment ago when marking it as open (while Todd's feedback is addressed).

        Show
        Tom White added a comment - Sorry, I made a mistake assigning this a moment ago when marking it as open (while Todd's feedback is addressed).
        Hide
        Kristofer Tomasette added a comment -

        This patch depends on HADOOP-7817

        Show
        Kristofer Tomasette added a comment - This patch depends on HADOOP-7817
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12510845/HADOOP-7139-kt.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 26 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/515//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12510845/HADOOP-7139-kt.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 26 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/515//console This message is automatically generated.
        Hide
        Keith Wyss added a comment -

        Looking at this patch, it looks like a bunch of bookkeeping about compression metadata and support for not initializing the file with the typical SequenceFile header. Am I reading it correctly? Will this apply cleanly to #"CDH3U[45]"? Anyone tested it on those systems? Thank you.

        Show
        Keith Wyss added a comment - Looking at this patch, it looks like a bunch of bookkeeping about compression metadata and support for not initializing the file with the typical SequenceFile header. Am I reading it correctly? Will this apply cleanly to #"CDH3U [45] "? Anyone tested it on those systems? Thank you.
        Hide
        Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 0s The patch command could not apply the patch during dryrun.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12510845/HADOOP-7139-kt.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / f1a152c
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6260/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12510845/HADOOP-7139-kt.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / f1a152c Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6260/console This message was automatically generated.
        Hide
        Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 0s The patch command could not apply the patch during dryrun.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12510845/HADOOP-7139-kt.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 4102e58
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6847/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12510845/HADOOP-7139-kt.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 4102e58 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6847/console This message was automatically generated.
        Hide
        Kanaka Kumar Avvaru added a comment -

        Cancelling the patch as its no longer can be applied on trunk.

        Show
        Kanaka Kumar Avvaru added a comment - Cancelling the patch as its no longer can be applied on trunk.
        Hide
        Kanaka Kumar Avvaru added a comment -

        Assigning to myself to update the patch. Stephen Rose , please feel free to assign back if you would like to continue work on this JIRA

        Show
        Kanaka Kumar Avvaru added a comment - Assigning to myself to update the patch. Stephen Rose , please feel free to assign back if you would like to continue work on this JIRA
        Hide
        Kanaka Kumar Avvaru added a comment -

        Added patch to support append for sequence file with test code on local file system.

        Show
        Kanaka Kumar Avvaru added a comment - Added patch to support append for sequence file with test code on local file system.
        Hide
        Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 15s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 26s There were no new javac warning messages.
        +1 javadoc 9m 35s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 5s The applied patch generated 5 new checkstyle issues (total was 280, now 284).
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 22m 9s Tests passed in hadoop-common.
            60m 52s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12738301/HADOOP-7139-01.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / a6cb489
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6938/artifact/patchprocess/diffcheckstylehadoop-common.txt
        whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6938/artifact/patchprocess/whitespace.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6938/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6938/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6938/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 15s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 26s There were no new javac warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 5s The applied patch generated 5 new checkstyle issues (total was 280, now 284). -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 9s Tests passed in hadoop-common.     60m 52s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12738301/HADOOP-7139-01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / a6cb489 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6938/artifact/patchprocess/diffcheckstylehadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6938/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6938/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6938/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6938/console This message was automatically generated.
        Hide
        Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 30s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 39s There were no new javac warning messages.
        +1 javadoc 9m 45s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 5s The applied patch generated 1 new checkstyle issues (total was 279, now 279).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 49s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 23m 8s Tests passed in hadoop-common.
            62m 30s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12738320/HADOOP-7139-02.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / c7ee6c1
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6939/artifact/patchprocess/diffcheckstylehadoop-common.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6939/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6939/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6939/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 30s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 39s There were no new javac warning messages. +1 javadoc 9m 45s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 5s The applied patch generated 1 new checkstyle issues (total was 279, now 279). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 49s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 8s Tests passed in hadoop-common.     62m 30s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12738320/HADOOP-7139-02.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / c7ee6c1 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6939/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6939/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6939/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6939/console This message was automatically generated.
        Hide
        Vinayakumar B added a comment -

        Patch looks good.
        I think, some of the checkstyle comments can be corrected.
        +1 once done.

        Show
        Vinayakumar B added a comment - Patch looks good. I think, some of the checkstyle comments can be corrected. +1 once done.
        Hide
        Kanaka Kumar Avvaru added a comment -

        Thanks for the review Vinayakumar B . Based on latest precommit build result, the only checkstyle issue remaining is about file length > 2000 lines (File length is 3,743 lines (max allowed is 2,000)).
        But the file was already big before these changes, we can ignore it in my opinion.

        Show
        Kanaka Kumar Avvaru added a comment - Thanks for the review Vinayakumar B . Based on latest precommit build result, the only checkstyle issue remaining is about file length > 2000 lines (File length is 3,743 lines (max allowed is 2,000)). But the file was already big before these changes, we can ignore it in my opinion.
        Hide
        Vinayakumar B added a comment -

        Thanks for the review Vinayakumar B . Based on latest precommit build result, the only checkstyle issue remaining is about file length > 2000 lines (File length is 3,743 lines (max allowed is 2,000)).

        Oh Yes, By the time I was commenting I didn't check the latest QA report

        +1 for the latest patch.
        Since I can see many watchers, I will hold the commit for 24hrs. Lets see if any more opinions on this.

        Show
        Vinayakumar B added a comment - Thanks for the review Vinayakumar B . Based on latest precommit build result, the only checkstyle issue remaining is about file length > 2000 lines (File length is 3,743 lines (max allowed is 2,000)). Oh Yes, By the time I was commenting I didn't check the latest QA report +1 for the latest patch. Since I can see many watchers, I will hold the commit for 24hrs. Lets see if any more opinions on this.
        Hide
        Vinayakumar B added a comment -

        Kanaka Kumar Avvaru, Just noticed, some nits in Test to be corrected before commit.

        1.

        Path file = new Path(System.getProperty("test.build.data", ".")
               + "/testseqappend.seq");

        Use "build/test/data" as default value for the system property, as all temp files under 'build' will be cleared by 'mvn clean', but not in '.'

        2. fs.close(); at the end of test is not required. Since the tearDown() is having AfterClass annotation, if some other tests added, then they will also get the same fs.

        Show
        Vinayakumar B added a comment - Kanaka Kumar Avvaru , Just noticed, some nits in Test to be corrected before commit. 1. Path file = new Path( System .getProperty( "test.build.data" , "." ) + "/testseqappend.seq" ); Use "build/test/data" as default value for the system property, as all temp files under 'build' will be cleared by 'mvn clean', but not in '.' 2. fs.close(); at the end of test is not required. Since the tearDown() is having AfterClass annotation, if some other tests added, then they will also get the same fs .
        Hide
        Kanaka Kumar Avvaru added a comment -

        Yes I missed them. Thanks for the review Vinayakumar B . I have update new patch after handling these two comments. Please review and commit.

        Show
        Kanaka Kumar Avvaru added a comment - Yes I missed them. Thanks for the review Vinayakumar B . I have update new patch after handling these two comments. Please review and commit.
        Hide
        Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 44s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 39s There were no new javac warning messages.
        +1 javadoc 9m 45s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 4s The applied patch generated 1 new checkstyle issues (total was 279, now 279).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 37s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 23m 19s Tests passed in hadoop-common.
            63m 0s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12738573/HADOOP-7139-03.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 8d0ef31
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6942/artifact/patchprocess/diffcheckstylehadoop-common.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6942/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6942/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6942/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 44s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 39s There were no new javac warning messages. +1 javadoc 9m 45s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 4s The applied patch generated 1 new checkstyle issues (total was 279, now 279). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 19s Tests passed in hadoop-common.     63m 0s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12738573/HADOOP-7139-03.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 8d0ef31 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6942/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6942/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6942/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6942/console This message was automatically generated.
        Hide
        Vinayakumar B added a comment -

        Kanaka Kumar Avvaru, First of all, apologies for making you update patch multiple times.

        On second thought, There might be need of two more tests with different compression types (RECORD and BLOCK).
        Can you update patch with two more tests?

        Show
        Vinayakumar B added a comment - Kanaka Kumar Avvaru , First of all, apologies for making you update patch multiple times. On second thought, There might be need of two more tests with different compression types (RECORD and BLOCK). Can you update patch with two more tests?
        Hide
        Kanaka Kumar Avvaru added a comment -

        That's fine Vinayakumar B. I appreciate the your detailed review and focus on the impact.

        I am currently adding the test cases for compression types, key/value classes & metadata mismatches. Looks like some impact is there on file with compressed blocks.I Will inspect and update patch.

        Show
        Kanaka Kumar Avvaru added a comment - That's fine Vinayakumar B . I appreciate the your detailed review and focus on the impact. I am currently adding the test cases for compression types, key/value classes & metadata mismatches. Looks like some impact is there on file with compressed blocks.I Will inspect and update patch.
        Hide
        Kanaka Kumar Avvaru added a comment -

        Thanks Vinayakumar B for the reviews. Updated patch with suggested+required test cases.

        Following points to be noted while using sequence file append

        • Compression options has to be provided same as used during the original file creation
        • Metadata option is ignored during writer creation as re-writing the metadata is not allowed
        • Key/Value should match the options used during original file
        Show
        Kanaka Kumar Avvaru added a comment - Thanks Vinayakumar B for the reviews. Updated patch with suggested+required test cases. Following points to be noted while using sequence file append Compression options has to be provided same as used during the original file creation Metadata option is ignored during writer creation as re-writing the metadata is not allowed Key/Value should match the options used during original file
        Hide
        Vinayakumar B added a comment -

        On Quick look patch seems fine.
        Will take a deep look tomorrow, meanwhile let's jenkins verify the changes.

        Show
        Vinayakumar B added a comment - On Quick look patch seems fine. Will take a deep look tomorrow, meanwhile let's jenkins verify the changes.
        Hide
        Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 22s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 32s There were no new javac warning messages.
        +1 javadoc 9m 36s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 4s The applied patch generated 2 new checkstyle issues (total was 280, now 281).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 1m 48s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 23m 50s Tests passed in hadoop-common.
            62m 48s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12739204/HADOOP-7139-04.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / d8dcfa9
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6960/artifact/patchprocess/diffcheckstylehadoop-common.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6960/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6960/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6960/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 22s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 32s There were no new javac warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 4s The applied patch generated 2 new checkstyle issues (total was 280, now 281). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 48s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 50s Tests passed in hadoop-common.     62m 48s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12739204/HADOOP-7139-04.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d8dcfa9 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6960/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6960/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6960/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6960/console This message was automatically generated.
        Hide
        Kanaka Kumar Avvaru added a comment -

        Updated patch for check style issue (Line is longer than 80 characters).
        Another check style issue related for > 2000 lines can be ignored

        Show
        Kanaka Kumar Avvaru added a comment - Updated patch for check style issue (Line is longer than 80 characters). Another check style issue related for > 2000 lines can be ignored
        Hide
        Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 56s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 50s There were no new javac warning messages.
        +1 javadoc 9m 55s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 6s The applied patch generated 1 new checkstyle issues (total was 279, now 279).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 53s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 common tests 23m 21s Tests failed in hadoop-common.
            63m 37s  



        Reason Tests
        Failed unit tests hadoop.fs.shell.TestCount



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12739906/HADOOP-7139-05.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / b039e69
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6973/artifact/patchprocess/diffcheckstylehadoop-common.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6973/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6973/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6973/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 56s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 50s There were no new javac warning messages. +1 javadoc 9m 55s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 6s The applied patch generated 1 new checkstyle issues (total was 279, now 279). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 53s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 23m 21s Tests failed in hadoop-common.     63m 37s   Reason Tests Failed unit tests hadoop.fs.shell.TestCount Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12739906/HADOOP-7139-05.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / b039e69 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6973/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6973/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6973/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6973/console This message was automatically generated.
        Hide
        Vinayakumar B added a comment -

        +1 for the latest patch.
        Will commit soon.

        Show
        Vinayakumar B added a comment - +1 for the latest patch. Will commit soon.
        Hide
        Vinayakumar B added a comment -

        Committed to trunk and branch-2.

        Thanks for Stephen Rose for reporting Jira and initial patch.
        Thanks Kristofer Tomasette for the update on the patch.
        Thanks Kanaka Kumar Avvaru for the final series of updates.

        Thanks Todd Lipcon, Tom White and Keith Wyss for reviews.

        Show
        Vinayakumar B added a comment - Committed to trunk and branch-2. Thanks for Stephen Rose for reporting Jira and initial patch. Thanks Kristofer Tomasette for the update on the patch. Thanks Kanaka Kumar Avvaru for the final series of updates. Thanks Todd Lipcon , Tom White and Keith Wyss for reviews.
        Hide
        Kanaka Kumar Avvaru added a comment -

        Thanks Vinayakumar B for reviews and commit

        Show
        Kanaka Kumar Avvaru added a comment - Thanks Vinayakumar B for reviews and commit
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8037 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8037/)
        HADOOP-7139. Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev 295d678be8853a52c3ec3da43d9265478d6632b3)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFileAppend.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8037 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8037/ ) HADOOP-7139 . Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev 295d678be8853a52c3ec3da43d9265478d6632b3) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFileAppend.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #962 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/962/)
        HADOOP-7139. Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev 295d678be8853a52c3ec3da43d9265478d6632b3)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFileAppend.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #962 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/962/ ) HADOOP-7139 . Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev 295d678be8853a52c3ec3da43d9265478d6632b3) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFileAppend.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #232 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/232/)
        HADOOP-7139. Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev 295d678be8853a52c3ec3da43d9265478d6632b3)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFileAppend.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #232 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/232/ ) HADOOP-7139 . Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev 295d678be8853a52c3ec3da43d9265478d6632b3) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFileAppend.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2160 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2160/)
        HADOOP-7139. Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev 295d678be8853a52c3ec3da43d9265478d6632b3)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFileAppend.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2160 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2160/ ) HADOOP-7139 . Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev 295d678be8853a52c3ec3da43d9265478d6632b3) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFileAppend.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #221 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/221/)
        HADOOP-7139. Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev 295d678be8853a52c3ec3da43d9265478d6632b3)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFileAppend.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #221 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/221/ ) HADOOP-7139 . Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev 295d678be8853a52c3ec3da43d9265478d6632b3) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFileAppend.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #230 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/230/)
        HADOOP-7139. Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev 295d678be8853a52c3ec3da43d9265478d6632b3)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFileAppend.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #230 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/230/ ) HADOOP-7139 . Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev 295d678be8853a52c3ec3da43d9265478d6632b3) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFileAppend.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2178 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2178/)
        HADOOP-7139. Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev 295d678be8853a52c3ec3da43d9265478d6632b3)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFileAppend.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2178 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2178/ ) HADOOP-7139 . Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev 295d678be8853a52c3ec3da43d9265478d6632b3) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFileAppend.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Maddineni Sukumar added a comment -

        Kanaka Kumar Avvaru / Vinayakumar B

        Thanks for the patch, we were also looking for similar thing in 2.6.0 branch.
        It would be great if we also get this against 2.6.0 branch?

        Show
        Maddineni Sukumar added a comment - Kanaka Kumar Avvaru / Vinayakumar B Thanks for the patch, we were also looking for similar thing in 2.6.0 branch. It would be great if we also get this against 2.6.0 branch?
        Hide
        Kanaka Kumar Avvaru added a comment -

        Vinayakumar B, Can you please check if we can push to 2.6.1 ?

        Show
        Kanaka Kumar Avvaru added a comment - Vinayakumar B , Can you please check if we can push to 2.6.1 ?
        Hide
        Vinayakumar B added a comment -

        Yes, we can push this to both 2.7.2 and 2.6.1.
        I will add a label to this to mark for 2.6.1

        Show
        Vinayakumar B added a comment - Yes, we can push this to both 2.7.2 and 2.6.1. I will add a label to this to mark for 2.6.1
        Hide
        Vinayakumar B added a comment -

        Cherry-picked to both 2.7.2 and 2.6.1

        Show
        Vinayakumar B added a comment - Cherry-picked to both 2.7.2 and 2.6.1
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8304 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8304/)
        HADOOP-7139. Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev fc508b41a90a193f06a0e28ee40862bf9ee0f0c7)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8304 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8304/ ) HADOOP-7139 . Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev fc508b41a90a193f06a0e28ee40862bf9ee0f0c7) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #287 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/287/)
        HADOOP-7139. Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev fc508b41a90a193f06a0e28ee40862bf9ee0f0c7)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #287 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/287/ ) HADOOP-7139 . Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev fc508b41a90a193f06a0e28ee40862bf9ee0f0c7) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1017 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1017/)
        HADOOP-7139. Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev fc508b41a90a193f06a0e28ee40862bf9ee0f0c7)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1017 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1017/ ) HADOOP-7139 . Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev fc508b41a90a193f06a0e28ee40862bf9ee0f0c7) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #284 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/284/)
        HADOOP-7139. Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev fc508b41a90a193f06a0e28ee40862bf9ee0f0c7)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #284 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/284/ ) HADOOP-7139 . Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev fc508b41a90a193f06a0e28ee40862bf9ee0f0c7) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2233 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2233/)
        HADOOP-7139. Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev fc508b41a90a193f06a0e28ee40862bf9ee0f0c7)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2233 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2233/ ) HADOOP-7139 . Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev fc508b41a90a193f06a0e28ee40862bf9ee0f0c7) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2214 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2214/)
        HADOOP-7139. Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev fc508b41a90a193f06a0e28ee40862bf9ee0f0c7)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2214 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2214/ ) HADOOP-7139 . Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev fc508b41a90a193f06a0e28ee40862bf9ee0f0c7) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #276 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/276/)
        HADOOP-7139. Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev fc508b41a90a193f06a0e28ee40862bf9ee0f0c7)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #276 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/276/ ) HADOOP-7139 . Allow appending to existing SequenceFiles (Contributed by kanaka kumar avvaru) (vinayakumarb: rev fc508b41a90a193f06a0e28ee40862bf9ee0f0c7) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Vinod Kumar Vavilapalli added a comment -

        Vinayakumar B, please stop committing to 2.6.1 (branch-2.6 or branch-2.6.1), we have a fairly elaborate parallel release-process going on for 2.6.1 and these cherry-picks are disrupting our progress. Thanks.

        Show
        Vinod Kumar Vavilapalli added a comment - Vinayakumar B , please stop committing to 2.6.1 (branch-2.6 or branch-2.6.1), we have a fairly elaborate parallel release-process going on for 2.6.1 and these cherry-picks are disrupting our progress. Thanks.
        Hide
        Vinayakumar B added a comment -

        Thanks Vinod Kumar Vavilapalli. I am actually cherry-picking only those which are listed for 2.6.1 here https://wiki.apache.org/hadoop/Release-2.6.1-Working-Notes.
        Anyway I will stop further merges until required.
        -Thanks

        Show
        Vinayakumar B added a comment - Thanks Vinod Kumar Vavilapalli . I am actually cherry-picking only those which are listed for 2.6.1 here https://wiki.apache.org/hadoop/Release-2.6.1-Working-Notes . Anyway I will stop further merges until required. -Thanks
        Hide
        Vinod Kumar Vavilapalli added a comment -

        This was marked as committed in 2.6.1 but it wasn't actually in the 2.6.1 branch. Presumably because it got committed to 2.6 and by that time I already created the 2.6.1 branch.

        I just pushed the fix to the right 2.6.1 branch. Ran compilation and TestSequenceFileAppend before the push.

        Show
        Vinod Kumar Vavilapalli added a comment - This was marked as committed in 2.6.1 but it wasn't actually in the 2.6.1 branch. Presumably because it got committed to 2.6 and by that time I already created the 2.6.1 branch. I just pushed the fix to the right 2.6.1 branch. Ran compilation and TestSequenceFileAppend before the push.

          People

          • Assignee:
            Kanaka Kumar Avvaru
            Reporter:
            Stephen Rose
          • Votes:
            2 Vote for this issue
            Watchers:
            19 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2h
              2h
              Remaining:
              Remaining Estimate - 2h
              2h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development