Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Removed contrib related build targets.

      Description

      As per vote on general@ (http://mail-archives.apache.org/mod_mbox/hadoop-general/201102.mbox/%3CAC35A7EF-1D68-4055-8D47-EDA2FCF8C2F6@mac.com%3E) I will
      svn remove common/trunk/src/contrib/hod
      using this Jira.

      1. HADOOP-7137-additional.patch
        86 kB
        Nigel Daley
      2. HADOOP-7137.patch
        602 kB
        Nigel Daley
      3. HADOOP-7137.patch
        574 kB
        Nigel Daley

        Activity

        Hide
        Owen O'Malley added a comment -

        This can't be committed until consensus is reached and Allen has -1'ed it.

        Show
        Owen O'Malley added a comment - This can't be committed until consensus is reached and Allen has -1'ed it.
        Hide
        Nigel Daley added a comment -

        Depends whether this falls under "Code Change" or "Adoption of New Codebase". The vote was clearly a question for the PMC. I'm fine either way.

        Show
        Nigel Daley added a comment - Depends whether this falls under "Code Change" or "Adoption of New Codebase". The vote was clearly a question for the PMC. I'm fine either way.
        Hide
        Arun C Murthy added a comment -

        For now, we could remove it from builds etc.

        Show
        Arun C Murthy added a comment - For now, we could remove it from builds etc.
        Hide
        Mahadev konar added a comment -

        sad but +1 on removing it from builds.

        Show
        Mahadev konar added a comment - sad but +1 on removing it from builds.
        Hide
        Nigel Daley added a comment -

        We couldn't reach consensus on this so we won't be removing HOD for now.

        Show
        Nigel Daley added a comment - We couldn't reach consensus on this so we won't be removing HOD for now.
        Hide
        Nigel Daley added a comment -

        Allen removed his -1. Reopening this.

        Show
        Nigel Daley added a comment - Allen removed his -1. Reopening this.
        Hide
        Nigel Daley added a comment -

        Updated patch, ready for review.

        Show
        Nigel Daley added a comment - Updated patch, ready for review.
        Hide
        Nigel Daley added a comment -

        This incorporates HADOOP-7138 and removes contrib from build and test targets.

        Show
        Nigel Daley added a comment - This incorporates HADOOP-7138 and removes contrib from build and test targets.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12477191/HADOOP-7137.patch
        against trunk revision 1095958.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 80 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/373//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12477191/HADOOP-7137.patch against trunk revision 1095958. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 80 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/373//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        +1

        lgtm

        Show
        Eli Collins added a comment - +1 lgtm
        Hide
        Eli Collins added a comment -

        I've committed this to trunk and branch 22. Thanks Nigel!

        Tested via ant tar and ant package instead of Hudson since most of the change was done via svn remove (the patch only applies to build.xml).

        Show
        Eli Collins added a comment - I've committed this to trunk and branch 22. Thanks Nigel! Tested via ant tar and ant package instead of Hudson since most of the change was done via svn remove (the patch only applies to build.xml).
        Hide
        Trevor Robinson added a comment -

        This commit removed test-contrib which is run by Hudson in PreCommit-HADOOP-Build:

        [exec] ======================================================================
        [exec] ======================================================================
        [exec] Running contrib tests.
        [exec] ======================================================================
        [exec] ======================================================================
        [exec]
        [exec]
        [exec] /bin/kill -9 12446
        [exec] kill: No such process
        [exec] /homes/hudson/tools/ant/latest/bin/ant -Dversion=1102861_HADOOP-7290_PATCH-12479160 -Declipse.home=/homes/hudson/tools/eclipse/latest -Dpython.home=/homes/hudson/tools/python/latest -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=no test-contrib
        [exec] Buildfile: build.xml
        [exec]
        [exec] BUILD FAILED
        [exec] Target "test-contrib" does not exist in the project "Hadoop-Common".
        [exec]
        [exec] Total time: 0 seconds

        Show
        Trevor Robinson added a comment - This commit removed test-contrib which is run by Hudson in PreCommit-HADOOP-Build: [exec] ====================================================================== [exec] ====================================================================== [exec] Running contrib tests. [exec] ====================================================================== [exec] ====================================================================== [exec] [exec] [exec] /bin/kill -9 12446 [exec] kill: No such process [exec] /homes/hudson/tools/ant/latest/bin/ant -Dversion=1102861_ HADOOP-7290 _PATCH-12479160 -Declipse.home=/homes/hudson/tools/eclipse/latest -Dpython.home=/homes/hudson/tools/python/latest -DHadoopPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=no test-contrib [exec] Buildfile: build.xml [exec] [exec] BUILD FAILED [exec] Target "test-contrib" does not exist in the project "Hadoop-Common". [exec] [exec] Total time: 0 seconds
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Why not wait for Hudson/Jenkins?

        Show
        Tsz Wo Nicholas Sze added a comment - Why not wait for Hudson/Jenkins?
        Hide
        Eli Collins added a comment -

        I should have. I didn't because most of the change is done via svn remove instead of applying the patch, so I ran the full tarball build, but waiting for Hudson would have caught HADOOP-7291 (the required change to test-patch.sh).

        Show
        Eli Collins added a comment - I should have. I didn't because most of the change is done via svn remove instead of applying the patch, so I ran the full tarball build, but waiting for Hudson would have caught HADOOP-7291 (the required change to test-patch.sh).
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #688 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/688/)
        HADOOP-7137. Remove hod contrib. Contributed by Nigel Daley

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #688 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/688/ ) HADOOP-7137 . Remove hod contrib. Contributed by Nigel Daley
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #601 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/601/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #601 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/601/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-22-branch #49 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/49/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-22-branch #49 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/49/ )
        Hide
        Nigel Daley added a comment -

        Just removed contrib/hod from Jira and add to the Attic wiki: http://wiki.apache.org/hadoop/Attic

        Show
        Nigel Daley added a comment - Just removed contrib/hod from Jira and add to the Attic wiki: http://wiki.apache.org/hadoop/Attic
        Hide
        Nigel Daley added a comment -

        Oops, I mean I closed as won't fix all the hod Jira's. I didn't actually removed the Jira component.

        Show
        Nigel Daley added a comment - Oops, I mean I closed as won't fix all the hod Jira's. I didn't actually removed the Jira component.
        Hide
        Nigel Daley added a comment -

        A patch to also remove HOD english docs.

        Show
        Nigel Daley added a comment - A patch to also remove HOD english docs.
        Hide
        Eli Collins added a comment -

        +1

        I built and verified the generated docs.

        Show
        Eli Collins added a comment - +1 I built and verified the generated docs.
        Hide
        Eli Collins added a comment -

        I've committed this to branch 22 and trunk. Thanks Nigel!

        Show
        Eli Collins added a comment - I've committed this to branch 22 and trunk. Thanks Nigel!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #609 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/609/)
        HADOOP-7137. Remove hod contrib docs. Contributed by Nigel Daley

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124456
        Files :

        • /hadoop/common/trunk/src/docs/src/documentation/content/xdocs/site.xml
        • /hadoop/common/trunk/src/docs/src/documentation/content/xdocs/hod_scheduler.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #609 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/609/ ) HADOOP-7137 . Remove hod contrib docs. Contributed by Nigel Daley eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124456 Files : /hadoop/common/trunk/src/docs/src/documentation/content/xdocs/site.xml /hadoop/common/trunk/src/docs/src/documentation/content/xdocs/hod_scheduler.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-22-branch #52 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/52/)
        HADOOP-7137. svn merge -c 1124456 from trunk

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124457
        Files :

        • /hadoop/common/branches/branch-0.22/src/docs
        • /hadoop/common/branches/branch-0.22/src/docs/src/documentation/content/xdocs/hod_scheduler.xml
        • /hadoop/common/branches/branch-0.22
        • /hadoop/common/branches/branch-0.22/src/test/core
        • /hadoop/common/branches/branch-0.22/src/test/core/org/apache/hadoop/io/TestSequenceFile.java
        • /hadoop/common/branches/branch-0.22/CHANGES.txt
        • /hadoop/common/branches/branch-0.22/src/java
        • /hadoop/common/branches/branch-0.22/src/docs/src/documentation/content/xdocs/site.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-22-branch #52 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/52/ ) HADOOP-7137 . svn merge -c 1124456 from trunk eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124457 Files : /hadoop/common/branches/branch-0.22/src/docs /hadoop/common/branches/branch-0.22/src/docs/src/documentation/content/xdocs/hod_scheduler.xml /hadoop/common/branches/branch-0.22 /hadoop/common/branches/branch-0.22/src/test/core /hadoop/common/branches/branch-0.22/src/test/core/org/apache/hadoop/io/TestSequenceFile.java /hadoop/common/branches/branch-0.22/CHANGES.txt /hadoop/common/branches/branch-0.22/src/java /hadoop/common/branches/branch-0.22/src/docs/src/documentation/content/xdocs/site.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #693 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/693/)
        HADOOP-7137. Remove hod contrib docs. Contributed by Nigel Daley

        eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124456
        Files :

        • /hadoop/common/trunk/src/docs/src/documentation/content/xdocs/site.xml
        • /hadoop/common/trunk/src/docs/src/documentation/content/xdocs/hod_scheduler.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #693 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/693/ ) HADOOP-7137 . Remove hod contrib docs. Contributed by Nigel Daley eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1124456 Files : /hadoop/common/trunk/src/docs/src/documentation/content/xdocs/site.xml /hadoop/common/trunk/src/docs/src/documentation/content/xdocs/hod_scheduler.xml

          People

          • Assignee:
            Nigel Daley
            Reporter:
            Nigel Daley
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development