Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-7131

set() and toString Methods of the org.apache.hadoop.io.Text class does not include the root exception, in the wrapping RuntimeException.

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 0.20.1, 0.20.2
    • 0.23.0
    • io
    • None
    • Reviewed

    Description

      In below code snippets, we can include e, instead of e.toString(), so that caller can get complete trace.

      1)
      /** Set to contain the contents of a string.
      */
      public void set(String string) {
      try

      { ByteBuffer bb = encode(string, true); bytes = bb.array(); length = bb.limit(); }

      catch(CharacterCodingException e)

      { throw new RuntimeException("Should not have happened ",e.toString()); }
      }
      2)
      public String toString() {
      try { return decode(bytes, 0, length); } catch (CharacterCodingException e) { throw new RuntimeException("Should not have happened ",e.toString()); }

      }

      Attachments

        1. HADOOP-7131.patch
          0.8 kB
          Uma Maheswara Rao G

        Activity

          People

            umamaheswararao Uma Maheswara Rao G
            umamaheswararao Uma Maheswara Rao G
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: